Skip to contentSkip to conversation

mm: Do not stall register_shrinker

PATCH Applied Minchan Kim 3 participants 4 messages Nov 24, 2017 – Nov 27, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Do not stall register_shrinker

Shakeel Butt reported, he have observed in production system that the job loader gets stuck for 10s of seconds while doing mount operation. It turns out that it was stuck in register_shrinker() and some unrelated job was under memory pressure and spending time in shrink_slab(). Machines have a lot of shrinkers registered and jobs under memory pressure has to traverse all of those memcg-aware shrinkers and do affect unrelated jobs which want to register their own shrinkers.

To solve the issue, this patch simply bails out slab shrinking once it found someone want to register shrinker in parallel. A downside is it could cause unfair shrinking between shrinkers. However, it should be rare and we can add compilcated logic once we found it's not enough.

---
 mm/vmscan.c | 8 ++++++++
 1 file changed, 8 insertions(+)
mm/vmscan.c +8 -0
index 6a5a72baccd5..6698001787bd 100644
@@ -486,6 +486,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
 			sc.nid = 0;
 
 		freed += do_shrink_slab(&sc, shrinker, priority);
+		/*
+		 * bail out if someone want to register a new shrinker to
+		 * prevent long time stall by parallel ongoing shrinking.
+		 */
+		if (rwsem_is_contended(&shrinker_rwsem)) {
+			freed = freed ? : 1;
+			break;
+		}
 	}
 
 	up_read(&shrinker_rwsem);
Signature · 1 line
2.7.4
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Minchan Kim

Shakeel Butt reported, he have observed in production system that the job loader gets stuck for 10s of seconds while doing mount operation. It turns out that it was stuck in register_shrinker() and some unrelated job was under memory pressure and spending time in shrink_slab(). Machines have a lot of shrinkers registered and jobs under memory pressure has to traverse all of those memcg-aware shrinkers and do affect unrelated jobs which want to register their own shrinkers.

To solve the issue, this patch simply bails out slab shrinking once it found someone want to register shrinker in parallel. A downside is it could cause unfair shrinking between shrinkers. However, it should be rare and we can add compilcated logic once we found it's not enough.

Quoted 7 lines
Quoted 26 lines
---
 mm/vmscan.c | 8 ++++++++
 1 file changed, 8 insertions(+)
mm/vmscan.c +8 -0
index 6a5a72baccd5..6698001787bd 100644
@@ -486,6 +486,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
 			sc.nid = 0;
 
 		freed += do_shrink_slab(&sc, shrinker, priority);
+		/*
+		 * bail out if someone want to register a new shrinker to
+		 * prevent long time stall by parallel ongoing shrinking.
+		 */
+		if (rwsem_is_contended(&shrinker_rwsem)) {
+			freed = freed ? : 1;
+			break;
+		}
 	}
 
 	up_read(&shrinker_rwsem);
Signature · 1 line
2.7.4
Signature · 8 lines
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#2 lore raw
In reply to Minchan Kim
Quoted 32 lines · Minchan Kim

Shakeel Butt reported, he have observed in production system that the job loader gets stuck for 10s of seconds while doing mount operation. It turns out that it was stuck in register_shrinker() and some unrelated job was under memory pressure and spending time in shrink_slab(). Machines have a lot of shrinkers registered and jobs under memory pressure has to traverse all of those memcg-aware shrinkers and do affect unrelated jobs which want to register their own shrinkers.

To solve the issue, this patch simply bails out slab shrinking once it found someone want to register shrinker in parallel. A downside is it could cause unfair shrinking between shrinkers. However, it should be rare and we can add compilcated logic once we found it's not enough.

---
 mm/vmscan.c | 8 ++++++++
 1 file changed, 8 insertions(+)
mm/vmscan.c +0 -0
index 6a5a72baccd5..6698001787bd 100644
@@ -486,6 +486,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
 			sc.nid = 0;

mm/vmscan.c static unsigned long shrink_slab(gfp_t gfp_mask, int nid, · line 496

Quoted 10 lines
mm/vmscan.c +8 -0
 
 		freed += do_shrink_slab(&sc, shrinker, priority);
+		/*
+		 * bail out if someone want to register a new shrinker to
+		 * prevent long time stall by parallel ongoing shrinking.
+		 */
+		if (rwsem_is_contended(&shrinker_rwsem)) {
+			freed = freed ? : 1;
+			break;
+		}

This is similar to when it aborts for not being able to grab the shrinker_rwsem at the beginning.

if (!down_read_trylock(&shrinker_rwsem)) {
	/*
	 * If we would return 0, our callers would understand that we
	 * have nothing else to shrink and give up trying. By returning
	 * 1 we keep it going and assume we'll be able to shrink next
	 * time.
	 */
	freed = 1;
	goto out;
}

Right now, shrink_slab() is getting called from three places. Twice in shrink_node() and once in drop_slab_node(). But the return value from shrink_slab() is checked only inside drop_slab_node() and it has some heuristics to decide whether to keep on scanning over available memcg shrinkers registered.

The question is does aborting here will still guarantee forward progress for all the contexts which might be attempting to allocate memory and had eventually invoked shrink_slab() ? Because may be the memory allocation request has more priority than a context getting bit delayed while being stuck waiting on shrinker_rwsem.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#3 lore raw
Quoted 64 lines · Anshuman Khandual
Quoted 32 lines · Minchan Kim

Shakeel Butt reported, he have observed in production system that the job loader gets stuck for 10s of seconds while doing mount operation. It turns out that it was stuck in register_shrinker() and some unrelated job was under memory pressure and spending time in shrink_slab(). Machines have a lot of shrinkers registered and jobs under memory pressure has to traverse all of those memcg-aware shrinkers and do affect unrelated jobs which want to register their own shrinkers.

To solve the issue, this patch simply bails out slab shrinking once it found someone want to register shrinker in parallel. A downside is it could cause unfair shrinking between shrinkers. However, it should be rare and we can add compilcated logic once we found it's not enough.

---
 mm/vmscan.c | 8 ++++++++
 1 file changed, 8 insertions(+)
mm/vmscan.c +0 -0
index 6a5a72baccd5..6698001787bd 100644
@@ -486,6 +486,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
 			sc.nid = 0;

mm/vmscan.c static unsigned long shrink_slab(gfp_t gfp_mask, int nid, · line 496

Quoted 10 lines
mm/vmscan.c +8 -0
 
 		freed += do_shrink_slab(&sc, shrinker, priority);
+		/*
+		 * bail out if someone want to register a new shrinker to
+		 * prevent long time stall by parallel ongoing shrinking.
+		 */
+		if (rwsem_is_contended(&shrinker_rwsem)) {
+			freed = freed ? : 1;
+			break;
+		}

This is similar to when it aborts for not being able to grab the shrinker_rwsem at the beginning.

if (!down_read_trylock(&shrinker_rwsem)) {
	/*
	 * If we would return 0, our callers would understand that we
	 * have nothing else to shrink and give up trying. By returning
	 * 1 we keep it going and assume we'll be able to shrink next
	 * time.
	 */
	freed = 1;
	goto out;
}

Right now, shrink_slab() is getting called from three places. Twice in shrink_node() and once in drop_slab_node(). But the return value from shrink_slab() is checked only inside drop_slab_node() and it has some heuristics to decide whether to keep on scanning over available memcg shrinkers registered.

Quoted 5 lines

The question is does aborting here will still guarantee forward progress for all the contexts which might be attempting to allocate memory and had eventually invoked shrink_slab() ? Because may be the memory allocation request has more priority than a context getting bit delayed while being stuck waiting on shrinker_rwsem.

Some of routines relied on temporal return's value of shrink_slab to make decisions in procedure of progress of reclaimaing. It might affect whole procedure progress of shrinking at that time. However, we have removed such heusristic and unified it with checking forard progress during MAX_RECAIM_RETRIES trial so I don't think it makes big difference.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>