X.509: use crypto_shash_digest()

PATCH New Eric Biggers 1 participant 1 message Nov 27, 2017

Subsystems (3)

Crypto API Keys/keyrings Asymmetric keys

lore

Share & tools

lore

Eric Biggers

author

2017-11-27 07:19 UTC #0 lore raw

PATCH 1/1 X.509: use crypto_shash_digest()

From: Eric Biggers <[email protected]>

Use crypto_shash_digest() instead of crypto_shash_init() followed by crypto_shash_finup(). (For simplicity only; they are equivalent.)

Signed-off-by Eric Biggers <[email protected]>

---
 crypto/asymmetric_keys/x509_public_key.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

crypto/asymmetric_keys/x509_public_key.c +1 -5

index 9db20abe78a0..3b39c0659155 100644
@@ -79,11 +79,7 @@ int x509_get_sig_params(struct x509_certificate *cert)
 	desc->tfm = tfm;
 	desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP;
 
-	ret = crypto_shash_init(desc);
-	if (ret < 0)
-		goto error_2;
-	might_sleep();
-	ret = crypto_shash_finup(desc, cert->tbs, cert->tbs_size, sig->digest);
+	ret = crypto_shash_digest(desc, cert->tbs, cert->tbs_size, sig->digest);
 	if (ret < 0)
 		goto error_2;

Signature · 1 line

2.15.0