pkcs7: use crypto_shash_digest()

PATCH New Eric Biggers 1 participant 1 message Nov 27, 2017

Subsystems (3)

Crypto API Keys/keyrings Asymmetric keys

lore

Share & tools

lore

Eric Biggers

author

2017-11-27 07:20 UTC #0 lore raw

PATCH 1/1 pkcs7: use crypto_shash_digest()

From: Eric Biggers <[email protected]>

Use crypto_shash_digest() instead of crypto_shash_init() followed by crypto_shash_finup(). (For simplicity only; they are equivalent.)

Signed-off-by Eric Biggers <[email protected]>

---
 crypto/asymmetric_keys/pkcs7_verify.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

crypto/asymmetric_keys/pkcs7_verify.c +2 -5

index 063d6745c741..1647313872aa 100644
@@ -59,11 +59,8 @@ static int pkcs7_digest(struct pkcs7_message *pkcs7,
 	desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP;
 
 	/* Digest the message [RFC2315 9.3] */
-	ret = crypto_shash_init(desc);
-	if (ret < 0)
-		goto error;
-	ret = crypto_shash_finup(desc, pkcs7->data, pkcs7->data_len,
-				 sig->digest);
+	ret = crypto_shash_digest(desc, pkcs7->data, pkcs7->data_len,
+				  sig->digest);
 	if (ret < 0)
 		goto error;
 	pr_devel("MsgDigest = [%*ph]\n", 8, sig->digest);

Signature · 1 line

2.15.0