Skip to contentSkip to conversation

linphone: add libupnp dependency

PATCH New Fabrice Fontaine 3 participants 3 messages Nov 26, 2017 – Dec 20, 2017

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 linphone: add libupnp dependency

linphone is compatible with libupnp but not with libupnp18 so disable upnp if libupnp is not enabled

Fixes:
- http://autobuild.buildroot.net/results/473c686f9bc5335d25b720cf1b0c45389138a7b4

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/linphone/linphone.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/linphone/linphone.mk +7 -0
index fb5e18db6..a10d6bb20 100644
@@ -50,4 +50,11 @@ else
 LINPHONE_CONF_OPTS += --disable-libv4l1 --disable-libv4l2
 endif
 
+ifeq ($(BR2_PACKAGE_LIBUPNP),y)
+LINPHONE_DEPENDENCIES += libupnp
+LINPHONE_CONF_OPTS += --enable-upnp
+else
+LINPHONE_CONF_OPTS += --disable-upnp
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 linphone: add libupnp dependency

Hello,

Quoted 10 lines · Fabrice Fontaine

linphone is compatible with libupnp but not with libupnp18 so disable upnp if libupnp is not enabled

Fixes:
- http://autobuild.buildroot.net/results/473c686f9bc5335d25b720cf1b0c45389138a7b4

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/linphone/linphone.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Even though it fixes a build failure that happens only in next, I've pushed this patch to the master branch, because we generally consider adding such optional dependencies patches to be bug fixes.

So: applied to master with a reworked commit log. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 linphone: add libupnp dependency

Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 10 lines · Fabrice Fontaine

linphone is compatible with libupnp but not with libupnp18 so disable upnp if libupnp is not enabled

Fixes:
- http://autobuild.buildroot.net/results/473c686f9bc5335d25b720cf1b0c45389138a7b4

Signed-off-by Fabrice Fontaine <[email protected]>

---
package/linphone/linphone.mk | 7 +++++++

1 file changed, 7 insertions(+)
Quoted 5 lines

Even though it fixes a build failure that happens only in next, I've pushed this patch to the master branch, because we generally consider adding such optional dependencies patches to be bug fixes.

So: applied to master with a reworked commit log. Thanks!

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard