board/qemu/ppc64-pseries: adjust Qemu command line

PATCH New Thomas Petazzoni 2 participants 5 messages Nov 21, 2017 – Nov 27, 2017 PowerPC

Share & tools

Thomas Petazzoni

author

2017-11-21 08:08 UTC #0 lore raw

PATCH 1/2 board/qemu/ppc64-pseries: adjust Qemu command line

This helps the toolchains.free-electrons.com build logic re-use directly the Qemu command lines from this readme.txt file, by having a -append option similar to the ones used in other readme.txt files.

Signed-off-by Thomas Petazzoni <[email protected]>

---
 board/qemu/ppc64-pseries/readme.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

board/qemu/ppc64-pseries/readme.txt +1 -1

index 7cc0c67d61..9de13779d0 100644
@@ -1,6 +1,6 @@
 Run the emulation with:
 
- qemu-system-ppc64 -M pseries -cpu POWER7 -m 256 -kernel output/images/vmlinux -append 'console=hvc0 root=/dev/sda' -drive file=output/images/rootfs.ext2,if=scsi,index=0,format=raw -serial stdio -display curses
+ qemu-system-ppc64 -M pseries -cpu POWER7 -m 256 -kernel output/images/vmlinux -append "console=hvc0 root=/dev/sda" -drive file=output/images/rootfs.ext2,if=scsi,index=0,format=raw -serial stdio -display curses
 
 The login prompt will appear in the terminal that started Qemu.

Signature · 1 line

2.13.6

Thomas Petazzoni

author

2017-11-27 21:38 UTC #1 lore raw

PATCH 1/2 board/qemu/ppc64-pseries: adjust Qemu command line

Hello,

Quoted 8 lines · Thomas Petazzoni

This helps the toolchains.free-electrons.com build logic re-use directly the Qemu command lines from this readme.txt file, by having a -append option similar to the ones used in other readme.txt files.
Signed-off-by Thomas Petazzoni <[email protected]>
---
 board/qemu/ppc64-pseries/readme.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Both applied to master. Thanks Yann for the review :-)

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yann E. MORIN

2017-11-27 20:56 UTC #2 lore raw

PATCH 1/2 board/qemu/ppc64-pseries: adjust Qemu command line

In reply to Thomas Petazzoni

Thomas, All,

On 2017-11-21 09:08 +0100, Thomas Petazzoni spake thusly:

Quoted 5 lines

This helps the toolchains.free-electrons.com build logic re-use directly the Qemu command lines from this readme.txt file, by having a -append option similar to the ones used in other readme.txt files.
Signed-off-by Thomas Petazzoni <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 23 lines

---
 board/qemu/ppc64-pseries/readme.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

board/qemu/ppc64-pseries/readme.txt +1 -1

index 7cc0c67d61..9de13779d0 100644
@@ -1,6 +1,6 @@
 Run the emulation with:
 
- qemu-system-ppc64 -M pseries -cpu POWER7 -m 256 -kernel output/images/vmlinux -append 'console=hvc0 root=/dev/sda' -drive file=output/images/rootfs.ext2,if=scsi,index=0,format=raw -serial stdio -display curses
+ qemu-system-ppc64 -M pseries -cpu POWER7 -m 256 -kernel output/images/vmlinux -append "console=hvc0 root=/dev/sda" -drive file=output/images/rootfs.ext2,if=scsi,index=0,format=raw -serial stdio -display curses
 
 The login prompt will appear in the terminal that started Qemu.

Signature · 6 lines

2.13.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

author

2017-11-21 08:08 UTC #3 lore raw

PATCH 2/2 board/qemu/x86*: use quotes around -append Qemu option value

In reply to Thomas Petazzoni

Signed-off-by Thomas Petazzoni <[email protected]>

---
 board/qemu/x86/readme.txt    | 2 +-
 board/qemu/x86_64/readme.txt | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

board/qemu/x86/readme.txt +1 -1

index 17500961d3..b003ad5373 100644
@@ -1,6 +1,6 @@
 Run the emulation with:
 
-  qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append root=/dev/vda -net nic,model=virtio -net user
+  qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append "root=/dev/vda" -net nic,model=virtio -net user
 
 Optionally add -smp N to emulate a SMP system with N CPUs.

board/qemu/x86_64/readme.txt +1 -1

index ecd7813a1e..ed7b5f5532 100644
@@ -1,6 +1,6 @@
 Run the emulation with:
 
-  qemu-system-x86_64 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append root=/dev/vda -net nic,model=virtio -net user
+  qemu-system-x86_64 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append "root=/dev/vda" -net nic,model=virtio -net user
 
 Optionally add -smp N to emulate a SMP system with N CPUs.

Signature · 1 line

2.13.6

Yann E. MORIN

2017-11-27 20:56 UTC #4 lore raw

PATCH 2/2 board/qemu/x86*: use quotes around -append Qemu option value

Thomas, All,

On 2017-11-21 09:08 +0100, Thomas Petazzoni spake thusly:

Quoted 5 lines

This helps the toolchains.free-electrons.com build logic re-use directly the Qemu command lines from this readme.txt file, by having a -append option similar to the ones used in other readme.txt files.
Signed-off-by Thomas Petazzoni <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 36 lines

---
 board/qemu/x86/readme.txt    | 2 +-
 board/qemu/x86_64/readme.txt | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

board/qemu/x86/readme.txt +1 -1

index 17500961d3..b003ad5373 100644
@@ -1,6 +1,6 @@
 Run the emulation with:
 
-  qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append root=/dev/vda -net nic,model=virtio -net user
+  qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append "root=/dev/vda" -net nic,model=virtio -net user
 
 Optionally add -smp N to emulate a SMP system with N CPUs.

board/qemu/x86_64/readme.txt +1 -1

index ecd7813a1e..ed7b5f5532 100644
@@ -1,6 +1,6 @@
 Run the emulation with:
 
-  qemu-system-x86_64 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append root=/dev/vda -net nic,model=virtio -net user
+  qemu-system-x86_64 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=virtio,format=raw -append "root=/dev/vda" -net nic,model=virtio -net user
 
 Optionally add -smp N to emulate a SMP system with N CPUs.

Signature · 6 lines

2.13.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'