staging: most: Fix build errors
Subsystems (2)
PATCH 1/1 staging: most: Fix build errors
This patch fixes build errors that occur when trying to build the MOST modules. For example, the cdev module build fails with:
make[3]: *** No rule to make target 'drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'. Stop. scripts/Makefile.build:569: recipe for target 'drivers/staging/most/aim-cdev' failed
make[2]: *** [drivers/staging/most/aim-cdev] Error 2scripts/Makefile.build:569: recipe for target 'drivers/staging/most' failed
make[1]: *** [drivers/staging/most] Error 2
Makefile:1502: recipe for target '_module_drivers/staging' failed
make: *** [_module_drivers/staging] Error 2
Update the Makefile variables and paths with the new directory structure to fix these errors.
--- drivers/staging/most/Makefile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/most/Makefile +7 -7
@@ -3,10 +3,10 @@ obj-$(CONFIG_MOST) += most_core.o most_core-y := core.o ccflags-y += -Idrivers/staging/ -obj-$(CONFIG_AIM_CDEV) += aim-cdev/ -obj-$(CONFIG_AIM_NETWORK) += aim-network/ -obj-$(CONFIG_AIM_SOUND) += aim-sound/ -obj-$(CONFIG_AIM_V4L2) += aim-v4l2/ -obj-$(CONFIG_HDM_DIM2) += hdm-dim2/ -obj-$(CONFIG_HDM_I2C) += hdm-i2c/ -obj-$(CONFIG_HDM_USB) += hdm-usb/ +obj-$(CONFIG_MOST_CDEV) += cdev/ +obj-$(CONFIG_MOST_NET) += net/ +obj-$(CONFIG_MOST_SOUND) += sound/ +obj-$(CONFIG_MOST_VIDEO) += video/ +obj-$(CONFIG_MOST_DIM2) += dim2/ +obj-$(CONFIG_MOST_I2C) += i2c/ +obj-$(CONFIG_MOST_USB) += usb/
Signature · 1 line
2.11.0
Greg Kroah-Hartman
maintainerQuoted 10 lines · Chris Coffey
This patch fixes build errors that occur when trying to build the MOST modules. For example, the cdev module build fails with:
make[3]: *** No rule to make target '
drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'. Stop.scripts/Makefile.build:569: recipe for target 'drivers/staging/most/aim-cdev' failed
make[2]: *** [drivers/staging/most/aim-cdev] Error 2scripts/Makefile.build:569: recipe for target 'drivers/staging/most' failed
make[1]: *** [drivers/staging/most] Error 2
Makefile:1502: recipe for target '_module_drivers/staging' failed
make: *** [_module_drivers/staging] Error 2
How are you seeing this error? What is the build command line that you provided to do this? It should just "not build" right now at all.
Quoted 7 lines
Update the
Makefilevariables and paths with the new directory structure to fix these errors.Signed-off-by Chris Coffey <[email protected]>--- drivers/staging/most/Makefile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
I think a patch was sent yesterday to fix these up, did you see it in the archives?
thanks,
greg k-h
Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Chris Coffey
This patch fixes build errors that occur when trying to build the MOST modules. For example, the cdev module build fails with:
make[3]: *** No rule to make target '
drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'. Stop.scripts/Makefile.build:569: recipe for target 'drivers/staging/most/aim-cdev' failed
make[2]: *** [drivers/staging/most/aim-cdev] Error 2scripts/Makefile.build:569: recipe for target 'drivers/staging/most' failed
make[1]: *** [drivers/staging/most] Error 2
Makefile:1502: recipe for target '_module_drivers/staging' failed
make: *** [_module_drivers/staging] Error 2
Quoted 3 lines
How are you seeing this error? What is the build command line that you provided to do this? It should just "not build" right now at all.
I did a git pull to get the latest staging updates, enabled a bunch of staging drivers, and then ran a build on the staging modules with 'make modules M=drivers/staging'. Unfortunately now I'm unable to reproduce the error (of course).
Quoted 10 lines
Quoted 7 lines
Update the
Makefilevariables and paths with the new directory structure to fix these errors.Signed-off-by Chris Coffey <[email protected]>--- drivers/staging/most/Makefile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)I think a patch was sent yesterday to fix these up, did you see it in the archives?
I checked the archives before making the patch, and didn't see anything MOST-related in there for the past few days. The patch below made the build succeed and generate all of the MOST modules.
Quoted 4 lines
thanks,
greg k-h
Greg Kroah-Hartman
maintainerQuoted 13 lines · Chris Coffey
Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Chris Coffey
This patch fixes build errors that occur when trying to build the MOST modules. For example, the cdev module build fails with:
make[3]: *** No rule to make target '
drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'. Stop.scripts/Makefile.build:569: recipe for target 'drivers/staging/most/aim-cdev' failed
make[2]: *** [drivers/staging/most/aim-cdev] Error 2scripts/Makefile.build:569: recipe for target 'drivers/staging/most' failed
make[1]: *** [drivers/staging/most] Error 2
Makefile:1502: recipe for target '_module_drivers/staging' failed
make: *** [_module_drivers/staging] Error 2
Quoted 8 lines
Quoted 3 lines
How are you seeing this error? What is the build command line that you provided to do this? It should just "not build" right now at all.
I did a git pull to get the latest staging updates, enabled a bunch of staging drivers, and then ran a build on the staging modules with 'make modules M=drivers/staging'. Unfortunately now I'm unable to reproduce the error (of course).
If you run 'make' it would have fixed up the dependancies and not caused a build error. That makes sense how you saw it, but it's not there for anyone else so all is fine.
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Update the
Makefilevariables and paths with the new directory structure to fix these errors.Signed-off-by Chris Coffey <[email protected]>--- drivers/staging/most/Makefile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Quoted 6 lines
Quoted 2 lines
I think a patch was sent yesterday to fix these up, did you see it in the archives?
I checked the archives before making the patch, and didn't see anything MOST-related in there for the past few days. The patch below made the build succeed and generate all of the MOST modules.
Subject: [PATCH 1/3] staging: most: fix Makefile
is the patch sent yesterday that should resolve this. I'm going to go apply it right now...
thanks,
greg k-h