Skip to contentSkip to conversation

google-breakpad: take into account host architecture dependencies

PATCH New Thomas Petazzoni 1 participant 2 messages Nov 26, 2017 – Nov 27, 2017

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 google-breakpad: take into account host architecture dependencies

Building the target google-breakpad requires building the host variant of google-breakpad. Just like the target google-breakpad only supports a limited number of architectures, it is the same for the host google-breakpad.

We therefore introduce a BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS option that is used where necessary to prevent the user from choosing Google Breakpad when building on unsupported host platforms.

Fixes:

http://autobuild.buildroot.net/results/c7c04483508f9e4d629efa54571afeb1feaa5f73/
(build on a powerpc64le machine)

Signed-off-by Thomas Petazzoni <[email protected]>
---
 Config.in                              | 1 +
 package/Config.in.host                 | 1 +
 package/google-breakpad/Config.in      | 2 ++
 package/google-breakpad/Config.in.host | 8 ++++++++
 4 files changed, 12 insertions(+)
 create mode 100644 package/google-breakpad/Config.in.host
Config.in +1 -0
index 75e5604831..62d67ce957 100644
@@ -539,6 +539,7 @@ config BR2_GOOGLE_BREAKPAD_ENABLE
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	help
 	  This option will enable the use of google breakpad, a library
 	  and tool suite that allows you to distribute an application to
package/Config.in.host +1 -0
index 59be666143..48b6f8c7a8 100644
@@ -20,6 +20,7 @@ menu "Host utilities"
 	source "package/genpart/Config.in.host"
 	source "package/go/Config.in.host"
 	source "package/go-bootstrap/Config.in.host"
+	source "package/google-breakpad/Config.in.host"
 	source "package/gptfdisk/Config.in.host"
 	source "package/imx-usb-loader/Config.in.host"
 	source "package/jq/Config.in.host"
package/google-breakpad/Config.in +2 -0
index e0e91068be..91ec9ce309 100644
@@ -12,6 +12,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	select BR2_PACKAGE_LINUX_SYSCALL_SUPPORT
 	help
 	  Google-Breakpad is a library and tool suite that allows you

@@ -36,6 +37,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 
 comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
 		!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC) || \
package/google-breakpad/Config.in.host new file +8 -0
new file mode 100644
index 0000000000..28d304766a
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	bool
+	default y if BR2_HOSTARCH = "x86_64"
+	default y if BR2_HOSTARCH = "x86"
+	default y if BR2_HOSTARCH = "arm"
+	default y if BR2_HOSTARCH = "aarch64"
+	default y if BR2_HOSTARCH = "mips"
+	default y if BR2_HOSTARCH = "mipsel"
Signature · 1 line
2.13.6
author Applied
#1 lore raw

PATCH 1/1 google-breakpad: take into account host architecture dependencies

Hello,

Quoted 15 lines · Thomas Petazzoni

Building the target google-breakpad requires building the host variant of google-breakpad. Just like the target google-breakpad only supports a limited number of architectures, it is the same for the host google-breakpad.

We therefore introduce a BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS option that is used where necessary to prevent the user from choosing Google Breakpad when building on unsupported host platforms.

Fixes:

http://autobuild.buildroot.net/results/c7c04483508f9e4d629efa54571afeb1feaa5f73/
(build on a powerpc64le machine)

Quoted 8 lines
Signed-off-by Thomas Petazzoni <[email protected]>
---
 Config.in                              | 1 +
 package/Config.in.host                 | 1 +
 package/google-breakpad/Config.in      | 2 ++
 package/google-breakpad/Config.in.host | 8 ++++++++
 4 files changed, 12 insertions(+)
 create mode 100644 package/google-breakpad/Config.in.host

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com