Skip to contentSkip to conversation

aspeed/flash: fix buffersize of MX6651235F flash chip

PATCH Applied Robert Lippert 2 participants 2 messages Nov 27, 2017 – Feb 13, 2018

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Aspeed machine support
lore
Share & tools
lore

Robert Lippert

author
#0 lore raw

PATCH 1/1 aspeed/flash: fix buffersize of MX6651235F flash chip

The MX66L51235F had a wrong write buffersize of 512 bytes set which causes issues when trying to write an environment block >256 bytes as the SPI chip only "listens" to the last 256 bytes.

Signed-off-by Robert Lippert <[email protected]>
---
 arch/arm/mach-aspeed/flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-aspeed/flash.c +1 -1
index e1e3cf8d7f..907e785d8c 100644
@@ -1009,7 +1009,7 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
 			info->readcmd = 0x0b;
 			info->dualport = 0;
 			info->dummybyte = 1;
-			info->buffersize = 512;
+			info->buffersize = 256;
 			WriteClk = 50;
 			EraseClk = 20;
 			ReadClk  = 50;
Signature · 1 line
2.15.0.417.g466bffb3ac-goog
maintainer Applied
#1 lore raw
Quoted 5 lines · Robert Lippert

The MX66L51235F had a wrong write buffersize of 512 bytes set which causes issues when trying to write an environment block >256 bytes as the SPI chip only "listens" to the last 256 bytes.

Signed-off-by Robert Lippert <[email protected]>

Thanks Rob. Sorry for letting this one hang around for so long.

Merged into v2016.07-aspeed-openbmc.

Cheers,

Joel

Quoted 20 lines
---
 arch/arm/mach-aspeed/flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-aspeed/flash.c +1 -2
index e1e3cf8d7f..907e785d8c 100644
@@ -1009,7 +1009,7 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
                        info->readcmd = 0x0b;
                        info->dualport = 0;
                        info->dummybyte = 1;
-                       info->buffersize = 512;
+                       info->buffersize = 256;
                        WriteClk = 50;
                        EraseClk = 20;
                        ReadClk  = 50;
--

2.15.0.417.g466bffb3ac-goog