Skip to contentSkip to conversation

clk: pr_err() strings should end with newlines

PATCH Applied Arvind Yadav 4 participants 16 messages Nov 24, 2017 – Dec 7, 2017

Subsystems (4)
Common clk Arm STM32 Arm/LPC32XX SoC support Spear platform/clock/pinctrl support
lore
Share & tools
lore

Arvind Yadav

author
#0 lore raw

cover clk: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Arvind Yadav (6):
[PATCH 1/6] clk: stm32f4: pr_err() strings should end with newlines [PATCH 2/6] clk: lpc32xx: pr_err() strings should end with newlines [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines [PATCH 5/6] clk: h8s2678: pr_err() strings should end with newlines [PATCH 6/6] clk: h8300: pr_err() strings should end with newlines

 drivers/clk/clk-stm32f4.c          | 2 +-
 drivers/clk/h8300/clk-div.c        | 4 ++--
 drivers/clk/h8300/clk-h8s2678.c    | 6 +++---
 drivers/clk/nxp/clk-lpc32xx.c      | 4 ++--
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 drivers/clk/spear/clk-gpt-synth.c  | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/6 clk: stm32f4: pr_err() strings should end with newlines

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/clk-stm32f4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-stm32f4.c +1 -1
index 96c6b6b..da44f8d 100644
@@ -1424,7 +1424,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
 
 	base = of_iomap(np, 0);
 	if (!base) {
-		pr_err("%s: unable to map resource", np->name);
+		pr_err("%s: unable to map resource\n", np->name);
 		return;
 	}
Signature · 1 line
1.9.1
Applied
#2 lore raw

Re: [PATCH 1/6] clk: stm32f4: pr_err() strings should end with newlines

Quoted 5 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#3 lore raw

PATCH 2/6 clk: lpc32xx: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/nxp/clk-lpc32xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/nxp/clk-lpc32xx.c +2 -2
index 7b359af..b669a5c 100644
@@ -526,7 +526,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw,
 	    !(pll_is_valid(parent_rate, 1, 1000000, 20000000)
 	      && pll_is_valid(cco_rate, 1, 156000000, 320000000)
 	      && pll_is_valid(ref_rate, 1, 1000000, 27000000)))
-		pr_err("%s: PLL clocks are not in valid ranges: %lu/%lu/%lu",
+		pr_err("%s: PLL clocks are not in valid ranges: %lu/%lu/%lu\n",
 		       clk_hw_get_name(hw),
 		       parent_rate, cco_rate, ref_rate);
 

@@ -1505,7 +1505,7 @@ static void __init lpc32xx_clk_init(struct device_node *np)
 		return;
 	}
 	if (clk_get_rate(clk_32k) != 32768) {
-		pr_err("invalid clock rate of external 32KHz oscillator");
+		pr_err("invalid clock rate of external 32KHz oscillator\n");
 		return;
 	}
Signature · 1 line
1.9.1
Applied
#5 lore raw

Re: [PATCH 2/6] clk: lpc32xx: pr_err() strings should end with newlines

In reply to Arvind Yadav
Quoted 5 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#6 lore raw

PATCH 3/6 clk: SPEAr: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/spear/clk-frac-synth.c +1 -1
index 58d678b..cbdf43a 100644
@@ -131,7 +131,7 @@ struct clk *clk_register_frac(const char *name, const char *parent_name,
 	struct clk *clk;
 
 	if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-		pr_err("Invalid arguments passed");
+		pr_err("Invalid arguments passed\n");
 		return ERR_PTR(-EINVAL);
 	}
Signature · 1 line
1.9.1
Acked-by on v1 3/6
#7 lore raw

Re: [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines

Quoted 13 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/spear/clk-frac-synth.c +0 -0
index 58d678b..cbdf43a 100644

drivers/clk/spear/clk-frac-synth.c struct clk *clk_register_frac(const char *name, const char *parent_name, · line 136

Quoted 7 lines
drivers/clk/spear/clk-frac-synth.c +1 -1
@@ -131,7 +131,7 @@ struct clk *clk_register_frac(const char *name, const char *parent_name,
 	struct clk *clk;
 
 	if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-		pr_err("Invalid arguments passed");
+		pr_err("Invalid arguments passed\n");
 		return ERR_PTR(-EINVAL);
 	}
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh
Applied
#8 lore raw

Re: [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines

In reply to Arvind Yadav
Quoted 5 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#9 lore raw

PATCH 4/6 SPEAr: clk: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/spear/clk-gpt-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/spear/clk-gpt-synth.c +1 -1
index 1a722e9..1cf219a6 100644
@@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned
 	struct clk *clk;
 
 	if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-		pr_err("Invalid arguments passed");
+		pr_err("Invalid arguments passed\n");
 		return ERR_PTR(-EINVAL);
 	}
Signature · 1 line
1.9.1
Acked-by on v1 4/6
#10 lore raw

Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines

Quoted 13 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/spear/clk-gpt-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/spear/clk-gpt-synth.c +0 -0
index 1a722e9..1cf219a6 100644

drivers/clk/spear/clk-gpt-synth.c struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned · line 125

Quoted 7 lines
drivers/clk/spear/clk-gpt-synth.c +1 -1
@@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned
 	struct clk *clk;
 
 	if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-		pr_err("Invalid arguments passed");
+		pr_err("Invalid arguments passed\n");
 		return ERR_PTR(-EINVAL);
 	}
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh
Applied
#11 lore raw

Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines

In reply to Arvind Yadav
Quoted 5 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#12 lore raw

PATCH 5/6 clk: h8s2678: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/h8300/clk-h8s2678.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/clk/h8300/clk-h8s2678.c +3 -3
index fc24b0b..b68045d 100644
@@ -93,7 +93,7 @@ static void __init h8s2678_pll_clk_setup(struct device_node *node)
 
 	num_parents = of_clk_get_parent_count(node);
 	if (!num_parents) {
-		pr_err("%s: no parent found", clk_name);
+		pr_err("%s: no parent found\n", clk_name);
 		return;
 	}
 

@@ -104,13 +104,13 @@ static void __init h8s2678_pll_clk_setup(struct device_node *node)
 
 	pll_clock->sckcr = of_iomap(node, 0);
 	if (pll_clock->sckcr == NULL) {
-		pr_err("%s: failed to map divide register", clk_name);
+		pr_err("%s: failed to map divide register\n", clk_name);
 		goto free_clock;
 	}
 
 	pll_clock->pllcr = of_iomap(node, 1);
 	if (pll_clock->pllcr == NULL) {
-		pr_err("%s: failed to map multiply register", clk_name);
+		pr_err("%s: failed to map multiply register\n", clk_name);
 		goto unmap_sckcr;
 	}
Signature · 1 line
1.9.1
Applied
#13 lore raw

Re: [PATCH 5/6] clk: h8s2678: pr_err() strings should end with newlines

Quoted 5 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#14 lore raw

PATCH 6/6 clk: h8300: pr_err() strings should end with newlines

In reply to Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/clk/h8300/clk-div.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/h8300/clk-div.c +2 -2
index 4ae6244..d413ade 100644
@@ -24,13 +24,13 @@ static void __init h8300_div_clk_setup(struct device_node *node)
 
 	num_parents = of_clk_get_parent_count(node);
 	if (!num_parents) {
-		pr_err("%s: no parent found", clk_name);
+		pr_err("%s: no parent found\n", clk_name);
 		return;
 	}
 
 	divcr = of_iomap(node, 0);
 	if (divcr == NULL) {
-		pr_err("%s: failed to map divide register", clk_name);
+		pr_err("%s: failed to map divide register\n", clk_name);
 		goto error;
 	}
 	offset = (unsigned long)divcr & 3;
Signature · 1 line
1.9.1
Applied
#15 lore raw

Re: [PATCH 6/6] clk: h8300: pr_err() strings should end with newlines

Quoted 5 lines · Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages being concatenated.

Signed-off-by Arvind Yadav <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project