ovl: Pass ovl_get_nlink() parameters in right order

PATCH New Vivek Goyal 1 participant 1 message Nov 28, 2017

Subsystems (2)

Stable branch Overlay filesystem

lore

Share & tools

lore

Vivek Goyal

author

2017-11-28 14:20 UTC #0 lore raw

PATCH v3 1/1 ovl: Pass ovl_get_nlink() parameters in right order

Right now we seem to be passing index as "lowerdentry" and origin.dentry as "upperdentry". IIUC, we should pass these parameters in reversed order and this looks like a bug.

Fixes caf70cb2ba5d ("ovl: cleanup orphan index entries")

Cc <[email protected]> #4.13

Signed-off-by Vivek Goyal <[email protected]>

---
 fs/overlayfs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/overlayfs/namei.c +1 -1

index 625ed8066570..5ef69bc09e0c 100644
@@ -435,7 +435,7 @@ int ovl_verify_index(struct dentry *index, struct ovl_path *lower,
 
 	/* Check if index is orphan and don't warn before cleaning it */
 	if (d_inode(index)->i_nlink == 1 &&
-	    ovl_get_nlink(index, origin.dentry, 0) == 0)
+	    ovl_get_nlink(origin.dentry, index, 0) == 0)
 		err = -ENOENT;
 
 	dput(origin.dentry);