Skip to contentSkip to conversation

recipes-graphics/piglit: Add patch to fix build in some platforms

PATCH Superseded Aníbal Limón 2 participants 3 messages Nov 28, 2017

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Aníbal Limón

author
#0 lore raw

PATCH v2 1/1 recipes-graphics/piglit: Add patch to fix build in some platforms

From: Aníbal Limón <[email protected]>

The entry point is not guaranteed to exist, so use the piglit_egl_get_default_display() helper which does the correct thing.

Signed-off-by Aníbal Limón <[email protected]>
Signed-off-by Daniel Díaz <[email protected]>
---
 ...gl-context-priority.c-Use-piglit_egl_get_.patch | 41 ++++++++++++++++++++++
 meta/recipes-graphics/piglit/piglit_git.bb         |  1 +
 2 files changed, 42 insertions(+)
 create mode 100644 meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch
meta/recipes-graphics/piglit/piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch new file +41 -0
new file mode 100644
index 0000000000..13b997c037
@@ -0,0 +1,41 @@
+From cb562a383229074b44db6998b85572d2abe7c363 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <[email protected]>
+Date: Fri, 24 Nov 2017 10:31:55 -0600
+Subject: [PATCH] tests/egl/egl-context-priority.c: Use
+ piglit_egl_get_default_display
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The entry point is not guaranteed to exist, so use the
+piglit_egl_get_default_display() helper which does the correct thing.
+
+Signed-off-by: Aníbal Limón <[email protected]>
+Signed-off-by: Daniel Díaz <[email protected]>
+Reviewed-by: Tapani Pälli <[email protected]>
+Reviewed-by: Emil Velikov <[email protected]>
+
+Upstream-status: Backport
+
+https://github.com/Igalia/piglit/commit/cb562a3832
+---
+ tests/egl/egl-context-priority.c | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/tests/egl/egl-context-priority.c b/tests/egl/egl-context-priority.c
+index 7f26fc614..9590ccae3 100644
+--- a/tests/egl/egl-context-priority.c
++++ b/tests/egl/egl-context-priority.c
+@@ -99,8 +99,7 @@ piglit_init(int argc, char **argv)
+ 	if (!strstr(exts, "EGL_MESA_platform_surfaceless"))
+ 		piglit_report_result(PIGLIT_SKIP);
+ 
+-	dpy = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA,
+-				    EGL_DEFAULT_DISPLAY, NULL);
++	dpy = piglit_egl_get_default_display(EGL_PLATFORM_SURFACELESS_MESA);
+ 
+ 	ok = eglInitialize(dpy, &major, &minor);
+ 	if (!ok) {
+-- 
+2.11.0
+
meta/recipes-graphics/piglit/piglit_git.bb +1 -0
index d274a8fbd5..45fd534dfa 100644
@@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b2beded7103a3d8a442a2a0391d607b0"
 SRC_URI = "git://anongit.freedesktop.org/piglit \
            file://0001-cmake-install-bash-completions-in-the-right-place.patch \
            file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \
+           file://0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch \
            "
 UPSTREAM_VERSION_UNKNOWN = "1"
Signature · 1 line
2.11.0
author
#1 lore raw
Quoted 35 lines · Aníbal Limón

From: Aníbal Limón <[email protected]>

The entry point is not guaranteed to exist, so use the piglit_egl_get_default_display() helper which does the correct thing.

Signed-off-by Aníbal Limón <[email protected]>
Signed-off-by Daniel Díaz <[email protected]>
---
 ...gl-context-priority.c-Use-piglit_egl_get_.patch | 41
++++++++++++++++++++++
 meta/recipes-graphics/piglit/piglit_git.bb         |  1 +
 2 files changed, 42 insertions(+)
 create mode 100644 meta/recipes-graphics/piglit/

piglit/0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch

(quoted diff) +0 -0

egl-context-priority.c-Use-piglit_egl_get_.patch b/meta/recipes-graphics/ piglit/piglit/0001-tests-egl-egl-context-priority.c-Use- piglit_egl_get_.patch
new file mode 100644
index 0000000000..13b997c037

meta/recipes-graphics/piglit/piglit/0001-tests-egl- new file +0 -0

egl-context-priority.c-Use-piglit_egl_get_.patch

meta/recipes-graphics/piglit/piglit/0001-tests-egl- new file +10 -0
@@ -0,0 +1,41 @@
+From cb562a383229074b44db6998b85572d2abe7c363 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <[email protected]>
+Date: Fri, 24 Nov 2017 10:31:55 -0600
+Subject: [PATCH] tests/egl/egl-context-priority.c: Use
+ piglit_egl_get_default_display
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The entry point is not guaranteed to exist, so use the

meta/recipes-graphics/piglit/piglit/0001-tests-egl- line 20

Quoted 10 lines
meta/recipes-graphics/piglit/piglit/0001-tests-egl- new file +10 -0
+piglit_egl_get_default_display() helper which does the correct thing.
+
+Signed-off-by: Aníbal Limón <[email protected]>
+Signed-off-by: Daniel Díaz <[email protected]>
+Reviewed-by: Tapani Pälli <[email protected]>
+Reviewed-by: Emil Velikov <[email protected]>
+
+Upstream-status: Backport
+
+https://github.com/Igalia/piglit/commit/cb562a3832

Now is a backport, the piglit people pushed to master the patch.

Cheers,
Anibal

Quoted 45 lines
meta/recipes-graphics/piglit/piglit/0001-tests-egl- new file +5 -0
+---
+ tests/egl/egl-context-priority.c | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/tests/egl/egl-context-priority.c b/tests/egl/egl-context-

priority.c

meta/recipes-graphics/piglit/piglit/0001-tests-egl- new file +10 -0
+index 7f26fc614..9590ccae3 100644
+--- a/tests/egl/egl-context-priority.c
++++ b/tests/egl/egl-context-priority.c
+@@ -99,8 +99,7 @@ piglit_init(int argc, char **argv)
+       if (!strstr(exts, "EGL_MESA_platform_surfaceless"))
+               piglit_report_result(PIGLIT_SKIP);
+
+-      dpy = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA,
+-                                  EGL_DEFAULT_DISPLAY, NULL);
++      dpy = piglit_egl_get_default_display(EGL_PLATFORM_

SURFACELESS_MESA);

meta/recipes-graphics/piglit/piglit/0001-tests-egl- new file +6 -0
+
+       ok = eglInitialize(dpy, &major, &minor);
+       if (!ok) {
+--
+2.11.0
+
meta/recipes-graphics/piglit/piglit_git.bb +0 -0
index d274a8fbd5..45fd534dfa 100644
@@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=

b2beded7103a3d8a442a2a0391d607b0"
SRC_URI = "git://anongit.freedesktop.org/piglit \
file://0001-cmake-install-bash-completions-in-the-right-place.patch

\
            file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch
\
+           file://0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch
\
            "

UPSTREAM_VERSION_UNKNOWN = "1"

--
2.11.0

#2 lore raw

✗ patchtest: failure for recipes-graphics/piglit: Add patch to fix build in some platforms

In reply to Aníbal Limón

== Series Details ==

Series: recipes-graphics/piglit: Add patch to fix build in some platforms
Revision: 1
URL : https://patchwork.openembedded.org/series/9982/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Upstream-Status is in incorrect format [test_upstream_status_presence_format]

  Suggested fix    Fix Upstream-Status format in 0001-tests-egl-egl-context-priority.c-Use-piglit_egl_get_.patch
  Current          Upstream-status: Backport
  Standard format  Upstream-Status: <Valid status>
  Valid status     Pending, Accepted, Backport, Denied, Inappropriate [reason], Submitted [where]

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe