Skip to contentSkip to conversation

bcma:Adjust block comments

PATCH In review Ashish Kalra 3 participants 3 messages Nov 28, 2017 – Dec 7, 2017 Broadcom specific amba driver (bcma)

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 bcma:Adjust block comments

use * for block comments in multiple lines according to kernel coding style

Reported by: checkpatch.pl

---
Change log:
-v3: Improvement on commit message as per review from Morgan Freeman <[email protected]>
-v2: Improvement on commit message as per review from Morgan Freeman <[email protected]>(https://lkml.org/lkml/2017/11/27/1259) -v1: https://lkml.org/lkml/2017/11/26/85

 drivers/bcma/driver_pcie2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bcma/driver_pcie2.c +2 -1
index b1a6e327cb23..cf889fc62ac7 100644
@@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2)
 		bcma_core_pcie2_set_ltr_vals(pcie2);
 
 		/* TODO:
-		si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
+		 *si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0);
+		 */
 
 		/* enable the LTR */
 		devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB;
Signature · 1 line
2.14.1
Reviewed-by on v3 1/1
#1 lore raw

Hi Ashish,

Quoted 7 lines · Ashish Kalra

use * for block comments in multiple lines according to kernel coding style

Reported by: checkpatch.pl

---

Looks good now!
FWIW,

Quoted 2 lines

Change log:
-v3: Improvement on commit message as per review from Morgan Freeman <[email protected]>

BTW, this <[email protected]> is my secondary email subscibed to linux-wirless as I don't want my primary email to be flooded with frequent emails, and my upstream mail is [email protected] !

Thanks
Himanshu Jha

#2 lore raw

Re: [v3] bcma: Adjust block comment

In reply to Ashish Kalra
Quoted 7 lines · Ashish Kalra

use * for block comments in multiple lines according to kernel coding style

Reported by: checkpatch.pl

Patch applied to wireless-drivers-next.git, thanks.

a765c8fdc869 bcma: Adjust block comment

Signature · 3 lines
https://patchwork.kernel.org/patch/10080747/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches