Skip to contentSkip to conversation

toolchain/buildroot: add comment for glibc NaN-2008 headers requirement

PATCH New Yann E. MORIN 2 participants 2 messages Nov 25, 2017 – Nov 29, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/buildroot: add comment for glibc NaN-2008 headers requirement

Commit 4a5140ecf (toolchain/buildroot: glibc requires kernel headers >= 4.5 with NaN-2008) added a restriction on kernel hjeaders for glibc when the architecture is using naN-2008.

However, such a restriction is usually associated to a comment explaining the restiction, so the user knows what is happening.

That comment was forgotten in 4a5140ecf. Add it now.

Cc Thomas Petazzoni <[email protected]>
Cc Romain Naour <[email protected]>
---
 toolchain/toolchain-buildroot/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
toolchain/toolchain-buildroot/Config.in +5 -0
index cbe2038a77..c624350cac 100644
@@ -72,6 +72,11 @@ comment "glibc on powerpc64le needs a toolchain w/ headers >= 3.10"
 	depends on BR2_powerpc64le
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
 
+# Support for MIPS NAN2008 needs headers >= 4.5
+comment "glibc on MIPS w/ NAN2008 needs a toolchain w/ headers >= 4.5"
+	depends on BR2_MIPS_NAN_2008
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
+
 config BR2_TOOLCHAIN_BUILDROOT_MUSL
 	bool "musl"
 	depends on BR2_aarch64	  || BR2_arm     || BR2_armeb     || BR2_i386 || \
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 toolchain/buildroot: add comment for glibc NaN-2008 headers requirement

Hello,

Quoted 7 lines · Yann E. MORIN

Commit 4a5140ecf (toolchain/buildroot: glibc requires kernel headers >= 4.5 with NaN-2008) added a restriction on kernel hjeaders for glibc when the architecture is using naN-2008.

However, such a restriction is usually associated to a comment explaining the restiction, so the user knows what is happening.

Quoted 8 lines

That comment was forgotten in 4a5140ecf. Add it now.

Cc Thomas Petazzoni <[email protected]>
Cc Romain Naour <[email protected]>
---
 toolchain/toolchain-buildroot/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com