Skip to contentSkip to conversation

gst1-imx: add missing dependency for imxv4l2videosink plugin

PATCH New Gary Bisson 2 participants 5 messages Nov 30, 2017 Arm i.MX and Layerscape

lore
Share & tools
lore

Gary Bisson

author
#0 lore raw

PATCH 1/1 gst1-imx: add missing dependency for imxv4l2videosink plugin

The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was defined in kernel 4.2, so make sure the toolchain headers match this requirement.

Fixes:
http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/

Signed-off-by Gary Bisson <[email protected]>
---
 package/gstreamer1/gst1-imx/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/gstreamer1/gst1-imx/Config.in +1 -0
index 9b977bdde8..cedd917019 100644
@@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
 config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
 	bool "imxv4l2videosink"
 	select BR2_PACKAGE_GST1_PLUGINS_BAD
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
 	help
 	  Elements for V4L2 output
Signature · 1 line
2.15.0
#1 lore raw

PATCH 1/1 gst1-imx: add missing dependency for imxv4l2videosink plugin

Hello,

Quoted 18 lines · Gary Bisson

The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was defined in kernel 4.2, so make sure the toolchain headers match this requirement.

Fixes:
http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/

Signed-off-by Gary Bisson <[email protected]>
---
 package/gstreamer1/gst1-imx/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/gstreamer1/gst1-imx/Config.in +0 -0
index 9b977bdde8..cedd917019 100644

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC · line 90

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +1 -0
@@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
 config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
 	bool "imxv4l2videosink"
 	select BR2_PACKAGE_GST1_PLUGINS_BAD
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2

Thanks! However you need to add the corresponding Config.in comment.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 gst1-imx: add missing dependency for imxv4l2videosink plugin

Hi Thomas,

Quoted 16 lines · Thomas Petazzoni

Hello,

Quoted 13 lines · Gary Bisson

The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was defined in kernel 4.2, so make sure the toolchain headers match this requirement.

Fixes:
http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/

Signed-off-by Gary Bisson <[email protected]>
---
 package/gstreamer1/gst1-imx/Config.in | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC · line 90

Quoted 9 lines
package/gstreamer1/gst1-imx/Config.in +1 -0
index 9b977bdde8..cedd917019 100644
@@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
 config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
 	bool "imxv4l2videosink"
 	select BR2_PACKAGE_GST1_PLUGINS_BAD
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2

Thanks! However you need to add the corresponding Config.in comment.

Is a simple mention of the macro sufficient?
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT

Or would rather have a full sentence above the 'depends'?

Regards,
Gary

#3 lore raw

PATCH 1/1 gst1-imx: add missing dependency for imxv4l2videosink plugin

Hello,

Quoted 6 lines · Gary Bisson
Quoted 1 line

Thanks! However you need to add the corresponding Config.in comment.

Is a simple mention of the macro sufficient?
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT

Or would rather have a full sentence above the 'depends'?

I'm talking about a Config.in comment, i.e

comment "feature foobaz needs kernel headers >= 4.2"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 gst1-imx: add missing dependency for imxv4l2videosink plugin

Hi Thomas,

Quoted 9 lines · Thomas Petazzoni

Hello,

Quoted 5 lines · Gary Bisson
Quoted 1 line

Thanks! However you need to add the corresponding Config.in comment.

Is a simple mention of the macro sufficient?
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT

Quoted 6 lines
Quoted 1 line

Or would rather have a full sentence above the 'depends'?

I'm talking about a Config.in comment, i.e

comment "feature foobaz needs kernel headers >= 4.2"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2

Right, completely forgot about that. I'll submit a v2 in no time.

Thanks,
Gary