Skip to contentSkip to conversation

target/s390x: nuke DPRINTF in helper.c

PATCH Applied Cornelia Huck 4 participants 5 messages Nov 30, 2017

lore
Share & tools
lore

Cornelia Huck

author
#0 lore raw

PATCH 1/1 target/s390x: nuke DPRINTF in helper.c

It is not used anywhere.

Signed-off-by Cornelia Huck <[email protected]>
---
 target/s390x/helper.c | 18 ------------------
 1 file changed, 18 deletions(-)
target/s390x/helper.c +0 -18
index 246ba20f0d..35d9741918 100644
@@ -31,24 +31,6 @@
 #include "sysemu/sysemu.h"
 #endif
 
-//#define DEBUG_S390
-//#define DEBUG_S390_STDOUT
-
-#ifdef DEBUG_S390
-#ifdef DEBUG_S390_STDOUT
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
-         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
-#endif
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
-
 #ifndef CONFIG_USER_ONLY
 void s390x_tod_timer(void *opaque)
 {
Signature · 1 line
2.13.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Cornelia Huck

It is not used anywhere.

Signed-off-by Cornelia Huck <[email protected]>
---
  target/s390x/helper.c | 18 ------------------
  1 file changed, 18 deletions(-)

Yay! One less spot for bit-rotten debug.

Reviewed-by Eric Blake <[email protected]>
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Reviewed-by on v1 1/1
#2 lore raw
In reply to Cornelia Huck
Quoted 27 lines · Cornelia Huck

It is not used anywhere.

Signed-off-by Cornelia Huck <[email protected]>
---
 target/s390x/helper.c | 18 ------------------
 1 file changed, 18 deletions(-)
target/s390x/helper.c +0 -11
index 246ba20f0d..35d9741918 100644
@@ -31,24 +31,6 @@
 #include "sysemu/sysemu.h"
 #endif
 
-//#define DEBUG_S390
-//#define DEBUG_S390_STDOUT
-
-#ifdef DEBUG_S390
-#ifdef DEBUG_S390_STDOUT
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
-         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)

target/s390x/helper.c line 36

Quoted 10 lines
target/s390x/helper.c +0 -7
-#endif
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
-
 #ifndef CONFIG_USER_ONLY
 void s390x_tod_timer(void *opaque)
 {
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks,

David / dhildenb
Reviewed-by
#3 lore raw
Quoted 2 lines · David Hildenbrand
Quoted 1 line · Cornelia Huck

It is not used anywhere.

Right, looks like I move the last user of this macro away during the --disable-tcg rework.

Reviewed-by Thomas Huth <[email protected]>
author Applied
#4 lore raw
In reply to Cornelia Huck
Quoted 26 lines · On Thu, 30 Nov 2017 15:05:36 +0100 Cornelia Huck <[email protected]> wrote:

It is not used anywhere.

Signed-off-by Cornelia Huck <[email protected]>
---
 target/s390x/helper.c | 18 ------------------
 1 file changed, 18 deletions(-)
target/s390x/helper.c +0 -11
index 246ba20f0d..35d9741918 100644
@@ -31,24 +31,6 @@
 #include "sysemu/sysemu.h"
 #endif
 
-//#define DEBUG_S390
-//#define DEBUG_S390_STDOUT
-
-#ifdef DEBUG_S390
-#ifdef DEBUG_S390_STDOUT
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
-         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)

target/s390x/helper.c line 36

Quoted 10 lines
target/s390x/helper.c +0 -7
-#endif
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
-
 #ifndef CONFIG_USER_ONLY
 void s390x_tod_timer(void *opaque)
 {

Queued to s390-next.