xen: add pvh guest support

In order to support grub2 in Xen PVH environment some additional Xen headers are needed. Add them.

Signed-off-by Juergen Gross <[email protected]>

---
 include/xen/hvm/hvm_op.h     | 296 +++++++++++++++++++
 include/xen/hvm/params.h     | 284 ++++++++++++++++++
 include/xen/hvm/start_info.h |  98 +++++++
 include/xen/memory.h         | 665 +++++++++++++++++++++++++++++++++++++++++++
 include/xen/physdev.h        | 387 +++++++++++++++++++++++++
 include/xen/trace.h          | 339 ++++++++++++++++++++++
 include/xen/xen.h            | 104 +++++--
 7 files changed, 2142 insertions(+), 31 deletions(-)
 create mode 100644 include/xen/hvm/hvm_op.h
 create mode 100644 include/xen/hvm/params.h
 create mode 100644 include/xen/hvm/start_info.h
 create mode 100644 include/xen/memory.h
 create mode 100644 include/xen/physdev.h
 create mode 100644 include/xen/trace.h

Xen PVH guests will have the RSDP at an arbitrary address. Support that by passing the RSDP address via the boot parameters to Linux.

Signed-off-by Juergen Gross <[email protected]>

Xen PVH guests will have the RSDP at an arbitrary address. Support that by passing the RSDP address via the boot parameters to Linux.

Signed-off-by Juergen Gross <[email protected]>

Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too.

Signed-off-by Juergen Gross <[email protected]>

---
 grub-core/kern/xen/init.c | 35 +++++++++++++++++++++--------------
 1 file changed, 21 insertions(+), 14 deletions(-)

grub-core/kern/xen/init.c +19 -14

index 0559c033c..29f5bc23d 100644
@@ -318,6 +318,25 @@ grub_xenstore_dir (const char *dir,
 
 unsigned long gntframe = 0;
 
+static void
+grub_xen_setup_gnttab (void)
+{
+  struct gnttab_set_version gnttab_setver;
+  struct gnttab_setup_table gnttab_setup;
+
+  grub_memset (&gnttab_setver, 0, sizeof (gnttab_setver));
+
+  gnttab_setver.version = 1;
+  grub_xen_grant_table_op (GNTTABOP_set_version, &gnttab_setver, 1);
+
+  grub_memset (&gnttab_setup, 0, sizeof (gnttab_setup));
+  gnttab_setup.dom = DOMID_SELF;
+  gnttab_setup.nr_frames = 1;
+  gnttab_setup.frame_list.p = &gntframe;
+
+  grub_xen_grant_table_op (GNTTABOP_setup_table, &gnttab_setup, 1);
+}
+
 #define MAX_N_UNUSABLE_PAGES 4
 
 static int

@@ -357,26 +376,12 @@ map_all_pages (void)
     (grub_xen_mfn_t *) grub_xen_start_page_addr->mfn_list;
   grub_uint64_t *pg = (grub_uint64_t *) window;
   grub_uint64_t oldpgstart, oldpgend;
-  struct gnttab_setup_table gnttab_setup;
-  struct gnttab_set_version gnttab_setver;
   grub_size_t n_unusable_pages = 0;
   struct mmu_update m2p_updates[2 * MAX_N_UNUSABLE_PAGES];
 
   if (total_pages > MAX_TOTAL_PAGES - 4)
     total_pages = MAX_TOTAL_PAGES - 4;
 
-  grub_memset (&gnttab_setver, 0, sizeof (gnttab_setver));
-
-  gnttab_setver.version = 1;
-  grub_xen_grant_table_op (GNTTABOP_set_version, &gnttab_setver, 1);
-
-  grub_memset (&gnttab_setup, 0, sizeof (gnttab_setup));
-  gnttab_setup.dom = DOMID_SELF;
-  gnttab_setup.nr_frames = 1;
-  gnttab_setup.frame_list.p = &gntframe;
-
-  grub_xen_grant_table_op (GNTTABOP_setup_table, &gnttab_setup, 1);
-
   for (j = 0; j < total_pages - n_unusable_pages; j++)
     while (!grub_xen_is_page_usable (mfn_list[j]))
       {

Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too.

Signed-off-by Juergen Gross <[email protected]>

---
 grub-core/kern/xen/init.c | 35 +++++++++++++++++++++--------------
 1 file changed, 21 insertions(+), 14 deletions(-)

grub-core/kern/xen/init.c +19 -14

index 0559c033c..29f5bc23d 100644
@@ -318,6 +318,25 @@ grub_xenstore_dir (const char *dir,
 
 unsigned long gntframe = 0;
 
+static void
+grub_xen_setup_gnttab (void)
+{
+  struct gnttab_set_version gnttab_setver;
+  struct gnttab_setup_table gnttab_setup;
+
+  grub_memset (&gnttab_setver, 0, sizeof (gnttab_setver));
+
+  gnttab_setver.version = 1;
+  grub_xen_grant_table_op (GNTTABOP_set_version, &gnttab_setver, 1);
+
+  grub_memset (&gnttab_setup, 0, sizeof (gnttab_setup));
+  gnttab_setup.dom = DOMID_SELF;
+  gnttab_setup.nr_frames = 1;
+  gnttab_setup.frame_list.p = &gntframe;
+
+  grub_xen_grant_table_op (GNTTABOP_setup_table, &gnttab_setup, 1);
+}
+
 #define MAX_N_UNUSABLE_PAGES 4
 
 static int

@@ -357,26 +376,12 @@ map_all_pages (void)
     (grub_xen_mfn_t *) grub_xen_start_page_addr->mfn_list;
   grub_uint64_t *pg = (grub_uint64_t *) window;
   grub_uint64_t oldpgstart, oldpgend;
-  struct gnttab_setup_table gnttab_setup;
-  struct gnttab_set_version gnttab_setver;
   grub_size_t n_unusable_pages = 0;
   struct mmu_update m2p_updates[2 * MAX_N_UNUSABLE_PAGES];
 
   if (total_pages > MAX_TOTAL_PAGES - 4)
     total_pages = MAX_TOTAL_PAGES - 4;
 
-  grub_memset (&gnttab_setver, 0, sizeof (gnttab_setver));
-
-  gnttab_setver.version = 1;
-  grub_xen_grant_table_op (GNTTABOP_set_version, &gnttab_setver, 1);
-
-  grub_memset (&gnttab_setup, 0, sizeof (gnttab_setup));
-  gnttab_setup.dom = DOMID_SELF;
-  gnttab_setup.nr_frames = 1;
-  gnttab_setup.frame_list.p = &gntframe;
-
-  grub_xen_grant_table_op (GNTTABOP_setup_table, &gnttab_setup, 1);
-
   for (j = 0; j < total_pages - n_unusable_pages; j++)
     while (!grub_xen_is_page_usable (mfn_list[j]))
       {

Add all the grub-core code needed for Xen PVH guest support. This includes:

- The new PVH entry point of grub
- PVH specific initialization code
- machine specific header files
- modifications in Xen specific code to work in PVH environment
- modifications in other core code to be reusable with PVH

Enabling all this code is done later.

Signed-off-by Juergen Gross <[email protected]>

---
 grub-core/kern/i386/tsc.c             |   2 +-
 grub-core/kern/i386/xen/pvh.c         | 344 ++++++++++++++++++++++++++++++++++
 grub-core/kern/i386/xen/startup_pvh.S |  80 ++++++++
 grub-core/kern/xen/init.c             |  66 ++++---
 include/grub/i386/pc/int.h            |   3 +
 include/grub/i386/tsc.h               |   2 +-
 include/grub/i386/xen/hypercall.h     |   5 +-
 include/grub/i386/xenpvh/boot.h       |   1 +
 include/grub/i386/xenpvh/console.h    |   1 +
 include/grub/i386/xenpvh/int.h        |   1 +
 include/grub/i386/xenpvh/kernel.h     |  30 +++
 include/grub/i386/xenpvh/memory.h     |  54 ++++++
 include/grub/i386/xenpvh/time.h       |   1 +
 include/grub/kernel.h                 |   4 +-
 include/grub/offsets.h                |   3 +
 include/grub/xen.h                    |   6 +
 16 files changed, 573 insertions(+), 30 deletions(-)

 create mode 100644 grub-core/kern/i386/xen/pvh.c
 create mode 100644 grub-core/kern/i386/xen/startup_pvh.S
 create mode 100644 include/grub/i386/xenpvh/boot.h
 create mode 100644 include/grub/i386/xenpvh/console.h
 create mode 100644 include/grub/i386/xenpvh/int.h
 create mode 100644 include/grub/i386/xenpvh/kernel.h
 create mode 100644 include/grub/i386/xenpvh/memory.h
 create mode 100644 include/grub/i386/xenpvh/time.h

Add all the grub-core code needed for Xen PVH guest support. This includes:

- The new PVH entry point of grub
- PVH specific initialization code
- machine specific header files
- modifications in Xen specific code to work in PVH environment
- modifications in other core code to be reusable with PVH

Enabling all this code is done later.

Signed-off-by Juergen Gross <[email protected]>

---
 grub-core/kern/i386/tsc.c             |   2 +-
 grub-core/kern/i386/xen/pvh.c         | 344 ++++++++++++++++++++++++++++++++++
 grub-core/kern/i386/xen/startup_pvh.S |  80 ++++++++
 grub-core/kern/xen/init.c             |  66 ++++---
 include/grub/i386/pc/int.h            |   3 +
 include/grub/i386/tsc.h               |   2 +-
 include/grub/i386/xen/hypercall.h     |   5 +-
 include/grub/i386/xenpvh/boot.h       |   1 +
 include/grub/i386/xenpvh/console.h    |   1 +
 include/grub/i386/xenpvh/int.h        |   1 +
 include/grub/i386/xenpvh/kernel.h     |  30 +++
 include/grub/i386/xenpvh/memory.h     |  54 ++++++
 include/grub/i386/xenpvh/time.h       |   1 +
 include/grub/kernel.h                 |   4 +-
 include/grub/offsets.h                |   3 +
 include/grub/xen.h                    |   6 +
 16 files changed, 573 insertions(+), 30 deletions(-)

 create mode 100644 grub-core/kern/i386/xen/pvh.c
 create mode 100644 grub-core/kern/i386/xen/startup_pvh.S
 create mode 100644 include/grub/i386/xenpvh/boot.h
 create mode 100644 include/grub/i386/xenpvh/console.h
 create mode 100644 include/grub/i386/xenpvh/int.h
 create mode 100644 include/grub/i386/xenpvh/kernel.h
 create mode 100644 include/grub/i386/xenpvh/memory.h
 create mode 100644 include/grub/i386/xenpvh/time.h

Add the modifications to the build system needed to build a xenpvh grub.

Signed-off-by Juergen Gross <[email protected]>

Add the modifications to the build system needed to build a xenpvh grub.

Signed-off-by Juergen Gross <[email protected]>

Suppor mkimage for xenpvh.

Signed-off-by Juergen Gross <[email protected]>

---
 include/grub/util/mkimage.h |  3 ++-
 util/grub-mkimage32.c       |  1 +
 util/grub-mkimage64.c       |  1 +
 util/grub-mkimagexx.c       | 44 ++++++++++++++++++++++++++++++++++++++++----
 util/mkimage.c              | 23 ++++++++++++++++++++++-
 5 files changed, 66 insertions(+), 6 deletions(-)

include/grub/util/mkimage.h +2 -1

index b3a5ca132..3f5bc2e00 100644
@@ -71,7 +71,8 @@ struct grub_install_image_target_desc
     IMAGE_I386_IEEE1275,
     IMAGE_LOONGSON_ELF, IMAGE_QEMU, IMAGE_PPC, IMAGE_YEELOONG_FLASH,
     IMAGE_FULOONG2F_FLASH, IMAGE_I386_PC_PXE, IMAGE_MIPS_ARC,
-    IMAGE_QEMU_MIPS_FLASH, IMAGE_UBOOT, IMAGE_XEN, IMAGE_I386_PC_ELTORITO
+    IMAGE_QEMU_MIPS_FLASH, IMAGE_UBOOT, IMAGE_XEN, IMAGE_I386_PC_ELTORITO,
+    IMAGE_XENPVH
   } id;
   enum
     {

util/grub-mkimage32.c +0 -0

index 9b31397bc..4253c4897 100644

util/grub-mkimage64.c +0 -0

 #include "grub-mkimagexx.c"

util/grub-mkimagexx.c +5 -2

index a2bb05439..a024e57b6 100644
@@ -207,12 +207,12 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
       phnum++;
       footer_size += sizeof (struct grub_ieee1275_note);
     }
-  if (image_target->id == IMAGE_XEN)
+  if (image_target->id == IMAGE_XEN || image_target->id == IMAGE_XENPVH)
     {
       phnum++;
       shnum++;
       string_size += sizeof (".xen");
-      footer_size += XEN_NOTE_SIZE;
+      footer_size += (image_target->id == IMAGE_XEN) ? XEN_NOTE_SIZE : XENPVH_NOTE_SIZE;
     }
   header_size = ALIGN_UP (sizeof (*ehdr) + phnum * sizeof (*phdr)
 			  + shnum * sizeof (*shdr) + string_size, layout->align);

@@ -399,6 +399,39 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
       phdr->p_offset = grub_host_to_target32 (header_size + program_size);
     }
 
+  if (image_target->id == IMAGE_XENPVH)
+    {
+      char *note_start = (elf_img + program_size + header_size);

util/grub-mkimagexx.c +25 -2

+      ptr += sizeof (Elf_Nhdr);
+      memcpy (ptr, GRUB_XEN_NOTE_NAME, sizeof (GRUB_XEN_NOTE_NAME));
+      ptr += ALIGN_UP (sizeof (GRUB_XEN_NOTE_NAME), 4);
+      memset (ptr, 0, image_target->voidp_sizeof);
+      *(grub_uint32_t *) ptr = GRUB_KERNEL_I386_XENPVH_LINK_ADDR;
+      ptr += image_target->voidp_sizeof;
+
+      assert (XENPVH_NOTE_SIZE == (ptr - note_start));
+
+      phdr++;
+      phdr->p_type = grub_host_to_target32 (PT_NOTE);
+      phdr->p_flags = grub_host_to_target32 (PF_R);
+      phdr->p_align = grub_host_to_target32 (image_target->voidp_sizeof);
+      phdr->p_vaddr = 0;
+      phdr->p_paddr = 0;
+      phdr->p_filesz = grub_host_to_target32 (XENPVH_NOTE_SIZE);
+      phdr->p_memsz = 0;
+      phdr->p_offset = grub_host_to_target32 (header_size + program_size);
+    }
+
   if (note)
     {
       int note_size = sizeof (struct grub_ieee1275_note);

@@ -474,7 +507,7 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
     shdr->sh_entsize = grub_host_to_target32 (0);
     shdr++;
 
-    if (image_target->id == IMAGE_XEN)
+    if (image_target->id == IMAGE_XEN || image_target->id == IMAGE_XENPVH)
       {
 	memcpy (ptr, ".xen", sizeof (".xen"));
 	shdr->sh_name = grub_host_to_target32 (ptr - str_start);

@@ -482,7 +515,10 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
 	shdr->sh_type = grub_host_to_target32 (SHT_PROGBITS);
 	shdr->sh_addr = grub_host_to_target_addr (target_addr + layout->kernel_size);
 	shdr->sh_offset = grub_host_to_target_addr (program_size + header_size);
-	shdr->sh_size = grub_host_to_target32 (XEN_NOTE_SIZE);
+	if (image_target->id == IMAGE_XEN)
+	  shdr->sh_size = grub_host_to_target32 (XEN_NOTE_SIZE);
+	else
+	  shdr->sh_size = grub_host_to_target32 (XENPVH_NOTE_SIZE);
 	shdr->sh_link = grub_host_to_target32 (0);
 	shdr->sh_info = grub_host_to_target32 (0);
 	shdr->sh_addralign = grub_host_to_target32 (image_target->voidp_sizeof);

util/mkimage.c +18 -0

index e22d82afa..5e071c074 100644
@@ -133,6 +133,24 @@ static const struct grub_install_image_target_desc image_targets[] =
       .default_compression = GRUB_COMPRESSION_LZMA
     },
     {
+      .dirname = "i386-xenpvh",
+      .names = { "i386-xenpvh", NULL },
+      .voidp_sizeof = 4,
+      .bigendian = 0,
+      .id = IMAGE_XENPVH,
+      .flags = PLATFORM_FLAGS_NONE,
+      .total_module_size = TARGET_NO_FIELD,
+      .decompressor_compressed_size = TARGET_NO_FIELD,
+      .decompressor_uncompressed_size = TARGET_NO_FIELD,
+      .decompressor_uncompressed_addr = TARGET_NO_FIELD,
+      .elf_target = EM_386,
+      .section_align = 1,
+      .vaddr_offset = 0,
+      .link_addr = GRUB_KERNEL_I386_XENPVH_LINK_ADDR,
+      .mod_align = GRUB_KERNEL_I386_XENPVH_MOD_ALIGN,
+      .link_align = 4
+    },
+    {
       .dirname = "i386-pc",
       .names = { "i386-pc-pxe", NULL },
       .voidp_sizeof = 4,

Suppor mkimage for xenpvh.

Signed-off-by Juergen Gross <[email protected]>

---
 include/grub/util/mkimage.h |  3 ++-
 util/grub-mkimage32.c       |  1 +
 util/grub-mkimage64.c       |  1 +
 util/grub-mkimagexx.c       | 44 ++++++++++++++++++++++++++++++++++++++++----
 util/mkimage.c              | 23 ++++++++++++++++++++++-
 5 files changed, 66 insertions(+), 6 deletions(-)

include/grub/util/mkimage.h +2 -1

index b3a5ca132..3f5bc2e00 100644
@@ -71,7 +71,8 @@ struct grub_install_image_target_desc
     IMAGE_I386_IEEE1275,
     IMAGE_LOONGSON_ELF, IMAGE_QEMU, IMAGE_PPC, IMAGE_YEELOONG_FLASH,
     IMAGE_FULOONG2F_FLASH, IMAGE_I386_PC_PXE, IMAGE_MIPS_ARC,
-    IMAGE_QEMU_MIPS_FLASH, IMAGE_UBOOT, IMAGE_XEN, IMAGE_I386_PC_ELTORITO
+    IMAGE_QEMU_MIPS_FLASH, IMAGE_UBOOT, IMAGE_XEN, IMAGE_I386_PC_ELTORITO,
+    IMAGE_XENPVH
   } id;
   enum
     {

util/grub-mkimage32.c +0 -0

index 9b31397bc..4253c4897 100644

util/grub-mkimage64.c +0 -0

 #include "grub-mkimagexx.c"

util/grub-mkimagexx.c +5 -2

index a2bb05439..a024e57b6 100644
@@ -207,12 +207,12 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
       phnum++;
       footer_size += sizeof (struct grub_ieee1275_note);
     }
-  if (image_target->id == IMAGE_XEN)
+  if (image_target->id == IMAGE_XEN || image_target->id == IMAGE_XENPVH)
     {
       phnum++;
       shnum++;
       string_size += sizeof (".xen");
-      footer_size += XEN_NOTE_SIZE;
+      footer_size += (image_target->id == IMAGE_XEN) ? XEN_NOTE_SIZE : XENPVH_NOTE_SIZE;
     }
   header_size = ALIGN_UP (sizeof (*ehdr) + phnum * sizeof (*phdr)
 			  + shnum * sizeof (*shdr) + string_size, layout->align);

@@ -399,6 +399,39 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
       phdr->p_offset = grub_host_to_target32 (header_size + program_size);
     }
 
+  if (image_target->id == IMAGE_XENPVH)
+    {
+      char *note_start = (elf_img + program_size + header_size);

util/grub-mkimagexx.c +25 -2

+      ptr += sizeof (Elf_Nhdr);
+      memcpy (ptr, GRUB_XEN_NOTE_NAME, sizeof (GRUB_XEN_NOTE_NAME));
+      ptr += ALIGN_UP (sizeof (GRUB_XEN_NOTE_NAME), 4);
+      memset (ptr, 0, image_target->voidp_sizeof);
+      *(grub_uint32_t *) ptr = GRUB_KERNEL_I386_XENPVH_LINK_ADDR;
+      ptr += image_target->voidp_sizeof;
+
+      assert (XENPVH_NOTE_SIZE == (ptr - note_start));
+
+      phdr++;
+      phdr->p_type = grub_host_to_target32 (PT_NOTE);
+      phdr->p_flags = grub_host_to_target32 (PF_R);
+      phdr->p_align = grub_host_to_target32 (image_target->voidp_sizeof);
+      phdr->p_vaddr = 0;
+      phdr->p_paddr = 0;
+      phdr->p_filesz = grub_host_to_target32 (XENPVH_NOTE_SIZE);
+      phdr->p_memsz = 0;
+      phdr->p_offset = grub_host_to_target32 (header_size + program_size);
+    }
+
   if (note)
     {
       int note_size = sizeof (struct grub_ieee1275_note);

@@ -474,7 +507,7 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
     shdr->sh_entsize = grub_host_to_target32 (0);
     shdr++;
 
-    if (image_target->id == IMAGE_XEN)
+    if (image_target->id == IMAGE_XEN || image_target->id == IMAGE_XENPVH)
       {
 	memcpy (ptr, ".xen", sizeof (".xen"));
 	shdr->sh_name = grub_host_to_target32 (ptr - str_start);

@@ -482,7 +515,10 @@ SUFFIX (grub_mkimage_generate_elf) (const struct grub_install_image_target_desc
 	shdr->sh_type = grub_host_to_target32 (SHT_PROGBITS);
 	shdr->sh_addr = grub_host_to_target_addr (target_addr + layout->kernel_size);
 	shdr->sh_offset = grub_host_to_target_addr (program_size + header_size);
-	shdr->sh_size = grub_host_to_target32 (XEN_NOTE_SIZE);
+	if (image_target->id == IMAGE_XEN)
+	  shdr->sh_size = grub_host_to_target32 (XEN_NOTE_SIZE);
+	else
+	  shdr->sh_size = grub_host_to_target32 (XENPVH_NOTE_SIZE);
 	shdr->sh_link = grub_host_to_target32 (0);
 	shdr->sh_info = grub_host_to_target32 (0);
 	shdr->sh_addralign = grub_host_to_target32 (image_target->voidp_sizeof);

util/mkimage.c +18 -0

index e22d82afa..5e071c074 100644
@@ -133,6 +133,24 @@ static const struct grub_install_image_target_desc image_targets[] =
       .default_compression = GRUB_COMPRESSION_LZMA
     },
     {
+      .dirname = "i386-xenpvh",
+      .names = { "i386-xenpvh", NULL },
+      .voidp_sizeof = 4,
+      .bigendian = 0,
+      .id = IMAGE_XENPVH,
+      .flags = PLATFORM_FLAGS_NONE,
+      .total_module_size = TARGET_NO_FIELD,
+      .decompressor_compressed_size = TARGET_NO_FIELD,
+      .decompressor_uncompressed_size = TARGET_NO_FIELD,
+      .decompressor_uncompressed_addr = TARGET_NO_FIELD,
+      .elf_target = EM_386,
+      .section_align = 1,
+      .vaddr_offset = 0,
+      .link_addr = GRUB_KERNEL_I386_XENPVH_LINK_ADDR,
+      .mod_align = GRUB_KERNEL_I386_XENPVH_MOD_ALIGN,
+      .link_align = 4
+    },
+    {
       .dirname = "i386-pc",
       .names = { "i386-pc-pxe", NULL },
       .voidp_sizeof = 4,

Add xenpvh support to grub-install.

Signed-off-by Juergen Gross <[email protected]>

Add xenpvh support to grub-install.

Signed-off-by Juergen Gross <[email protected]>

Support platform i386/xenpvh in configure.

Signed-off-by Juergen Gross <[email protected]>

Support platform i386/xenpvh in configure.

Signed-off-by Juergen Gross <[email protected]>

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 10 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Quoted 2 lines

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Quoted 11 lines · Daniel Kiper

Quoted 10 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Quoted 5 lines

Quoted 2 lines

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

The Linux patches are available at:

https://lists.xen.org/archives/html/xen-devel/2017-11/msg01681.html

With the additional Xen patch

https://lists.xen.org/archives/html/xen-devel/2017-11/msg01807.html

the complete setup can be tested.

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Quoted 19 lines · Daniel Kiper

Quoted 18 lines · Juergen Gross

Quoted 16 lines · Daniel Kiper

Quoted 5 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

Quoted 7 lines

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Quoted 3 lines

Quoted 1 line

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 19 lines · Daniel Kiper

Quoted 18 lines · Juergen Gross

Quoted 16 lines · Daniel Kiper

Quoted 5 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

Quoted 7 lines

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Quoted 3 lines

Quoted 1 line

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 24 lines · Daniel Kiper

Quoted 22 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

Quoted 11 lines · Daniel Kiper

Quoted 10 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Quoted 3 lines

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Quoted 24 lines · Daniel Kiper

Quoted 22 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

Quoted 11 lines · Daniel Kiper

Quoted 10 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Quoted 3 lines

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Quoted 29 lines · Juergen Gross

Quoted 27 lines · Daniel Kiper

Quoted 16 lines · Daniel Kiper

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 3 lines

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Perfect! Could you send me their commit ids?

Quoted 29 lines · Juergen Gross

Quoted 27 lines · Daniel Kiper

Quoted 16 lines · Daniel Kiper

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 3 lines

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Perfect! Could you send me their commit ids?

Quoted 30 lines · Daniel Kiper

Quoted 29 lines · Juergen Gross

Quoted 27 lines · Daniel Kiper

Quoted 16 lines · Daniel Kiper

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 5 lines

Quoted 3 lines

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Perfect! Could you send me their commit ids?

Right now they are in the tip tree in the x86/boot branch:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/boot

Commit-Ids are:
2f74cbf947f45fa082dda8eac1a1f1299a372f49
0c89cf36424f7c1177de8a5712514d7cc2eb369f
88750a6c33f813b815516990f01fb5ee488c477e
930ba49b2ce7b09a5eddc21385fd944ba6b4e829

Quoted 39 lines · Juergen Gross

Quoted 30 lines · Daniel Kiper

Quoted 29 lines · Juergen Gross

Quoted 27 lines · Daniel Kiper

Quoted 16 lines · Daniel Kiper

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 5 lines

Quoted 3 lines

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Perfect! Could you send me their commit ids?

Right now they are in the tip tree in the x86/boot branch:

Quoted 7 lines

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/boot

Commit-Ids are:
2f74cbf947f45fa082dda8eac1a1f1299a372f49
0c89cf36424f7c1177de8a5712514d7cc2eb369f
88750a6c33f813b815516990f01fb5ee488c477e
930ba49b2ce7b09a5eddc21385fd944ba6b4e829

My schedule was completely destroyed by many unexpected work and family issues. It looks that I am recovering slowly. I am going to take a look at the patches in a week or two. Should I review these ones or are you going to post something new?

Quoted 39 lines · Juergen Gross

Quoted 30 lines · Daniel Kiper

Quoted 29 lines · Juergen Gross

Quoted 27 lines · Daniel Kiper

Quoted 16 lines · Daniel Kiper

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Daniel Kiper

Quoted 12 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series.

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above?

Please review!

Will do in a week or so.

Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays.

Quoted 5 lines

Quoted 3 lines

Thanks.

BTW: the Linux kernel patches have been accepted by the x86 maintainers.

Perfect! Could you send me their commit ids?

Right now they are in the tip tree in the x86/boot branch:

Quoted 7 lines

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/boot

Commit-Ids are:
2f74cbf947f45fa082dda8eac1a1f1299a372f49
0c89cf36424f7c1177de8a5712514d7cc2eb369f
88750a6c33f813b815516990f01fb5ee488c477e
930ba49b2ce7b09a5eddc21385fd944ba6b4e829

My schedule was completely destroyed by many unexpected work and family issues. It looks that I am recovering slowly. I am going to take a look at the patches in a week or two. Should I review these ones or are you going to post something new?

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Hi Juergen,

Sorry for huge delay. It looks that I am recovering slowly and probably I will have more time for reviews.

Quoted 9 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

AIUI PVH is quite generic idea and can be implemented by different virtualization platforms. IIRC Maran Wilson works on PVH for KVM. So, would not it make more sense to have platform independent GRUB2 PVH code and then on top of that build Xen and KVM support? Could you do that?

Hi Juergen,

Sorry for huge delay. It looks that I am recovering slowly and probably I will have more time for reviews.

Quoted 9 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

AIUI PVH is quite generic idea and can be implemented by different virtualization platforms. IIRC Maran Wilson works on PVH for KVM. So, would not it make more sense to have platform independent GRUB2 PVH code and then on top of that build Xen and KVM support? Could you do that?

Quoted 16 lines · Daniel Kiper

Hi Juergen,

Sorry for huge delay. It looks that I am recovering slowly and probably I will have more time for reviews.

Quoted 9 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Quoted 5 lines

AIUI PVH is quite generic idea and can be implemented by different virtualization platforms. IIRC Maran Wilson works on PVH for KVM. So, would not it make more sense to have platform independent GRUB2 PVH code and then on top of that build Xen and KVM support? Could you do that?

Finally I have some time to work on this series again.

I don't think this makes sense now for the following reasons:

- Maran's series is stalled
- The main work is hypervisor specific and I have no idea right now what would be needed for KVM
- Maran's series was targeted for a quick boot of the kernel right from qemu without any other boot loader

Quoted 16 lines · Daniel Kiper

Hi Juergen,

Sorry for huge delay. It looks that I am recovering slowly and probably I will have more time for reviews.

Quoted 9 lines · Juergen Gross

This patch series adds support for booting Linux as PVH guest.

Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen.

For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB.

Quoted 5 lines

AIUI PVH is quite generic idea and can be implemented by different virtualization platforms. IIRC Maran Wilson works on PVH for KVM. So, would not it make more sense to have platform independent GRUB2 PVH code and then on top of that build Xen and KVM support? Could you do that?

Finally I have some time to work on this series again.

I don't think this makes sense now for the following reasons:

- Maran's series is stalled
- The main work is hypervisor specific and I have no idea right now what would be needed for KVM
- Maran's series was targeted for a quick boot of the kernel right from qemu without any other boot loader