Skip to contentSkip to conversation

clocksource: tcb_clksrc: Fix clock speed message

PATCH Applied Romain Izard 3 participants 4 messages Dec 1, 2017 – Dec 7, 2017 Clocksource, clockevent drivers

lore
Share & tools
lore

Romain Izard

author
#0 lore raw

PATCH v2 1/1 clocksource: tcb_clksrc: Fix clock speed message

The clock speed displayed at boot in an information message was 500 kHz too high compared to its real value. As the value is not used anywhere, there is no functional impact.

Fix the rounding formula to display the correct value.

Signed-off-by Romain Izard <[email protected]>

---
v2: rebase over v4.15-rc1

There is no specified maintainer for this file, only supporters. Nicolas, could you pick this through the at91 tree as the TCB block is an AT91 peripheral ?

 drivers/clocksource/tcb_clksrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/tcb_clksrc.c +1 -1
index 9de47d4d2d9e..43f4d5c4d6fa 100644
@@ -384,7 +384,7 @@ static int __init tcb_clksrc_init(void)
 
 	printk(bootinfo, clksrc.name, CONFIG_ATMEL_TCB_CLKSRC_BLOCK,
 			divided_rate / 1000000,
-			((divided_rate + 500000) % 1000000) / 1000);
+			((divided_rate % 1000000) + 500) / 1000);
 
 	if (tc->tcb_config && tc->tcb_config->counter_width == 32) {
 		/* use apropriate function to read 32 bit counter */
Signature · 1 line
2.14.1
#1 lore raw
Quoted 11 lines · Romain Izard

The clock speed displayed at boot in an information message was 500 kHz too high compared to its real value. As the value is not used anywhere, there is no functional impact.

Fix the rounding formula to display the correct value.

Signed-off-by Romain Izard <[email protected]>

---
v2: rebase over v4.15-rc1

There is no specified maintainer for this file, only supporters.

That is not correct, it defaults to Thomas and me, the maintainers of drivers/clocksource :)

Quoted 2 lines

Nicolas, could you pick this through the at91 tree as the TCB block is an AT91 peripheral ?

Nicolas, do you agree with this change ? If yes, I will take it.

Quoted 16 lines
 drivers/clocksource/tcb_clksrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/tcb_clksrc.c +1 -1
index 9de47d4d2d9e..43f4d5c4d6fa 100644
@@ -384,7 +384,7 @@ static int __init tcb_clksrc_init(void)
 
 	printk(bootinfo, clksrc.name, CONFIG_ATMEL_TCB_CLKSRC_BLOCK,
 			divided_rate / 1000000,
-			((divided_rate + 500000) % 1000000) / 1000);
+			((divided_rate % 1000000) + 500) / 1000);
 	if (tc->tcb_config && tc->tcb_config->counter_width == 32) {
 		/* use apropriate function to read 32 bit counter */
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Acked-by
#2 lore raw
Quoted 13 lines · Daniel Lezcano
Quoted 11 lines · Romain Izard

The clock speed displayed at boot in an information message was 500 kHz too high compared to its real value. As the value is not used anywhere, there is no functional impact.

Fix the rounding formula to display the correct value.

Signed-off-by Romain Izard <[email protected]>

---
v2: rebase over v4.15-rc1

There is no specified maintainer for this file, only supporters.

Quoted 7 lines

That is not correct, it defaults to Thomas and me, the maintainers of drivers/clocksource :)

Quoted 2 lines

Nicolas, could you pick this through the at91 tree as the TCB block is an AT91 peripheral ?

Nicolas, do you agree with this change ? If yes, I will take it.

Yes, fine with me:

Acked-by Nicolas Ferre <[email protected]>

Thanks Daniel for the "heads-up".

Best regards,
Nicolas

Quoted 18 lines
Quoted 16 lines
 drivers/clocksource/tcb_clksrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/tcb_clksrc.c +1 -1
index 9de47d4d2d9e..43f4d5c4d6fa 100644
@@ -384,7 +384,7 @@ static int __init tcb_clksrc_init(void)
 
 	printk(bootinfo, clksrc.name, CONFIG_ATMEL_TCB_CLKSRC_BLOCK,
 			divided_rate / 1000000,
-			((divided_rate + 500000) % 1000000) / 1000);
+			((divided_rate % 1000000) + 500) / 1000);
 	if (tc->tcb_config && tc->tcb_config->counter_width == 32) {
 		/* use apropriate function to read 32 bit counter */
Signature · 1 line
Nicolas Ferre
Applied
#3 lore raw
Quoted 20 lines · Nicolas Ferre
Quoted 19 lines · Daniel Lezcano
Quoted 11 lines · Romain Izard

The clock speed displayed at boot in an information message was 500 kHz too high compared to its real value. As the value is not used anywhere, there is no functional impact.

Fix the rounding formula to display the correct value.

Signed-off-by Romain Izard <[email protected]>

---
v2: rebase over v4.15-rc1

There is no specified maintainer for this file, only supporters.

That is not correct, it defaults to Thomas and me, the maintainers of drivers/clocksource :)

Quoted 2 lines

Nicolas, could you pick this through the at91 tree as the TCB block is an AT91 peripheral ?

Quoted 6 lines
Quoted 1 line

Nicolas, do you agree with this change ? If yes, I will take it.

Yes, fine with me:

Acked-by Nicolas Ferre <[email protected]>

Thanks Daniel for the "heads-up".

Thanks, applied 4.16.

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog