efi_loader helloworld.efi: Fix building with -Os
PATCH 1/1 efi_loader helloworld.efi: Fix building with -Os
Depending on your compiler, when compiling the hello world efi binary with -Os, gcc might think it's a smart idea to replace common patterns such as memory copies with explicit calls to memcpy().
While that sounds great at first, we don't have any memcpy() available in our helloworld build target. So let's indicate to gcc that we really do want to have the code be built as freestanding.
--- lib/efi_loader/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/efi_loader/Makefile +2 -2
@@ -7,8 +7,8 @@ # This file only gets included with CONFIG_EFI_LOADER set, so all # object inclusion implicitly depends on it -CFLAGS_helloworld.o := $(CFLAGS_EFI) -CFLAGS_REMOVE_helloworld.o := $(CFLAGS_NON_EFI) +CFLAGS_helloworld.o := $(CFLAGS_EFI) -Os -ffreestanding +CFLAGS_REMOVE_helloworld.o := $(CFLAGS_NON_EFI) -Os ifneq ($(CONFIG_CMD_BOOTEFI_HELLO_COMPILE),) always += helloworld.efi
Signature · 1 line
2.12.3
Alexander Graf
AppliedQuoted 10 lines
Depending on your compiler, when compiling the hello world efi binary with -Os, gcc might think it's a smart idea to replace common patterns such as memory copies with explicit calls to
memcpy().While that sounds great at first, we don't have any
memcpy()available in our helloworld build target. So let's indicate to gcc that we really do want to have the code be built as freestanding.Fixes bbf75dd9 ("efi_loader: output load options in helloworld")Signed-off-by Alexander Graf <[email protected]>
Thanks, applied to efi-next
Alex