Skip to contentSkip to conversation

webp: add mandatory host-pkgconf dependency

PATCH New Fabrice Fontaine 2 participants 3 messages Dec 2, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webp: add mandatory host-pkgconf dependency

---
 package/webp/webp.mk | 1 +
 1 file changed, 1 insertion(+)
package/webp/webp.mk +1 -0
index e86e798d9..cb2ec5b15 100644
@@ -9,6 +9,7 @@ WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
 WEBP_SITE = http://downloads.webmproject.org/releases/webp
 WEBP_LICENSE = BSD-3-Clause
 WEBP_LICENSE_FILES = COPYING
+WEBP_DEPENDENCIES = host-pkgconf
 WEBP_INSTALL_STAGING = YES
 
 WEBP_CONF_OPTS += \
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 webp: add mandatory host-pkgconf dependency

Hello,

Quoted 1 line · Fabrice Fontaine

Could you give a few more details here? From a quick grep in the webp code, I don't see PKG_CHECK_MODULES() used anywhere, not pkg-config used. I quite probably missed it, but if it's not obvious, a slightly more verbose commit log would be nice.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 webp: add mandatory host-pkgconf dependency

Hello,

2017-12-02 15:24 GMT+01:00 Thomas Petazzoni <
[email protected]>:

Quoted 10 lines

Hello,

Quoted 1 line · Fabrice Fontaine

Could you give a few more details here? From a quick grep in the webp code, I don't see PKG_CHECK_MODULES() used anywhere, not pkg-config used. I quite probably missed it, but if it's not obvious, a slightly more verbose commit log would be nice.

My bad, this is a mistake, I saw that there was a pkgconfigdir option but it is not used to find packages but to install webp files.

Quoted 9 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171202/8af32676/attachment.html>