Skip to contentSkip to conversation

ARM: dts: exynos: Add missing interrupt-controller properties to Exynos5410 PMU

PATCH In review Krzysztof Kozlowski 1 participant 2 messages Nov 29, 2017 – Dec 3, 2017

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: exynos: Add missing interrupt-controller properties to Exynos5410 PMU

PMU (system-controller at 10040000) is used as interrupt-parent for certain nodes thus it should be marked as interrupt-controller to silence warnings when building Exynos5410-based DTBs:

arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property):
Missing interrupt-controller or interrupt-map property in /soc/system-controller at 10040000
arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property):
Missing #interrupt-cells in interrupt-parent /soc/system-controller at 10040000

---
 arch/arm/boot/dts/exynos5410.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/exynos5410.dtsi +3 -0
index 06713ec86f0d..e234219fe8f1 100644
@@ -75,6 +75,9 @@
 			clock-names = "clkout16";
 			clocks = <&fin_pll>;
 			#clock-cells = <1>;
+			interrupt-controller;
+			#interrupt-cells = <3>;
+			interrupt-parent = <&gic>;
 		};
 
 		clock: clock-controller at 10010000 {
Signature · 1 line
2.11.0
author maintainer
#1 lore raw
Quoted 9 lines · Krzysztof Kozlowski

PMU (system-controller at 10040000) is used as interrupt-parent for certain nodes thus it should be marked as interrupt-controller to silence warnings when building Exynos5410-based DTBs:

arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property):
Missing interrupt-controller or interrupt-map property in /soc/system-controller at 10040000
arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property):
Missing #interrupt-cells in interrupt-parent /soc/system-controller at 10040000

Quoted 4 lines
---
 arch/arm/boot/dts/exynos5410.dtsi | 3 +++
 1 file changed, 3 insertions(+)

For the record, applied.

Best regards,
Krzysztof