Skip to contentSkip to conversation

gstreamer1: add config option for building unit test libraries

PATCH New Peter Seiderer 4 participants 6 messages Oct 27, 2017 – Apr 1, 2018

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH v2 1/2 gstreamer1: add config option for building unit test libraries

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- no change

---
 package/gstreamer1/gstreamer1/Config.in     | 6 ++++++
 package/gstreamer1/gstreamer1/gstreamer1.mk | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
package/gstreamer1/gstreamer1/Config.in +6 -0
index 274171b639..c5839f546d 100644
@@ -16,6 +16,12 @@ config BR2_PACKAGE_GSTREAMER1
 
 if BR2_PACKAGE_GSTREAMER1
 
+config BR2_PACKAGE_GSTREAMER1_CHECK
+	bool "enable building unit test libraries"
+	default n
+	help
+	  Enable building unit test libraries for gstreamer.
+
 config BR2_PACKAGE_GSTREAMER1_PARSE
 	bool "enable command-line parser"
 	default y
package/gstreamer1/gstreamer1/gstreamer1.mk +1 -1
index 723e59b208..c2da60182a 100644
@@ -17,7 +17,7 @@ GSTREAMER1_CONF_OPTS = \
 	--disable-failing-tests \
 	--disable-valgrind \
 	--disable-benchmarks \
-	--disable-check \
+	$(if $(BR2_PACKAGE_GSTREAMER1_CHECK),,--disable-check) \
 	$(if $(BR2_PACKAGE_GSTREAMER1_TRACE),,--disable-trace) \
 	$(if $(BR2_PACKAGE_GSTREAMER1_PARSE),,--disable-parse) \
 	$(if $(BR2_PACKAGE_GSTREAMER1_GST_DEBUG),,--disable-gst-debug) \
Signature · 1 line
2.14.2
author
#1 lore raw

PATCH v2 2/2 gst1-interpipe: new package

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- add hash for the license file

---
 package/gstreamer1/Config.in                       |  1 +
 package/gstreamer1/gst1-interpipe/Config.in        | 10 +++++++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.hash  |  5 +++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.mk    | 24 ++++++++++++++++++++++
 4 files changed, 40 insertions(+)
 create mode 100644 package/gstreamer1/gst1-interpipe/Config.in
 create mode 100644 package/gstreamer1/gst1-interpipe/gst1-interpipe.hash
 create mode 100644 package/gstreamer1/gst1-interpipe/gst1-interpipe.mk
package/gstreamer1/Config.in +1 -0
index aef75b55bf..ae7b982bf3 100644
@@ -7,6 +7,7 @@ source "package/gstreamer1/gst1-plugins-good/Config.in"
 source "package/gstreamer1/gst1-plugins-bad/Config.in"
 source "package/gstreamer1/gst1-plugins-ugly/Config.in"
 source "package/gstreamer1/gst1-imx/Config.in"
+source "package/gstreamer1/gst1-interpipe/Config.in"
 source "package/gstreamer1/gst1-libav/Config.in"
 source "package/gstreamer1/gst1-rtsp-server/Config.in"
 source "package/gstreamer1/gst1-validate/Config.in"
package/gstreamer1/gst1-interpipe/Config.in new file +10 -0
new file mode 100644
index 0000000000..0a169e8d4f
@@ -0,0 +1,10 @@
+menuconfig BR2_PACKAGE_GST1_INTERPIPE
+	bool "gst1-interpipe"
+	select BR2_PACKAGE_GSTREAMER1_CHECK
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
+	help
+	  GstInterpipe is a Gstreamer plug-in that allows communication
+	  between two independent pipelines.
+
+	  https://github.com/RidgeRun/gst-interpipe
package/gstreamer1/gst1-interpipe/gst1-interpipe.hash new file +5 -0
new file mode 100644
index 0000000000..b9b1c5e429
@@ -0,0 +1,5 @@
+# locally computed hash
+sha256 3f8cc5cf4861e5836938c66415b47555550c93b06b1bc9faed83e89bacf705cf gst1-interpipe-10dba89eecc200e49f0b432e299f1c8a4312b657.tar.gz
+
+# Hashes for license files:
+sha256 16d7caa6cabbfd0ca47e064a7b48cb446d013e84ca88c854d6470851752136d5 COPYING
package/gstreamer1/gst1-interpipe/gst1-interpipe.mk new file +24 -0
new file mode 100644
index 0000000000..0a06aac41e
@@ -0,0 +1,24 @@
+################################################################################
+#
+# gst1-interpipe
+#
+################################################################################
+
+GST1_INTERPIPE_VERSION = 10dba89eecc200e49f0b432e299f1c8a4312b657
+GST1_INTERPIPE_SITE = https://github.com/RidgeRun/gst-interpipe
+GST1_INTERPIPE_SITE_METHOD = git
+# fetch gst-interpipe/common sub module
+GST1_INTERPIPE_GIT_SUBMODULES = YES
+
+GST1_INTERPIPE_LICENSE = LGPL-2.1
+GST1_INTERPIPE_LICENSE_FILES = COPYING
+
+# from git source
+GST1_INTERPIPE_AUTORECONF = YES
+
+GST1_INTERPIPE_DEPENDENCIES += \
+	host-pkgconf \
+	gstreamer1 \
+	gst1-plugins-base
+
+$(eval $(autotools-package))
Signature · 1 line
2.14.2
#2 lore raw

PATCH v2 2/2 gst1-interpipe: new package

All;

Quoted 86 lines · Peter Seiderer
Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- add hash for the license file

---
 package/gstreamer1/Config.in                       |  1 +
 package/gstreamer1/gst1-interpipe/Config.in        | 10 +++++++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.hash  |  5 +++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.mk    | 24 ++++++++++++++++++++++
 4 files changed, 40 insertions(+)
 create mode 100644 package/gstreamer1/gst1-interpipe/Config.in
 create mode 100644 package/gstreamer1/gst1-interpipe/gst1-interpipe.hash
 create mode 100644 package/gstreamer1/gst1-interpipe/gst1-interpipe.mk
package/gstreamer1/Config.in +1 -0
index aef75b55bf..ae7b982bf3 100644
@@ -7,6 +7,7 @@ source "package/gstreamer1/gst1-plugins-good/Config.in"
 source "package/gstreamer1/gst1-plugins-bad/Config.in"
 source "package/gstreamer1/gst1-plugins-ugly/Config.in"
 source "package/gstreamer1/gst1-imx/Config.in"
+source "package/gstreamer1/gst1-interpipe/Config.in"
 source "package/gstreamer1/gst1-libav/Config.in"
 source "package/gstreamer1/gst1-rtsp-server/Config.in"
 source "package/gstreamer1/gst1-validate/Config.in"
package/gstreamer1/gst1-interpipe/Config.in new file +10 -0
new file mode 100644
index 0000000000..0a169e8d4f
@@ -0,0 +1,10 @@
+menuconfig BR2_PACKAGE_GST1_INTERPIPE
+       bool "gst1-interpipe"
+       select BR2_PACKAGE_GSTREAMER1_CHECK
+       select BR2_PACKAGE_GST1_PLUGINS_BASE
+       select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
+       help
+         GstInterpipe is a Gstreamer plug-in that allows communication
+         between two independent pipelines.
+
+         https://github.com/RidgeRun/gst-interpipe
package/gstreamer1/gst1-interpipe/gst1-interpipe.hash new file +5 -0
new file mode 100644
index 0000000000..b9b1c5e429
@@ -0,0 +1,5 @@
+# locally computed hash
+sha256 3f8cc5cf4861e5836938c66415b47555550c93b06b1bc9faed83e89bacf705cf gst1-interpipe-10dba89eecc200e49f0b432e299f1c8a4312b657.tar.gz
+
+# Hashes for license files:
+sha256 16d7caa6cabbfd0ca47e064a7b48cb446d013e84ca88c854d6470851752136d5 COPYING
package/gstreamer1/gst1-interpipe/gst1-interpipe.mk new file +24 -1
new file mode 100644
index 0000000000..0a06aac41e
@@ -0,0 +1,24 @@
+################################################################################
+#
+# gst1-interpipe
+#
+################################################################################
+
+GST1_INTERPIPE_VERSION = 10dba89eecc200e49f0b432e299f1c8a4312b657
+GST1_INTERPIPE_SITE = https://github.com/RidgeRun/gst-interpipe
+GST1_INTERPIPE_SITE_METHOD = git
+# fetch gst-interpipe/common sub module
+GST1_INTERPIPE_GIT_SUBMODULES = YES
+
+GST1_INTERPIPE_LICENSE = LGPL-2.1
+GST1_INTERPIPE_LICENSE_FILES = COPYING
+
+# from git source
+GST1_INTERPIPE_AUTORECONF = YES
+
+GST1_INTERPIPE_DEPENDENCIES += \
+       host-pkgconf \
+       gstreamer1 \
+       gst1-plugins-base
+
+$(eval $(autotools-package))
--

2.14.2

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Built and works on Fedora 26 64bit.
Tested with uclibc, musl, and glibc.

Also checks out with check-pkg.

#3 lore raw

PATCH v2 2/2 gst1-interpipe: new package

In reply to Peter Seiderer
Quoted 34 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- add hash for the license file

---
 package/gstreamer1/Config.in                       |  1 +
 package/gstreamer1/gst1-interpipe/Config.in        | 10 +++++++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.hash  |  5 +++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.mk    | 24 ++++++++++++++++++++++
 4 files changed, 40 insertions(+)
 create mode 100644 package/gstreamer1/gst1-interpipe/Config.in
 create mode 100644 package/gstreamer1/gst1-interpipe/gst1-interpipe.hash
 create mode 100644 package/gstreamer1/gst1-interpipe/gst1-interpipe.mk
package/gstreamer1/Config.in +1 -0
index aef75b55bf..ae7b982bf3 100644
@@ -7,6 +7,7 @@ source "package/gstreamer1/gst1-plugins-good/Config.in"
 source "package/gstreamer1/gst1-plugins-bad/Config.in"
 source "package/gstreamer1/gst1-plugins-ugly/Config.in"
 source "package/gstreamer1/gst1-imx/Config.in"
+source "package/gstreamer1/gst1-interpipe/Config.in"
 source "package/gstreamer1/gst1-libav/Config.in"
 source "package/gstreamer1/gst1-rtsp-server/Config.in"
 source "package/gstreamer1/gst1-validate/Config.in"
package/gstreamer1/gst1-interpipe/Config.in new file +0 -0
new file mode 100644
index 0000000000..0a169e8d4f

package/gstreamer1/gst1-interpipe/Config.in line 2

Quoted 2 lines
package/gstreamer1/gst1-interpipe/Config.in new file +2 -0
@@ -0,0 +1,10 @@
+menuconfig BR2_PACKAGE_GST1_INTERPIPE
+	bool "gst1-interpipe"

It is a bit strange to use a menuconfig when there aren't any sub options, so I've changed this to a normal config and applied, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH v2 2/2 gst1-interpipe: new package

In reply to Peter Seiderer
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- add hash for the license file

---
 package/gstreamer1/Config.in                       |  1 +
 package/gstreamer1/gst1-interpipe/Config.in        | 10 +++++++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.hash  |  5 +++++
 .../gstreamer1/gst1-interpipe/gst1-interpipe.mk    | 24 ++++++++++++++++++++++

Sorry, I forgot to mention that I also added an entry in DEVELOPERS for this.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH v2 1/2 gstreamer1: add config option for building unit test libraries

In reply to Peter Seiderer

Hello,

Quoted 1 line · Peter Seiderer
Signed-off-by Peter Seiderer <[email protected]>

I've applied, with some small changes. See below.

package/gstreamer1/gstreamer1/Config.in config BR2_PACKAGE_GSTREAMER1 · line 20

Quoted 10 lines
package/gstreamer1/gstreamer1/Config.in +2 -0
index 274171b639..c5839f546d 100644
@@ -16,6 +16,12 @@ config BR2_PACKAGE_GSTREAMER1
 
 if BR2_PACKAGE_GSTREAMER1
 
+config BR2_PACKAGE_GSTREAMER1_CHECK
+	bool "enable building unit test libraries"

"building" is not very useful, and is not used in the other options in that package, so I've removed this word.

package/gstreamer1/gstreamer1/Config.in config BR2_PACKAGE_GSTREAMER1 · line 21

Quoted 1 line
package/gstreamer1/gstreamer1/Config.in +1 -0
+	default n

Being disabled is the default, so "default n" is not needed. I dropped it.

package/gstreamer1/gstreamer1/Config.in config BR2_PACKAGE_GSTREAMER1 · line 24

Quoted 3 lines
package/gstreamer1/gstreamer1/Config.in +1 -0
+	$(if $(BR2_PACKAGE_GSTREAMER1_CHECK),,--disable-check) \
 	$(if $(BR2_PACKAGE_GSTREAMER1_TRACE),,--disable-trace) \
 	$(if $(BR2_PACKAGE_GSTREAMER1_PARSE),,--disable-parse) \

Side note: I'm wondering why we're not explicitly doing --enable-<foo> for all those options. We're doing this for all other packages in Buildroot. But since what you've done is consistent with other options from the gstreamer1 package, I've applied as-is for now. Changing that is topic for a separate patch.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com