asus-wireless: send an EV_SYN/SYN_REPORT between state changes
Subsystems (3)
PATCH 1/1 asus-wireless: send an EV_SYN/SYN_REPORT between state changes
Sending the switch state change twice within the same frame is invalid evdev protocol and only works if the client handles keys immediately as well. Processing events immediately is incorrect, it forces a fake order of events that does not exist on the device.
Recent versions of libinput changed to only process the device state and SYN_REPORT time, so now the key event is lost.
https://bugs.freedesktop.org/show_bug.cgi?id=104041
--- drivers/platform/x86/asus-wireless.c | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/asus-wireless.c +1 -0
@@ -118,6 +118,7 @@ static void asus_wireless_notify(struct acpi_device *adev, u32 event)return ; }input_report_key (data->idev,KEY_RFKILL ,1 ); +input_sync (data->idev);input_report_key (data->idev,KEY_RFKILL ,0 );input_sync (data->idev); }
Signature · 1 line
2.13.6
Quoted 11 lines · Peter Hutterer
Sending the switch state change twice within the same frame is invalid evdev protocol and only works if the client handles keys immediately as well. Processing events immediately is incorrect, it forces a fake order of events that does not exist on the device.
Recent versions of libinput changed to only process the device state and
SYN_REPORTtime, so now the key event is lost.https://bugs.freedesktop.org/show_bug.cgi?id=104041
Signed-off-by Peter Hutterer <[email protected]>
Thanks Peter, queued.
Signature · 2 lines
Darren Hart VMware Open Source Technology Center