Skip to contentSkip to conversation

checks: fix sound-dai phandle with arg property check

PATCH Applied Peter Rosin 3 participants 3 messages Dec 4, 2017 – Dec 5, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checks: fix sound-dai phandle with arg property check

The property is named "sound-dai", not "sound-dais".

Fixes b3bbac02d5e3 ("checks: add phandle with arg property checks")
---
 checks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Hi!

I don't know if this needs more work? Maybe #sound-dai-cells is optional? Maybe there's a lot of fall-out in the kernel? Anyway, "sound-dais" is definitely not right...

BTW, I reviewed the other properties added by the fixed patch and found no other similar spelling mistake.

Cheers,
Peter

checks.c +2 -2
index f5bf5f9..334c2a4 100644
@@ -1066,7 +1066,7 @@ WARNING_PROPERTY_PHANDLE_CELLS(phys, "phys", "#phy-cells");
 WARNING_PROPERTY_PHANDLE_CELLS(power_domains, "power-domains", "#power-domain-cells");
 WARNING_PROPERTY_PHANDLE_CELLS(pwms, "pwms", "#pwm-cells");
 WARNING_PROPERTY_PHANDLE_CELLS(resets, "resets", "#reset-cells");
-WARNING_PROPERTY_PHANDLE_CELLS(sound_dais, "sound-dais", "#sound-dai-cells");
+WARNING_PROPERTY_PHANDLE_CELLS(sound_dai, "sound-dai", "#sound-dai-cells");
 WARNING_PROPERTY_PHANDLE_CELLS(thermal_sensors, "thermal-sensors", "#thermal-sensor-cells");
 
 static bool prop_is_gpio(struct property *prop)
@@ -1269,7 +1269,7 @@ static struct check *check_table[] = {
 	&power_domains_property,
 	&pwms_property,
 	&resets_property,
-	&sound_dais_property,
+	&sound_dai_property,
 	&thermal_sensors_property,
 
 	&deprecated_gpio_property,
Signature · 1 line
2.11.0

A message that is not in the archive (sent off-list or not yet received): 20171204090723.4810-1-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 1 line · Peter Rosin

The property is named "sound-dai", not "sound-dais".

Indeed. Unfortunately, we've been inconsistent.

Quoted 3 lines
Fixes b3bbac02d5e3 ("checks: add phandle with arg property checks")
Quoted 9 lines
---
 checks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Hi!

I don't know if this needs more work? Maybe #sound-dai-cells is optional? Maybe there's a lot of fall-out in the kernel? Anyway, "sound-dais" is definitely not right...

Some of the bindings treated #*-cells as optional with missing being treated as 0. IMO, we should fix all those cases because that's really the only way we can generically validate bindings.

Quoted 2 lines

BTW, I reviewed the other properties added by the fixed patch and found no other similar spelling mistake.

Thanks.

Rob

Applied
#3 lore raw
Quoted 10 lines · Rob Herring
Quoted 1 line · Peter Rosin

The property is named "sound-dai", not "sound-dais".

Indeed. Unfortunately, we've been inconsistent.

Quoted 3 lines
Fixes b3bbac02d5e3 ("checks: add phandle with arg property checks")

Applied, thanks.

Quoted 21 lines
Quoted 10 lines
---
 checks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Hi!

I don't know if this needs more work? Maybe #sound-dai-cells is optional? Maybe there's a lot of fall-out in the kernel? Anyway, "sound-dais" is definitely not right...

Some of the bindings treated #*-cells as optional with missing being treated as 0. IMO, we should fix all those cases because that's really the only way we can generically validate bindings.

Quoted 2 lines

BTW, I reviewed the other properties added by the fixed patch and found no other similar spelling mistake.

Thanks.

Rob

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson