Skip to contentSkip to conversation

ARM: dts: quanta: i2c-2 idle disconnects

PATCH Applied Patrick Venture 2 participants 2 messages Dec 4, 2017 – Dec 5, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: quanta: i2c-2 idle disconnects

From: Peter Hanson <[email protected]>

Two top-level pca954x muxes branch off Quanta q71l i2c-2 bus; they have different addresses, so there is no confusion in that sense. However, by default, the pca954x driver skips disconnecting the selected channel. This supports expected topologies, but will leave two channels selected at the same time when connected in parallel.

This commit adds the i2c-mux-idle-disconnect property to both muxes to inform the driver that disconnecting is not optional on bus 2.

---
 arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts +2 -0
index 7ed3a773b2d5..05cfbf086c84 100644
@@ -227,6 +227,7 @@
 		reg = <0x74>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		i2c-mux-idle-disconnect;  /* may use mux@77 next. */
 	};
 
 	/* 0: PCIe Slot 1,
@@ -243,6 +244,7 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		reg = <0x77>;
+		i2c-mux-idle-disconnect;  /* may use mux@74 next. */
 	};
 };
 
Signature · 1 line
2.15.0.417.g466bffb3ac-goog
maintainer Applied
#1 lore raw
Quoted 8 lines · Patrick Venture

From: Peter Hanson <[email protected]>

Two top-level pca954x muxes branch off Quanta q71l i2c-2 bus; they have different addresses, so there is no confusion in that sense. However, by default, the pca954x driver skips disconnecting the selected channel. This supports expected topologies, but will leave two channels selected at the same time when connected in parallel.

Quoted 5 lines

This commit adds the i2c-mux-idle-disconnect property to both muxes to inform the driver that disconnecting is not optional on bus 2.

Applied to dev-4.10.

Cheers,

Joel

Quoted 27 lines
---
 arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts +2 -1
index 7ed3a773b2d5..05cfbf086c84 100644
@@ -227,6 +227,7 @@
                reg = <0x74>;
                #address-cells = <1>;
                #size-cells = <0>;
+               i2c-mux-idle-disconnect;  /* may use mux@77 next. */
        };
 
        /* 0: PCIe Slot 1,
@@ -243,6 +244,7 @@
                #address-cells = <1>;
                #size-cells = <0>;
                reg = <0x77>;
+               i2c-mux-idle-disconnect;  /* may use mux@74 next. */
        };
 };
 
--

2.15.0.417.g466bffb3ac-goog