Skip to contentSkip to conversation

arm64 :show_regs: show the address before relocation

PATCH In review Peng Fan 4 participants 7 messages Nov 28, 2017 – Feb 6, 2018 Arm (32-bit)

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 arm64 :show_regs: show the address before relocation

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

---
 arch/arm/lib/interrupts_64.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm/lib/interrupts_64.c +8 -2
index 7c9cfce69f..cbcfeec2b0 100644
@@ -9,6 +9,7 @@
 #include <linux/compiler.h>
 #include <efi_loader.h>
 
+DECLARE_GLOBAL_DATA_PTR;
 
 int interrupt_init(void)
 {
@@ -29,8 +30,13 @@ void show_regs(struct pt_regs *regs)
 {
 	int i;
 
-	printf("ELR:     %lx\n", regs->elr);
-	printf("LR:      %lx\n", regs->regs[30]);
+	if (gd->flags & GD_FLG_RELOC) {
+		printf("ELR:     %lx\n", regs->elr - gd->reloc_off);
+		printf("LR:      %lx\n", regs->regs[30] - gd->reloc_off);
+	} else {
+		printf("ELR:     %lx\n", regs->elr);
+		printf("LR:      %lx\n", regs->regs[30]);
+	}
 	for (i = 0; i < 29; i += 2)
 		printf("x%-2d: %016lx x%-2d: %016lx\n",
 		       i, regs->regs[i], i+1, regs->regs[i+1]);
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 arm64 :show_regs: show the address before relocation

Quoted 9 lines · Peng Fan

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

---
 arch/arm/lib/interrupts_64.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
#2 lore raw
In reply to Peng Fan
Quoted 7 lines · Peng Fan

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171204/765b4aa2/attachment.sig>
#3 lore raw

PATCH 1/1 arm64 :show_regs: show the address before relocation

In reply to Peng Fan
Quoted 28 lines · Peng Fan

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

---
 arch/arm/lib/interrupts_64.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm/lib/interrupts_64.c +1 -2
index 7c9cfce69f..cbcfeec2b0 100644
@@ -9,6 +9,7 @@
 #include <linux/compiler.h>
 #include <efi_loader.h>
 
+DECLARE_GLOBAL_DATA_PTR;
 
 int interrupt_init(void)
 {
@@ -29,8 +30,13 @@ void show_regs(struct pt_regs *regs)
 {
 	int i;
 
-	printf("ELR:     %lx\n", regs->elr);
-	printf("LR:      %lx\n", regs->regs[30]);

arch/arm/lib/interrupts_64.c void show_regs(struct pt_regs *regs) · line 42

Quoted 10 lines
arch/arm/lib/interrupts_64.c +7 -0
+	if (gd->flags & GD_FLG_RELOC) {
+		printf("ELR:     %lx\n", regs->elr - gd->reloc_off);
+		printf("LR:      %lx\n", regs->regs[30] - gd->reloc_off);
+	} else {
+		printf("ELR:     %lx\n", regs->elr);
+		printf("LR:      %lx\n", regs->regs[30]);
+	}
 	for (i = 0; i < 29; i += 2)
 		printf("x%-2d: %016lx x%-2d: %016lx\n",
 		       i, regs->regs[i], i+1, regs->regs[i+1]);

Hi,

It is useful to show the relocated address, the kind of local mods I too have had for a while.
But here you dropped the hw register values altogether, instead of displaying both, which I guess I am not the only one to not be happy about.

Regards,
Karl

#4 lore raw

PATCH 1/1 arm64 :show_regs: show the address before relocation

Hi,

Quoted 43 lines · Karl Beldan
Quoted 28 lines · Peng Fan

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

---
 arch/arm/lib/interrupts_64.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm/lib/interrupts_64.c +1 -2
index 7c9cfce69f..cbcfeec2b0 100644
@@ -9,6 +9,7 @@
 #include <linux/compiler.h>
 #include <efi_loader.h>
 
+DECLARE_GLOBAL_DATA_PTR;
 
 int interrupt_init(void)
 {
@@ -29,8 +30,13 @@ void show_regs(struct pt_regs *regs)
 {
      int i;
 
-     printf("ELR:     %lx\n", regs->elr);
-     printf("LR:      %lx\n", regs->regs[30]);

arch/arm/lib/interrupts_64.c void show_regs(struct pt_regs *regs) · line 42

Quoted 10 lines
arch/arm/lib/interrupts_64.c +7 -0
+     if (gd->flags & GD_FLG_RELOC) {
+             printf("ELR:     %lx\n", regs->elr - gd->reloc_off);
+             printf("LR:      %lx\n", regs->regs[30] - gd->reloc_off);
+     } else {
+             printf("ELR:     %lx\n", regs->elr);
+             printf("LR:      %lx\n", regs->regs[30]);
+     }
      for (i = 0; i < 29; i += 2)
              printf("x%-2d: %016lx x%-2d: %016lx\n",
                     i, regs->regs[i], i+1, regs->regs[i+1]);

Hi,

Quoted 5 lines

It is useful to show the relocated address, the kind of local mods I too have had for a while.
But here you dropped the hw register values altogether, instead of displaying both, which I guess I am not the only one to not be happy about.

Yes I agree that we should have both. Do you think you could do a patch?

Regards,
Simon

#5 lore raw

PATCH 1/1 arm64 :show_regs: show the address before relocation

Quoted 46 lines · Simon Glass

Hi,

Quoted 43 lines · Karl Beldan
Quoted 28 lines · Peng Fan

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

---
 arch/arm/lib/interrupts_64.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm/lib/interrupts_64.c +1 -2
index 7c9cfce69f..cbcfeec2b0 100644
@@ -9,6 +9,7 @@
 #include <linux/compiler.h>
 #include <efi_loader.h>
 
+DECLARE_GLOBAL_DATA_PTR;
 
 int interrupt_init(void)
 {
@@ -29,8 +30,13 @@ void show_regs(struct pt_regs *regs)
 {
      int i;
 
-     printf("ELR:     %lx\n", regs->elr);
-     printf("LR:      %lx\n", regs->regs[30]);

arch/arm/lib/interrupts_64.c void show_regs(struct pt_regs *regs) · line 42

Quoted 10 lines
arch/arm/lib/interrupts_64.c +7 -0
+     if (gd->flags & GD_FLG_RELOC) {
+             printf("ELR:     %lx\n", regs->elr - gd->reloc_off);
+             printf("LR:      %lx\n", regs->regs[30] - gd->reloc_off);
+     } else {
+             printf("ELR:     %lx\n", regs->elr);
+             printf("LR:      %lx\n", regs->regs[30]);
+     }
      for (i = 0; i < 29; i += 2)
              printf("x%-2d: %016lx x%-2d: %016lx\n",
                     i, regs->regs[i], i+1, regs->regs[i+1]);

Hi,

Quoted 8 lines
Quoted 5 lines

It is useful to show the relocated address, the kind of local mods I too have had for a while.
But here you dropped the hw register values altogether, instead of displaying both, which I guess I am not the only one to not be happy about.

Yes I agree that we should have both. Do you think you could do a patch?

Hi,

Peng did reply with a patch[1], I was bugged by the formatting but no follow-up ensued, so unclear whether it felt annoying on anybody's side. Anyways sure, if the thread stalls for a few more days, I'll make sure to send a patch.

[1] https://marc.info/?l=u-boot&m=151674072412633&w=2

Regards,
Karl

#6 lore raw

PATCH 1/1 arm64 :show_regs: show the address before relocation

Quoted 55 lines · Karl Beldan
Quoted 46 lines · Simon Glass

Hi,

Quoted 43 lines · Karl Beldan
Quoted 28 lines · Peng Fan

After relocation, when error happends, it is hard to track ELR and LR with asm file objdumped from elf file.

So subtract the gd->reloc_off the reflect the compliation address.

---
 arch/arm/lib/interrupts_64.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm/lib/interrupts_64.c +1 -2
index 7c9cfce69f..cbcfeec2b0 100644
@@ -9,6 +9,7 @@
 #include <linux/compiler.h>
 #include <efi_loader.h>
 
+DECLARE_GLOBAL_DATA_PTR;
 
 int interrupt_init(void)
 {
@@ -29,8 +30,13 @@ void show_regs(struct pt_regs *regs)
 {
      int i;
 
-     printf("ELR:     %lx\n", regs->elr);
-     printf("LR:      %lx\n", regs->regs[30]);

arch/arm/lib/interrupts_64.c void show_regs(struct pt_regs *regs) · line 42

Quoted 10 lines
arch/arm/lib/interrupts_64.c +7 -0
+     if (gd->flags & GD_FLG_RELOC) {
+             printf("ELR:     %lx\n", regs->elr - gd->reloc_off);
+             printf("LR:      %lx\n", regs->regs[30] - gd->reloc_off);
+     } else {
+             printf("ELR:     %lx\n", regs->elr);
+             printf("LR:      %lx\n", regs->regs[30]);
+     }
      for (i = 0; i < 29; i += 2)
              printf("x%-2d: %016lx x%-2d: %016lx\n",
                     i, regs->regs[i], i+1, regs->regs[i+1]);

Hi,

Quoted 7 lines
Quoted 5 lines

It is useful to show the relocated address, the kind of local mods I too have had for a while.
But here you dropped the hw register values altogether, instead of displaying both, which I guess I am not the only one to not be happy about.

Yes I agree that we should have both. Do you think you could do a patch?

Quoted 8 lines

Hi,

Peng did reply with a patch[1], I was bugged by the formatting but no follow-up ensued, so unclear whether it felt annoying on anybody's side. Anyways sure, if the thread stalls for a few more days, I'll make sure to send a patch.

[1] https://marc.info/?l=u-boot&m=151674072412633&w=2

For the record, I took your objects as "Changes still Requested" to the patch and I think/hope in patchwork I marked it as such.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/3346129a/attachment.sig>