Skip to contentSkip to conversation

nvme-pci: remove an unnecessary variable initialization in HMB code

PATCH New Minwoo Im 2 participants 4 messages Dec 3, 2017 – Dec 4, 2017 NVMe

lore
Share & tools
lore

Minwoo Im

author
#0 lore raw

PATCH 1/1 nvme-pci: remove an unnecessary variable initialization in HMB code

The local variable __size__ will be set a bit later in a for-loop. Remove the explicit initialization at the beginning of this function.

Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/pci.c +1 -1
index f5800c3..9f7993b 100644
@@ -1770,7 +1770,7 @@ static int __nvme_alloc_host_mem(struct nvme_dev *dev, u64 preferred,
 	dma_addr_t descs_dma;
 	int i = 0;
 	void **bufs;
-	u64 size = 0, tmp;
+	u64 size, tmp;
 
 	tmp = (preferred + chunk_size - 1);
 	do_div(tmp, chunk_size);
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/1 nvme-pci: remove an unnecessary variable initialization in HMB code

Quoted 22 lines · Minwoo Im

The local variable __size__ will be set a bit later in a for-loop. Remove the explicit initialization at the beginning of this function.

Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/pci.c +1 -2
index f5800c3..9f7993b 100644
@@ -1770,7 +1770,7 @@ static int __nvme_alloc_host_mem(struct nvme_dev *dev, u64 preferred,
        dma_addr_t descs_dma;
        int i = 0;
        void **bufs;
-       u64 size = 0, tmp;
+       u64 size, tmp;
 
        tmp = (preferred + chunk_size - 1);
        do_div(tmp, chunk_size);
--
Quoted 2 lines

2.7.4

Sorry for making confusions. The following patch is good to be reviewed.
+ Added one more removal for an unnecessary variable initialization in nvme_setup_host_mem()

The local variable __size__ and __ret__ will be set a bit later. Remove the explicit initialization at the beginning of those functions.

Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>
---
 drivers/nvme/host/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/host/pci.c +0 -0
index f5800c3..35331fa 100644
@@ -1770,7 +1770,7 @@ static int __nvme_alloc_host_mem(struct nvme_dev

*dev, u64 preferred,

        dma_addr_t descs_dma;
        int i = 0;
        void **bufs;

- u64 size = 0, tmp;
+ u64 size, tmp;

        tmp = (preferred + chunk_size - 1);
        do_div(tmp, chunk_size);
@@ -1853,7 +1853,7 @@ static int nvme_setup_host_mem(struct nvme_dev *dev)
        u64 preferred = (u64)dev->ctrl.hmpre * 4096;
        u64 min = (u64)dev->ctrl.hmmin * 4096;
        u32 enable_bits = NVME_HOST_MEM_ENABLE;

- int ret = 0;
+ int ret;

        preferred = min(preferred, max);
        if (min > max) {
maintainer
#2 lore raw

PATCH 1/1 nvme-pci: remove an unnecessary variable initialization in HMB code

Quoted 7 lines · Minwoo Im

Sorry for making confusions. The following patch is good to be reviewed.
+ Added one more removal for an unnecessary variable initialization in nvme_setup_host_mem()

The local variable __size__ and __ret__ will be set a bit later. Remove the explicit initialization at the beginning of those functions.

This one looks fine, but please resend it in in its own thread in proper formatting.

author
#3 lore raw

PATCH 1/1 nvme-pci: remove an unnecessary variable initialization in HMB code

Quoted 11 lines · Christoph Hellwig
Quoted 7 lines · Minwoo Im

Sorry for making confusions. The following patch is good to be reviewed.
+ Added one more removal for an unnecessary variable initialization in nvme_setup_host_mem()

The local variable __size__ and __ret__ will be set a bit later. Remove the explicit initialization at the beginning of those functions.

This one looks fine, but please resend it in in its own thread in proper formatting.

Hi Christoph,

I'll make a proper one.
Thanks,