drm/i915: follow single notation for workaround number
Subsystems (2)
PATCH v2 1/2 drm/i915: follow single notation for workaround number
v2: Allow to have or omit space before platform
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1380,7 +1380,7 @@ static bool hdmi_12bpc_possible(const struct intel_crtc_state *crtc_state) } } -/* Display Wa #1139 */ +/* Display WA #1139 */ if (IS_GLK_REVID (dev_priv,0 ,GLK_REVID_A1 ) && crtc_state->base.adjusted_mode.htotal >5460 )return false;
drivers/gpu/drm/i915/intel_pm.c +2 -2
@@ -58,7 +58,7 @@ static void gen9_init_clock_gating(struct drm_i915_private *dev_priv)if (HAS_LLC (dev_priv)) {/* * WaCompressedResourceDisplayNewHashMode:skl,kbl -* Display WA#0390: skl,kbl +* Display WA #0390: skl,kbl * * Must match Sampler, Pixel Back End, and Media. See * WaCompressedResourceSamplerPbeMediaNewHashMode.
@@ -8417,7 +8417,7 @@ static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)if (!HAS_PCH_CNP (dev_priv))return ; -/* Wa #1181 */ +/* Display WA #1181 */ I915_WRITE (SOUTH_DSPCLK_GATE_D ,I915_READ (SOUTH_DSPCLK_GATE_D ) |CNP_PWM_CGE_GATING_DISABLE ); }
Signature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/2 drm/i915: add platform tag to WA
v2: add more missing platform tags
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1380,7 +1380,7 @@ static bool hdmi_12bpc_possible(const struct intel_crtc_state *crtc_state) } } -/* Display WA #1139 */ +/* Display WA #1139: glk */ if (IS_GLK_REVID (dev_priv,0 ,GLK_REVID_A1 ) && crtc_state->base.adjusted_mode.htotal >5460 )return false;
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -8417,7 +8417,7 @@ static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)if (!HAS_PCH_CNP (dev_priv))return ; -/* Display WA #1181 */ +/* Display WA #1181: gen9,gen10 */ I915_WRITE (SOUTH_DSPCLK_GATE_D ,I915_READ (SOUTH_DSPCLK_GATE_D ) |CNP_PWM_CGE_GATING_DISABLE ); }
Signature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerRe: [PATCH v2 2/2] drm/i915: add platform tag to WA
Quoted 28 lines · Lucas De Marchi
v2: add more missing platform tags
Cc Ville Syrjälä <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Lucas De Marchi <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_hdmi.c +1
-1@@ -1380,7 +1380,7 @@ static bool hdmi_12bpc_possible(const struct intel_crtc_state *crtc_state) } } -/* Display WA #1139 */ +/* Display WA #1139: glk */ if (IS_GLK_REVID (dev_priv,0 ,GLK_REVID_A1 ) && crtc_state->base.adjusted_mode.htotal >5460 )return false;drivers/gpu/drm/i915/intel_pm.c +0
-0
drivers/gpu/drm/i915/intel_pm.c static void cnp_init_clock_gating(struct drm_i915_private *dev_priv) · line 8420
Quoted 5 lines
drivers/gpu/drm/i915/intel_pm.c +1
-1@@ -8417,7 +8417,7 @@ static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)if (!HAS_PCH_CNP (dev_priv))return ; -/* Display WA #1181 */ +/* Display WA #1181: gen9,gen10 */
This one here should be "cnp" instead of gen actually. That covers both gen9 and gen10 on this path because it actually depends on pch and not on gen itself.
But I just saw on spec it mentions "skl" what is strange since this bit was introduced with CNP PCH...
If you resend as cnp feel free to add my rv-b ;)
Thanks,
Rodrigo.
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +0
-0I915_WRITE (SOUTH_DSPCLK_GATE_D ,I915_READ (SOUTH_DSPCLK_GATE_D ) |CNP_PWM_CGE_GATING_DISABLE ); }Signature · 1 line
2.14.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: follow single notation for workaround number
In reply to Lucas De Marchi== Series Details ==
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: follow single notation for workaround number
URL : https://patchwork.freedesktop.org/series/34869/
State : success
== Summary ==
Series 34869v1 series starting with [v2,1/2] drm/i915: follow single notation for workaround number
https://patchwork.freedesktop.org/api/1.0/series/34869/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:437s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:441s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:386s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:526s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:283s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:507s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:517s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:493s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:477s fi-elk-e7500 total:224 pass:163 dwarn:15 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:178 dwarn:1 dfail:0 fail:1 skip:108 time:288s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:543s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:373s fi-hsw-4770r total:288 pass:224 dwarn:0 dfail:0 fail:0 skip:64 time:261s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:395s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:476s fi-ivb-3770 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:457s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:492s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:532s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:484s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:535s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:455s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:544s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:566s fi-skl-6700k total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:519s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:503s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:453s fi-snb-2520m total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:553s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:421s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:610s fi-cnl-y total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:615s fi-glk-dsi total:288 pass:257 dwarn:1 dfail:0 fail:0 skip:30 time:478s
cee3f135bf4e95188222d7a5ffaeb1e4f0185fc9 drm-tip: 2017y-12m-04d-21h-06m-29s UTC integration manifest 6612bb11742a drm/i915: add platform tag to WA05d7792236ca drm/i915: follow single notation for workaround number
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7401/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for series starting with [v2,1/2] drm/i915: follow single notation for workaround number
In reply to Lucas De Marchi== Series Details ==
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: follow single notation for workaround number
URL : https://patchwork.freedesktop.org/series/34869/
State : warning
== Summary ==
Test kms_cursor_crc:
Subgroup cursor-64x21-sliding:
pass -> SKIP (shard-hsw)
Test kms_plane:
Subgroup plane-panning-bottom-right-pipe-b-planes:
pass -> SKIP (shard-hsw)
Test gem_tiled_swapping:
Subgroup non-threaded:
pass -> INCOMPLETE (shard-snb) fdo#104009
Test gem_softpin:
Subgroup noreloc-s4:
fail -> SKIP (shard-snb) fdo#103375
Test kms_flip:
Subgroup modeset-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#103060fdo#104009 https://bugs.freedesktop.org/show_bug.cgi?id=104009
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
shard-hsw total:2679 pass:1534 dwarn:1 dfail:0 fail:10 skip:1134 time:9379s shard-snb total:2663 pass:1297 dwarn:1 dfail:0 fail:11 skip:1353 time:7912s Blacklisted hosts: shard-apl total:2679 pass:1677 dwarn:1 dfail:0 fail:22 skip:978 time:13600s shard-kbl total:2663 pass:1783 dwarn:1 dfail:0 fail:24 skip:854 time:10615s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7401/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Lucas De Marchi
v2: Allow to have or omit space before platform
Cc Ville Syrjälä <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Lucas De Marchi <[email protected]>
Quoted 43 lines
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_hdmi.c +1
-1@@ -1380,7 +1380,7 @@ static bool hdmi_12bpc_possible(const struct intel_crtc_state *crtc_state) } } -/* Display Wa #1139 */ +/* Display WA #1139 */ if (IS_GLK_REVID (dev_priv,0 ,GLK_REVID_A1 ) && crtc_state->base.adjusted_mode.htotal >5460 )return false;drivers/gpu/drm/i915/intel_pm.c +2
-2@@ -58,7 +58,7 @@ static void gen9_init_clock_gating(struct drm_i915_private *dev_priv)if (HAS_LLC (dev_priv)) {/* * WaCompressedResourceDisplayNewHashMode:skl,kbl -* Display WA#0390: skl,kbl +* Display WA #0390: skl,kbl * * Must match Sampler, Pixel Back End, and Media. See * WaCompressedResourceSamplerPbeMediaNewHashMode. @@ -8417,7 +8417,7 @@ static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)if (!HAS_PCH_CNP (dev_priv))return ; -/* Wa #1181 */ +/* Display WA #1181 */ I915_WRITE (SOUTH_DSPCLK_GATE_D ,I915_READ (SOUTH_DSPCLK_GATE_D ) |CNP_PWM_CGE_GATING_DISABLE ); }Signature · 1 line
2.14.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx