Skip to contentSkip to conversation

mbedtls: fix typ0 in comment

PATCH In review Antonio Quartulli 4 participants 4 messages Dec 5, 2017 – Dec 8, 2017

lore
Share & tools
lore

Antonio Quartulli

author
#0 lore raw

PATCH 1/1 mbedtls: fix typ0 in comment

From: Antonio Quartulli <[email protected]...>

the function used to set the verify callback in mbedTLS is actually called mbedtls_ssl_conf_verify() and it is invoked in key_state_ssl_init().

Fix comment accordingly.

Signed-off-by Antonio Quartulli <[email protected]...>
---
 src/openvpn/ssl_verify_mbedtls.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
src/openvpn/ssl_verify_mbedtls.h +3 -3
index 8b0a5ae9..2fba362f 100644
@@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t;
  * This callback function is called when a new TLS session is being setup to
  * determine whether the remote OpenVPN peer's certificate is allowed to
  * connect. It is called for once for every certificate in the chain. The
- * callback functionality is configured in the \c init_ssl() function, which
- * calls the mbed TLS library's \c ssl_set_verify_callback() function with \c
- * verify_callback() as its callback argument.
+ * callback functionality is configured in the \c key_state_ssl_init() function,
+ * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify() function with
+ * \c verify_callback() as its callback argument.
  *
  * It checks *flags and registers the certificate hash. If these steps succeed,
  * it calls the \c verify_cert() function, which performs OpenVPN-specific
Signature · 1 line
2.15.1
Acked-by on v1 1/1
#1 lore raw
Quoted 21 lines · Antonio Quartulli

From: Antonio Quartulli <[email protected]...>

the function used to set the verify callback in mbedTLS is actually called mbedtls_ssl_conf_verify() and it is invoked in key_state_ssl_init().

Fix comment accordingly.

Signed-off-by Antonio Quartulli <[email protected]...>
---
 src/openvpn/ssl_verify_mbedtls.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
src/openvpn/ssl_verify_mbedtls.h +0 -0
index 8b0a5ae9..2fba362f 100644
@@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t;
  * This callback function is called when a new TLS session is being setup to
  * determine whether the remote OpenVPN peer's certificate is allowed to

src/openvpn/ssl_verify_mbedtls.h typedef mbedtls_x509_crt openvpn_x509_cert_t; · line 56

Quoted 10 lines
src/openvpn/ssl_verify_mbedtls.h +3 -3
  * connect. It is called for once for every certificate in the chain. The
- * callback functionality is configured in the \c init_ssl() function, which
- * calls the mbed TLS library's \c ssl_set_verify_callback() function with \c
- * verify_callback() as its callback argument.
+ * callback functionality is configured in the \c key_state_ssl_init() function,
+ * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify() function with
+ * \c verify_callback() as its callback argument.
  *
  * It checks *flags and registers the certificate hash. If these steps succeed,
  * it calls the \c verify_cert() function, which performs OpenVPN-specific
Acked-by Steffan Karger <[email protected]...>

-Steffan

#2 lore raw
In reply to Antonio Quartulli

How the fuck unsubscribe this, its very annoynng

Quoted 50 lines · Antonio Quartulli

From: Antonio Quartulli <[email protected]...>

the function used to set the verify callback in mbedTLS is actually called mbedtls_ssl_conf_verify() and it is invoked in key_state_ssl_init().

Fix comment accordingly.

Signed-off-by Antonio Quartulli <[email protected]...>
---
 src/openvpn/ssl_verify_mbedtls.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
src/openvpn/ssl_verify_ renamed from src/openvpn/ssl_verify_mbedtls.h +0 -0

mbedtls.h
index 8b0a5ae9..2fba362f 100644

src/openvpn/ssl_verify_mbedtls.h +0 -0
@@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t;
  * This callback function is called when a new TLS session is being setup

to
* determine whether the remote OpenVPN peer's certificate is allowed to
* connect. It is called for once for every certificate in the chain. The
- * callback functionality is configured in the \c init_ssl() function, which
- * calls the mbed TLS library's \c ssl_set_verify_callback() function with \c
- * verify_callback() as its callback argument.
+ * callback functionality is configured in the \c key_state_ssl_init() function,
+ * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify() function with
+ * \c verify_callback() as its callback argument.
*
* It checks *flags and registers the certificate hash. If these steps
succeed,
* it calls the \c verify_cert() function, which performs OpenVPN-specific
--
2.15.1

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#3 lore raw
In reply to Antonio Quartulli

Thanks.

Your patch has been applied to the master and release/2.4 branch.

commit c68a025a1ca687c19d7ae8599464f768b7525df5 (master) commit 9df9faeb9fec197f27dd2e51580992b55c085dc5 (release/2.4)

Author: Antonio Quartulli
Date:   Tue Dec 5 16:57:11 2017 +0800
     mbedtls: fix typ0 in comment

     Signed-off-by: Antonio Quartulli <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg16026.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering