Skip to contentSkip to conversation

omxplayer: add missing dependency on alsa-lib

PATCH New Julius Kriukas 2 participants 2 messages Dec 4, 2017 – Dec 5, 2017

lore
Share & tools
lore

Julius Kriukas

author
#0 lore raw

PATCH 1/1 omxplayer: add missing dependency on alsa-lib

Omxplayer depends on alsa-lib. This patch fixes:

http://autobuild.buildroot.net/results/652/65212c59a37398681b341263bd76ba8a65ff7828

Signed-off-by Julius Kriukas <[email protected]>
---
 package/omxplayer/Config.in    | 1 +
 package/omxplayer/omxplayer.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/omxplayer/Config.in +1 -0
index b417aa3b0b..67367cf123 100644
@@ -7,6 +7,7 @@ config BR2_PACKAGE_OMXPLAYER
 	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libusb
 	depends on BR2_USE_WCHAR # boost
 	depends on BR2_PACKAGE_RPI_USERLAND
+	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_FFMPEG
package/omxplayer/omxplayer.mk +1 -1
index 6e92250438..6999269161 100644
@@ -10,7 +10,7 @@ OMXPLAYER_LICENSE = GPL-2.0+
 OMXPLAYER_LICENSE_FILES = COPYING
 
 OMXPLAYER_DEPENDENCIES = \
-	host-pkgconf boost dbus ffmpeg freetype libidn libusb pcre \
+	host-pkgconf alsa-lib boost dbus ffmpeg freetype libidn libusb pcre \
 	rpi-userland zlib
 
 OMXPLAYER_EXTRA_CFLAGS = \
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 omxplayer: add missing dependency on alsa-lib

On 2017-12-05 01:30 +0200, Julius Kriukas spake thusly:

Quoted 5 lines

Omxplayer depends on alsa-lib. This patch fixes:

http://autobuild.buildroot.net/results/652/65212c59a37398681b341263bd76ba8a65ff7828

Signed-off-by Julius Kriukas <[email protected]>

We sent about the same patch at about the same time, so I would not care which is applied.

Yet, as you may have noticed, my patch also fixes the comment-dependency on threads, so I believe mine is a little bit better in that respect.

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 33 lines
---
 package/omxplayer/Config.in    | 1 +
 package/omxplayer/omxplayer.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/omxplayer/Config.in +1 -0
index b417aa3b0b..67367cf123 100644
@@ -7,6 +7,7 @@ config BR2_PACKAGE_OMXPLAYER
 	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libusb
 	depends on BR2_USE_WCHAR # boost
 	depends on BR2_PACKAGE_RPI_USERLAND
+	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_FFMPEG
package/omxplayer/omxplayer.mk +1 -1
index 6e92250438..6999269161 100644
@@ -10,7 +10,7 @@ OMXPLAYER_LICENSE = GPL-2.0+
 OMXPLAYER_LICENSE_FILES = COPYING
 
 OMXPLAYER_DEPENDENCIES = \
-	host-pkgconf boost dbus ffmpeg freetype libidn libusb pcre \
+	host-pkgconf alsa-lib boost dbus ffmpeg freetype libidn libusb pcre \
 	rpi-userland zlib
 
 OMXPLAYER_EXTRA_CFLAGS = \
Signature · 1 line
2.11.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'