Skip to contentSkip to conversation

IB/ocrdma: Remove unneeded conversions to bool

PATCH Applied Andrew F. Davis 3 participants 3 messages Dec 5, 2017 – Dec 13, 2017 1 message not in the archive

Subsystems (2)
InfiniBand Emulex oneconnect RoCE driver
lore
Share & tools
lore

Andrew F. Davis

author
#0 lore raw

PATCH 1/1 IB/ocrdma: Remove unneeded conversions to bool

Found with scripts/coccinelle/misc/boolconv.cocci.

Signed-off-by Andrew F. Davis <[email protected]>
---
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +1 -1
index 7866fd8051f6..b5f1dd33b73e 100644
@@ -461,7 +461,7 @@ static struct ocrdma_pd *_ocrdma_alloc_pd(struct ocrdma_dev *dev,
 static inline int is_ucontext_pd(struct ocrdma_ucontext *uctx,
 				 struct ocrdma_pd *pd)
 {
-	return (uctx->cntxt_pd == pd ? true : false);
+	return (uctx->cntxt_pd == pd);
 }
 
 static int _ocrdma_dealloc_pd(struct ocrdma_dev *dev,
Signature · 6 lines
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

looks good, Acked-By: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/[email protected]>

Quoted 21 lines · Andrew F. Davis

Found with scripts/coccinelle/misc/boolconv.cocci.

Signed-off-by Andrew F. Davis <[email protected]>
---
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +1 -2
index 7866fd8051f6..b5f1dd33b73e 100644
@@ -461,7 +461,7 @@ static struct ocrdma_pd *_ocrdma_alloc_pd(struct ocrdma_dev *dev,
 static inline int is_ucontext_pd(struct ocrdma_ucontext *uctx,
                                 struct ocrdma_pd *pd)
 {
-       return (uctx->cntxt_pd == pd ? true : false);
+       return (uctx->cntxt_pd == pd);
 }
 
 static int _ocrdma_dealloc_pd(struct ocrdma_dev *dev,
--
Quoted 2 lines

2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#3 lore raw
In reply to a message not in the archive
Quoted 5 lines · Andrew F. Davis

Found with scripts/coccinelle/misc/boolconv.cocci.

Signed-off-by Andrew F. Davis <[email protected]>
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to -next

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html