ARM: dts: aspeed: quanta-q71l: move coin battery sensor
Subsystems (2)
PATCH 1/1 ARM: dts: aspeed: quanta-q71l: move coin battery sensor
Moved the coin battery sensor into a separate iio-hwmon instance to facilitate reading it as a separate hwmon instance.
--- arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts +6 -1
@@ -117,7 +117,12 @@ compatible = "iio-hwmon"; io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>, - <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>; + <&adc 8>, <&adc 9>, <&adc 10>; + }; + + iio-hwmon-battery { + compatible = "iio-hwmon"; + io-channels = <&adc 11>; }; };
Signature · 1 line
2.15.0.531.g2ccb3012c9-goog
Quoted 2 lines · Patrick Venture
Moved the coin battery sensor into a separate iio-hwmon instance to facilitate reading it as a separate hwmon instance.
Have you considered adding some some #defines for the ADC channel numbers, to document what they do? It doesn't appear to be a common thing in other dts files, but it makes sense to me.
I've applied this to dev-4.10.
Cheers,
Joel
That's not a bad suggestion -- I could at least add comments listing what they are. Another CL to follow.
Quoted 13 lines · Joel Stanley
Quoted 2 lines · Patrick Venture
Moved the coin battery sensor into a separate iio-hwmon instance to facilitate reading it as a separate hwmon instance.
Have you considered adding some some #defines for the ADC channel numbers, to document what they do? It doesn't appear to be a common thing in other dts files, but it makes sense to me.
I've applied this to dev-4.10.
Cheers,
Joel