Skip to contentSkip to conversation

vsprintf: add printk specifier %px

PATCH Alexey Dobriyan 3 participants 3 messages Dec 6, 2017 – Dec 16, 2017

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

more %p grepping [filtering out all `%ps %pf %pb' variants] gives a huge number of print outs that potentially can be broken now

Because people who introduce this stupid %p hashing can't be bothered to actually audit users:

	static int show_timer(struct seq_file *m, void *v)
	{
		...
	        seq_printf(m, "signal: %d/%p\n",
                   timer->sigq->info.si_signo,
                   timer->sigq->info.si_value.sival_ptr);

Overall, this %px thing doesn't matter. Developers will quickly learn than %p gives some useless irreversible values and start using %px everywhere. Soon someone will use %px in the wrong place and new non-standard format specifier will be added.

#1 lore raw
Quoted 2 lines · Alexey Dobriyan

Because people who introduce this stupid %p hashing can't be bothered to actually audit users:

I don't see you having offered to audit the 12k+ cases, did you?

So maybe it's easier to just change them all, and then the handful that breaks can be fixed?

Do you maybe want to re-think that "stupid" comment?

Or are you going to spend the time to audit all those other %p users, particularly considering that we _know_ a number of them are bad?

Once you've done that, and offered to keep doing it, we can undo the hashing.

I'll be waiting.

Linus

#2 lore raw
In reply to Alexey Dobriyan
Quoted 5 lines · Alexey Dobriyan
Quoted 2 lines

more %p grepping [filtering out all `%ps %pf %pb' variants] gives a huge number of print outs that potentially can be broken now

Because people who introduce this stupid %p hashing can't be bothered to actually audit users:

lol, by 'stupid' he meant you Linus

Tobin