cpu/hotplug: Fix state name in takedown_cpu comment
PATCH 1/1 cpu/hotplug: Fix state name in takedown_cpu comment
CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback i.e. sched_cpu_dying.
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Boris Ostrovsky <[email protected]>
Cc Dietmar Eggemann <[email protected]>
Cc Quentin Perret <[email protected]>
--- kernel/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/cpu.c +2 -2
@@ -780,8 +780,8 @@ static int takedown_cpu(unsigned int cpu)BUG_ON (cpu_online (cpu));/* -* The CPUHP_AP_SCHED_MIGRATE_DYING callback will have removed all -* runnable tasks from the cpu, there's only the idle task left now +* The teardown callback for CPUHP_AP_SCHED_STARTING will have removed +* all runnable tasks from the cpu, there's only the idle task left now * that the migration thread is done doing the stop_machine thing. * * Wait for the stop thread to go away.
Signature · 1 line
2.14.1
Quoted 11 lines · Brendan Jackman
CPUHP_AP_SCHED_MIGRATE_DYINGdoesn't exist, it looks like this was supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback i.e.sched_cpu_dying.Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Sebastian Andrzej Siewior <[email protected]>Cc Boris Ostrovsky <[email protected]>Cc Dietmar Eggemann <[email protected]>Cc Quentin Perret <[email protected]>
I've added:
Signed-off-by Brendan Jackman <[email protected]>
... to the commit, which SOB you intended to include I guess, right?
Thanks,
Ingo
tip-bot for Brendan Jackman
merge bot[tip:core/urgent] cpu/hotplug: Fix state name in takedown_cpu() comment
In reply to Brendan Jackmancpu/hotplug: Fix state name in takedown_cpu() comment
Commit-ID: 5b1ead6800cb2241aeadcba32736c5836e59c7e1 Gitweb: https://git.kernel.org/tip/5b1ead6800cb2241aeadcba32736c5836e59c7e1 Author: Brendan Jackman <[email protected]> AuthorDate: Wed, 6 Dec 2017 10:59:11 +0000 Committer: Ingo Molnar <[email protected]> CommitDate: Wed, 6 Dec 2017 19:28:45 +0100
cpu/hotplug: Fix state name in takedown_cpu() comment
CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback, i.e. sched_cpu_dying().
Signed-off-by Brendan Jackman <[email protected]>
Cc Boris Ostrovsky <[email protected]>
Cc Dietmar Eggemann <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Quentin Perret <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Thomas Gleixner <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- kernel/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/cpu.c +2 -2
@@ -780,8 +780,8 @@ static int takedown_cpu(unsigned int cpu)BUG_ON (cpu_online (cpu));/* -* The CPUHP_AP_SCHED_MIGRATE_DYING callback will have removed all -* runnable tasks from the cpu, there's only the idle task left now +* The teardown callback for CPUHP_AP_SCHED_STARTING will have removed +* all runnable tasks from the CPU, there's only the idle task left now * that the migration thread is done doing the stop_machine thing. * * Wait for the stop thread to go away.