Skip to contentSkip to conversation

arch/x86: Initialize __max_smt_threads to 1

PATCH New Prarit Bhargava 1 participant 1 message Dec 6, 2017

Subsystems (3)
Networking Network drivers x86
lore
Share & tools
lore

Prarit Bhargava

author
#0 lore raw

PATCH 1/1 arch/x86: Initialize __max_smt_threads to 1

A single socket, single core, single thread system has __max_smt_threads set to 0 since smp_callin() is not called.

__max_smt_threads must be a minimum of 1.

Fixes b1cbacc8663a ("x86/smpboot: Do not use smp_num_siblings in __max_logical_packages calculation)
Signed-off-by Prarit Bhargava <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc [email protected]
Cc "[email protected]"
Cc Clark Williams <[email protected]>
Cc Andi Kleen <[email protected]>
Cc [email protected]
Cc Thomas Gleixner <[email protected]>
Link https://marc.info/?t=151246092100004&r=1&w=2
---
 arch/x86/kernel/smpboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/smpboot.c +1 -1
index eaee15fb7d8b..882c61e1d7a2 100644
@@ -106,7 +106,7 @@ EXPORT_SYMBOL(__max_logical_packages);
 static unsigned int logical_packages __read_mostly;
 
 /* Maximum number of SMT threads on any online core */
-int __max_smt_threads __read_mostly;
+int __read_mostly __max_smt_threads = 1;
 
 /* Flag to indicate if a complete sched domain rebuild is required */
 bool x86_topology_update;
Signature · 1 line
2.15.0.rc0.39.g2f0e14e64