Skip to contentSkip to conversation

gpio: mockup: fix a return value check

PATCH In review Bartosz Golaszewski 2 participants 2 messages Dec 6, 2017 – Dec 8, 2017

Subsystems (2)
GPIO GPIO mockup driver
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 gpio: mockup: fix a return value check

The return value of platform_device_register_resndata() on error is an error code converted to pointer with ERR_PTR(), not NULL.

Check the return value correctly.

Fixes 8a39f597bcfd ("gpio: mockup: rework device probing")
Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/gpio/gpio-mockup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-mockup.c +2 -2
index ea8c730d8af1..3a545ad17817 100644
@@ -387,11 +387,11 @@ static int __init gpio_mockup_init(void)
 							 GPIO_MOCKUP_NAME,
 							 i, NULL, 0, &pdata,
 							 sizeof(pdata));
-		if (!pdev) {
+		if (IS_ERR(pdev)) {
 			gpio_mockup_err("error registering device");
 			platform_driver_unregister(&gpio_mockup_driver);
 			gpio_mockup_unregister_pdevs();
-			return -ENOMEM;
+			return PTR_ERR(pdev);
 		}
 
 		gpio_mockup_pdevs[i] = pdev;
Signature · 1 line
2.15.1
#1 lore raw
Quoted 7 lines · Bartosz Golaszewski

The return value of platform_device_register_resndata() on error is an error code converted to pointer with ERR_PTR(), not NULL.

Check the return value correctly.

Fixes 8a39f597bcfd ("gpio: mockup: rework device probing")
Signed-off-by Bartosz Golaszewski <[email protected]>

Patch applied.

Yours,
Linus Walleij