media: s5p-jpeg: Fix off-by-one problem
PATCH 1/1 media: s5p-jpeg: Fix off-by-one problem
s5p_jpeg_runtime_resume() does not call clk_disable_unprepare() for jpeg->clocks[0] when one of the clk_prepare_enable() fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by Flavio Ceolin <[email protected]>
--- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/s5p-jpeg/jpeg-core.c +1 -1
@@ -3086,7 +3086,7 @@ static int s5p_jpeg_runtime_resume(struct device *dev)for (i =0 ; i < jpeg->variant->num_clocks; i++) { ret =clk_prepare_enable (jpeg->clocks[i]);if (ret) { -while (--i >0 ) +while (--i >=0 )clk_disable_unprepare (jpeg->clocks[i]);return ret; }
Signature · 1 line
2.9.5
W dniu 06.12.2017 o?17:37, Flavio Ceolin pisze:
Quoted 6 lines
s5p_jpeg_runtime_resume()does not callclk_disable_unprepare()for jpeg->clocks[0] when one of theclk_prepare_enable()fails.Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by Flavio Ceolin <[email protected]>
Quoted 18 lines
--- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/s5p-jpeg/jpeg-core.c +1
-1@@ -3086,7 +3086,7 @@ static int s5p_jpeg_runtime_resume(struct device *dev)for (i =0 ; i < jpeg->variant->num_clocks; i++) { ret =clk_prepare_enable (jpeg->clocks[i]);if (ret) { -while (--i >0 ) +while (--i >=0 )clk_disable_unprepare (jpeg->clocks[i]);return ret; }