Skip to contentSkip to conversation

package/omxplayer: add missing dependency to alsa-lib

PATCH New Yann E. MORIN 3 participants 3 messages Dec 4, 2017 – Dec 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/omxplayer: add missing dependency to alsa-lib

Since the bump in 58a00a13 (omxplayer: bump to version 2ee17b2), omxplayer gained a dependency to alsa-lib.

Fixes:

    http://autobuild.buildroot.org/results/652/65212c59a37398681b341263bd76ba8a65ff7828/
---
 package/omxplayer/Config.in    | 3 ++-
 package/omxplayer/omxplayer.mk | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
package/omxplayer/Config.in +2 -1
index b417aa3b0b..bdb3f4054d 100644
@@ -4,9 +4,10 @@ config BR2_PACKAGE_OMXPLAYER
 	depends on BR2_USE_MMU # dbus
 	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS # ffmpeg
 	depends on BR2_INSTALL_LIBSTDCPP # boost
-	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libusb
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib, boost, libusb
 	depends on BR2_USE_WCHAR # boost
 	depends on BR2_PACKAGE_RPI_USERLAND
+	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_FFMPEG
package/omxplayer/omxplayer.mk +1 -1
index 6e92250438..6999269161 100644
@@ -10,7 +10,7 @@ OMXPLAYER_LICENSE = GPL-2.0+
 OMXPLAYER_LICENSE_FILES = COPYING
 
 OMXPLAYER_DEPENDENCIES = \
-	host-pkgconf boost dbus ffmpeg freetype libidn libusb pcre \
+	host-pkgconf alsa-lib boost dbus ffmpeg freetype libidn libusb pcre \
 	rpi-userland zlib
 
 OMXPLAYER_EXTRA_CFLAGS = \
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/omxplayer: add missing dependency to alsa-lib

Quoted 35 lines · Yann E. MORIN

Since the bump in 58a00a13 (omxplayer: bump to version 2ee17b2), omxplayer gained a dependency to alsa-lib.

Fixes:

     http://autobuild.buildroot.org/results/652/65212c59a37398681b341263bd76ba8a65ff7828/
---
  package/omxplayer/Config.in    | 3 ++-
  package/omxplayer/omxplayer.mk | 2 +-
  2 files changed, 3 insertions(+), 2 deletions(-)
package/omxplayer/Config.in +2 -1
index b417aa3b0b..bdb3f4054d 100644
@@ -4,9 +4,10 @@ config BR2_PACKAGE_OMXPLAYER
  	depends on BR2_USE_MMU # dbus
  	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS # ffmpeg
  	depends on BR2_INSTALL_LIBSTDCPP # boost
-	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libusb
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib, boost, libusb
  	depends on BR2_USE_WCHAR # boost
  	depends on BR2_PACKAGE_RPI_USERLAND
+	select BR2_PACKAGE_ALSA_LIB
  	select BR2_PACKAGE_BOOST
  	select BR2_PACKAGE_DBUS
  	select BR2_PACKAGE_FFMPEG
package/omxplayer/omxplayer.mk +0 -0
index 6e92250438..6999269161 100644

package/omxplayer/omxplayer.mk OMXPLAYER_LICENSE = GPL-2.0+ · line 16

Quoted 8 lines
package/omxplayer/omxplayer.mk +1 -1
@@ -10,7 +10,7 @@ OMXPLAYER_LICENSE = GPL-2.0+
  OMXPLAYER_LICENSE_FILES = COPYING
 
  OMXPLAYER_DEPENDENCIES = \
-	host-pkgconf boost dbus ffmpeg freetype libidn libusb pcre \
+	host-pkgconf alsa-lib boost dbus ffmpeg freetype libidn libusb pcre \
  	rpi-userland zlib
 
  OMXPLAYER_EXTRA_CFLAGS = \

Hi Yann,

It seems my patch arrived a bit too late. I waited for my local machine to confirm this test no longer fails and have not noticed you fixed this issue as well. Please ignore my patch.

Signature · 1 line
Julius Kriukas
#2 lore raw

PATCH 1/1 package/omxplayer: add missing dependency to alsa-lib

In reply to Yann E. MORIN

Hello,

Quoted 4 lines · Yann E. MORIN

Since the bump in 58a00a13 (omxplayer: bump to version 2ee17b2), omxplayer gained a dependency to alsa-lib.

Fixes:

Quoted 8 lines
    http://autobuild.buildroot.org/results/652/65212c59a37398681b341263bd76ba8a65ff7828/
---
 package/omxplayer/Config.in    | 3 ++-
 package/omxplayer/omxplayer.mk | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com