Skip to contentSkip to conversation

nvmetcli: port decoration coloring only if its enabled

PATCH New Sagi Grimberg 3 participants 3 messages Dec 5, 2017 – Dec 6, 2017 NVMe

lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH 1/1 nvmetcli: port decoration coloring only if its enabled

Only color the port if its enabled (has subsystems or referrals symlinks).

Also, don't display none trsvcid (like in the fc case).

Signed-off-by Sagi Grimberg <sagi at grimberg.me>
---
 nvmetcli | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
nvmetcli +6 -3
index ead6429d5be5..6b102a235450 100755
@@ -382,10 +382,13 @@ class UIPortNode(UINode):
 
     def summary(self):
         info = []
-        info.append("traddr=" + self.cfnode.get_attr("addr", "traddr"))
-        info.append("trsvcid=" + self.cfnode.get_attr("addr", "trsvcid"))
         info.append("trtype=" + self.cfnode.get_attr("addr", "trtype"))
-        return (", ".join(info), True)
+        info.append("traddr=" + self.cfnode.get_attr("addr", "traddr"))
+        trsvcid = self.cfnode.get_attr("addr", "trsvcid")
+        if trsvcid != "none":
+            info.append("trsvcid=%s" % trsvcid)
+        enabled = not (not self.cfnode.subsystems and not list(self.cfnode.referrals))
+        return (", ".join(info), True if enabled else 0)
 
 class UIPortSubsystemsNode(UINode):
     def __init__(self, parent):
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 nvmetcli: port decoration coloring only if its enabled

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>

Signature · 6 lines
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850