Skip to contentSkip to conversation

gstreamer1.0.inc: Define a PACKAGECONFIG for examples

PATCH In review Peter Kjellerstedt 1 participant 4 messages Dec 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gstreamer1.0.inc: Define a PACKAGECONFIG for examples

This makes it consistent with, e.g., debug, that can be enabled/disabled using a PACKAGECONFIG.

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0.inc +1 -1
index 329193486d..a3a8207229 100644
@@ -21,6 +21,7 @@ SRC_URI_append = " \
 PACKAGECONFIG ??= ""
 
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
+PACKAGECONFIG[examples] = "--enable-examples,--disable-examples"
 PACKAGECONFIG[tests] = "--enable-tests,--disable-tests"
 PACKAGECONFIG[valgrind] = "--enable-valgrind,--disable-valgrind,valgrind,"
 PACKAGECONFIG[gst-tracer-hooks] = "--enable-gst-tracer-hooks,--disable-gst-tracer-hooks,"
@@ -29,7 +30,6 @@ PACKAGECONFIG[dw] = "--with-dw,--without-dw,elfutils"
 
 EXTRA_OECONF = " \
     --disable-dependency-tracking \
-    --disable-examples \
 "
 
 CACHED_CONFIGUREVARS += "ac_cv_header_valgrind_valgrind_h=no"
Signature · 1 line
2.12.0
#1 lore raw

PATCH 1/1 knotty: Be consistent when creating/updating progress bars

When creating a new progress bar (using BBProgress), a colon was appended to the supplied message. However, when updating the message, no colon was appended.

Change this so that the colon is instead part of the widgets that make up the progress bar so that it does not matter when and how the message is updated, it always displays the same.

---
 bitbake/lib/bb/ui/knotty.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
bitbake/lib/bb/ui/knotty.py +6 -6
index fa88e6ccdd..a945fc1994 100644
@@ -45,15 +45,15 @@ class BBProgress(progressbar.ProgressBar):
         self.msg = msg
         self.extrapos = extrapos
         if not widgets:
-            widgets = [progressbar.Percentage(), ' ', progressbar.Bar(), ' ',
-            progressbar.ETA()]
-            self.extrapos = 4
+            widgets = [': ', progressbar.Percentage(), ' ', progressbar.Bar(),
+                       ' ', progressbar.ETA()]
+            self.extrapos = 5
 
         if resize_handler:
             self._resize_default = resize_handler
         else:
             self._resize_default = signal.getsignal(signal.SIGWINCH)
-        progressbar.ProgressBar.__init__(self, maxval, [self.msg + ": "] + widgets, fd=sys.stdout)
+        progressbar.ProgressBar.__init__(self, maxval, [self.msg] + widgets, fd=sys.stdout)
 
     def _handle_resize(self, signum=None, frame=None):
         progressbar.ProgressBar._handle_resize(self, signum, frame)
@@ -248,10 +248,10 @@ class TerminalFilter(object):
                 start_time = activetasks[t].get("starttime", None)
                 if not pbar or pbar.bouncing != (progress < 0):
                     if progress < 0:
-                        pbar = BBProgress("0: %s (pid %s) " % (activetasks[t]["title"], t), 100, widgets=[progressbar.BouncingSlider(), ''], extrapos=2, resize_handler=self.sigwinch_handle)
+                        pbar = BBProgress("0: %s (pid %s)" % (activetasks[t]["title"], t), 100, widgets=[' ', progressbar.BouncingSlider(), ''], extrapos=3, resize_handler=self.sigwinch_handle)
                         pbar.bouncing = True
                     else:
-                        pbar = BBProgress("0: %s (pid %s) " % (activetasks[t]["title"], t), 100, widgets=[progressbar.Percentage(), ' ', progressbar.Bar(), ''], extrapos=4, resize_handler=self.sigwinch_handle)
+                        pbar = BBProgress("0: %s (pid %s)" % (activetasks[t]["title"], t), 100, widgets=[' ', progressbar.Percentage(), ' ', progressbar.Bar(), ''], extrapos=5, resize_handler=self.sigwinch_handle)
                         pbar.bouncing = False
                     activetasks[t]["progressbar"] = pbar
                 tasks.append((pbar, progress, rate, start_time))
Signature · 1 line
2.12.0
#2 lore raw

PATCH 2/2 gstreamer1.0-plugins.inc: Define a PACKAGECONFIG for examples

In reply to Peter Kjellerstedt

This makes it consistent with, e.g., debug, that can be enabled/disabled using a PACKAGECONFIG.

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc +1 -4
index c40d398911..32846165c1 100644
@@ -19,15 +19,12 @@ require gst-plugins-package.inc
 GSTREAMER_ORC ?= "orc"
 
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
+PACKAGECONFIG[examples] = "--enable-examples,--disable-examples"
 PACKAGECONFIG[orc] = "--enable-orc,--disable-orc,orc orc-native"
 PACKAGECONFIG[valgrind] = "--enable-valgrind,--disable-valgrind,valgrind"
 
 export ORCC = "${STAGING_DIR_NATIVE}${bindir}/orcc"
 
-EXTRA_OECONF = " \
-    --disable-examples \
-"
-
 delete_pkg_m4_file() {
 	# This m4 file is out of date and is missing PKG_CONFIG_SYSROOT_PATH tweaks which we need for introspection
 	rm "${S}/common/m4/pkg.m4" || true
Signature · 1 line
2.12.0
#3 lore raw
In reply to Peter Kjellerstedt

Please disregard this patch and the other GStreamer patch in this series. They were apparently around when I used 0* to gather the patch I intended to send.

//Peter

Quoted 47 lines

-----Original Message-----
From: [email protected] [mailto:bitbake- [email protected]] On Behalf Of Peter Kjellerstedt
Sent: den 7 december 2017 15:39
To: [email protected]
Subject: [bitbake-devel] [PATCH 1/2] gstreamer1.0.inc: Define a PACKAGECONFIG for examples

This makes it consistent with, e.g., debug, that can be enabled/disabled using a PACKAGECONFIG.

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0.inc +1 -0
index 329193486d..a3a8207229 100644
@@ -21,6 +21,7 @@ SRC_URI_append = " \
 PACKAGECONFIG ??= ""
 
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
+PACKAGECONFIG[examples] = "--enable-examples,--disable-examples"
 PACKAGECONFIG[tests] = "--enable-tests,--disable-tests"
 PACKAGECONFIG[valgrind] = "--enable-valgrind,--disable-

valgrind,valgrind,"
PACKAGECONFIG[gst-tracer-hooks] = "--enable-gst-tracer-hooks,--
disable-gst-tracer-hooks,"

meta/recipes-multimedia/gstreamer/gstreamer1.0.inc +0 -2
@@ -29,7 +30,6 @@ PACKAGECONFIG[dw] = "--with-dw,--without-dw,elfutils"
 
 EXTRA_OECONF = " \
     --disable-dependency-tracking \
-    --disable-examples \
 "
 
 CACHED_CONFIGUREVARS += "ac_cv_header_valgrind_valgrind_h=no"
--

2.12.0

--
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/bitbake-devel