Skip to contentSkip to conversation

ARM: dts: imx6: RDU2: correct RTC compatible

PATCH New Lucas Stach 3 participants 3 messages Dec 7, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Lucas Stach

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6: RDU2: correct RTC compatible

The RTC is manufactured by Maxim. This is a cosmetic fix, as Linux doesn't match the vendor string for i2c devices.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1 -1
index eef737bd52d9..6bef9a98678e 100644
@@ -581,7 +581,7 @@
 	};
 
 	ds1341: rtc at 68 {
-		compatible = "dallas,ds1341";
+		compatible = "maxim,ds1341";
 		reg = <0x68>;
 	};
 };
Signature · 1 line
2.11.0
reviewer
#1 lore raw

PATCH 1/1 ARM: dts: imx6: RDU2: correct RTC compatible

Hi Lucas,

+ Rob and device tree list

Quoted 13 lines · Lucas Stach

The RTC is manufactured by Maxim. This is a cosmetic fix, as Linux doesn't match the vendor string for i2c devices.

Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +0 -0
index eef737bd52d9..6bef9a98678e 100644

arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi line 584

Quoted 5 lines
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1 -1
@@ -581,7 +581,7 @@
        };
 
        ds1341: rtc at 68 {
-               compatible = "dallas,ds1341";
+               compatible = "maxim,ds1341";

Dallas has been acquired by Maxim and Documentation/devicetree/bindings/rtc/rtc-ds1307.txt mentions "dallas,ds1341", so better keep the existing notation.

Regards,

Fabio Estevam

#2 lore raw

PATCH 1/1 ARM: dts: imx6: RDU2: correct RTC compatible

In reply to Lucas Stach
Quoted 3 lines · Lucas Stach

The RTC is manufactured by Maxim. This is a cosmetic fix, as Linux doesn't match the vendor string for i2c devices.

Actually, it does, see da10c06a044b3752f9162a88b7d26ed2409c5314.

Quoted 26 lines
Signed-off-by Lucas Stach <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1 -1
index eef737bd52d9..6bef9a98678e 100644
@@ -581,7 +581,7 @@
 	};
 
 	ds1341: rtc at 68 {
-		compatible = "dallas,ds1341";
+		compatible = "maxim,ds1341";
 		reg = <0x68>;
 	};
 };
Signature · 7 lines
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com