Skip to contentSkip to conversation

lsusb: Add initial support for USB Audio Class 3

PATCH New Greg KH 1 participant 1 message Dec 8, 2017 USB

lore
Share & tools
lore

Greg KH

author
#0 lore raw

v2 cover lsusb: Add initial support for USB Audio Class 3

Quoted 32 lines · Greg KH
Quoted 31 lines · Michael Drake
Quoted 11 lines · Greg KH
Quoted 10 lines · Michael Drake
Quoted 8 lines · Greg KH
lsusb-v.new renamed from lsusb-v.orig +1 -1
@@ -1110,9 +1110,9 @@
           bDescriptorType        36
           bDescriptorSubtype      1 (HEADER)
           bcdADC               1.00
-        wTotalLength       0x0028
+        wTotalLength           40

[snip]

Quoted 5 lines
Quoted 2 lines

Anyway, since it's a 2 byte field the hex representation is expected here, and the actual value is the same.

Yes, the value is the same, but all other wTotalLength fields exported by lsusb are in decimal. Changing just this one feels odd to me.

Yes, that's a good reason for wanting to change the other ones.

[snip]

Quoted 2 lines

I'll look at moving those other wFields to be also in 0x0000 mode to match up here.

If you like I can work up a patch for that. I'd just be tweaking the old printfs to dump wFields with "0x%04x".

Quoted 6 lines
Quoted 3 lines

I'm also thinking of porting more of the existing lsusb dumping to use the desc_dump() function, but that would have to be piece by piece, as I get time.

I think moving more over to use desc_dump() is a better idea, let me see if I can do one now to see how hard/easy it is...

I've just fixed up the wTotalLength fields for now, I've run out of time to work on this. If you want to convert more of the descriptor fields, that would be wonderful.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html