Skip to contentSkip to conversation

dt: bindings: as3645a: Fix the example node

PATCH RESEND In review Dan Murphy 2 participants 3 messages Dec 8, 2017 – Dec 15, 2017

Subsystems (2)
lore
Share & tools
lore

Dan Murphy

author
#0 lore raw

PATCH RESEND v2 1/1 dt: bindings: as3645a: Fix the example node

Fix the address-cells and size-cells example node
to reflect to the correct representation.

---

v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/leds/ams,as3645a.txt +3 -3
index fdc40e354a64..fc7f5f9f234c 100644
@@ -59,10 +59,10 @@ Example
 =======
 
 	as3645a@30 {
-		#address-cells: 1
-		#size-cells: 0
-		reg = <0x30>;
 		compatible = "ams,as3645a";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x30>;
 		flash@0 {
 			reg = <0x0>;
 			flash-timeout-us = <150000>;
Signature · 1 line
2.15.0.124.g7668cbc60
author
#1 lore raw

Resent to include DT maintainers

Quoted 17 lines · Dan Murphy

Fix the address-cells and size-cells example node
to reflect to the correct representation.

---

v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/leds/ams,as3645a.txt +0 -0
index fdc40e354a64..fc7f5f9f234c 100644

Documentation/devicetree/bindings/leds/ams,as3645a.txt Example · line 61

Quoted 3 lines
Documentation/devicetree/bindings/leds/ams,as3645a.txt +0 -0
@@ -59,10 +59,10 @@ Example
 =======
 
 	as3645a@30 {

Rob

Here is an example of the device name being part of the node name.

Should this be changed as well to leds@30?

Dan

Quoted 11 lines
Documentation/devicetree/bindings/leds/ams,as3645a.txt +3 -3
-		#address-cells: 1
-		#size-cells: 0
-		reg = <0x30>;
 		compatible = "ams,as3645a";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x30>;
 		flash@0 {
 			reg = <0x0>;
 			flash-timeout-us = <150000>;
Signature · 2 lines
------------------
Dan Murphy
maintainer Reviewed-by
#2 lore raw
Quoted 22 lines · Dan Murphy

Resent to include DT maintainers

Quoted 19 lines · Dan Murphy

Fix the address-cells and size-cells example node
to reflect to the correct representation.

---

v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/leds/ams,as3645a.txt +0 -0
index fdc40e354a64..fc7f5f9f234c 100644
@@ -59,10 +59,10 @@ Example
 =======
 
Quoted 7 lines

Documentation/devicetree/bindings/leds/ams,as3645a.txt Example · line 61

Quoted 1 line
Documentation/devicetree/bindings/leds/ams,as3645a.txt +0 -0
 	as3645a@30 {

Rob

Here is an example of the device name being part of the node name.

Should this be changed as well to leds@30?

Yes, but I misspoke earlier and it should be "led-controller@30"

That can be a separate patch though, so for this one: