Skip to contentSkip to conversation

MIPS: ar9331: add watchdog support

PATCH In review Oleksij Rempel 3 participants 8 messages Dec 9, 2017 – Dec 12, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 MIPS: ar9331: add watchdog support

---
 arch/mips/dts/ar9331.dtsi | 6 ++++++
 drivers/watchdog/Kconfig  | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
arch/mips/dts/ar9331.dtsi +6 -0
index b4b8b766b..42baae1e8 100644
@@ -1,5 +1,11 @@
 / {
 	ahb {
+		wdt0: wdt@18060008 {
+			compatible = "qca,ar9331-wdt", "qca,ar9344-wdt";
+			reg = <0x18060008 0x8>;
+			clocks = <&pll ATH79_CLK_CPU>;
+		};
+
 		mac0: mac@19000000 {
 			compatible = "qca,ar9331-ge0";
 			reg = <0x18070000 0x00000100>,
drivers/watchdog/Kconfig +1 -1
index 1f04c7fba..a8f9492ac 100644
@@ -12,7 +12,7 @@ if WATCHDOG
 
 config WATCHDOG_AR9344
 	bool "QCA AR9344"
-	depends on SOC_QCA_AR9344
+	depends on SOC_QCA_AR9344 || SOC_QCA_AR9331
 	help
 	  Add support for watchdog on the QCA AR9344 SoC.
 
Signature · 7 lines
2.14.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

PATCH 2/4 MIPS: ath79: ar9331: add generic RAM macro

with this macro, we should be able to cover most of existing ar9331 based boards.

---
 arch/mips/mach-ath79/include/mach/ar71xx_regs.h |  1 +
 arch/mips/mach-ath79/include/mach/pbl_macros.h  | 37 +++++++++++++++++++++++--
 2 files changed, 35 insertions(+), 3 deletions(-)
arch/mips/mach-ath79/include/mach/ar71xx_regs.h +1 -0
index 31d33b3c4..f73700b5b 100644
@@ -139,6 +139,7 @@
 
 #define AR71XX_RESET_FULL_CHIP		BIT(24)
 
+#define AR933X_BOOTSTRAP_MEM_TYPE	BIT(13)
 #define AR933X_BOOTSTRAP_REF_CLK_40	BIT(0)
 
 #endif /* __ASM_MACH_AR71XX_REGS_H */
arch/mips/mach-ath79/include/mach/pbl_macros.h +34 -3
index 680fcbb86..9e4859b19 100644
@@ -172,6 +172,40 @@
 	.set	pop
 .endm
 
+#define RESET_REG_BOOTSTRAP	((KSEG1 | AR71XX_RESET_BASE) \
+					| AR933X_RESET_REG_BOOTSTRAP)
+
+.macro	pbl_ar9331_ram_generic_config
+	.set	push
+	.set	noreorder
+
+	li	t5,	RESET_REG_BOOTSTRAP
+	/* Documentation and source code of existing boot loaders disagree at
+	 * this place. Doc says: MEM_TYPE[13:12]:
+	 * - 00 = SDRAM
+	 * - 01 = DDR1
+	 * - 10 = DDR2
+	 * The source code of most loaders do not care about BIT(12). So we do
+	 * the same.
+	 */
+	li	t6,	AR933X_BOOTSTRAP_MEM_TYPE
+	lw	t7,	0(t5);
+	and	t6,	t7,	t6
+	beq	zero,	t6,	pbl_ar9331_ram_generic_ddr1
+	nop
+
+pbl_ar9331_ram_generic_ddr2:
+	pbl_ar9331_ddr2_config
+	b	pbl_ar9331_ram_generic_config
+	nop
+
+pbl_ar9331_ram_generic_ddr1:
+	pbl_ar9331_ddr1_config
+
+pbl_ar9331_ram_generic_config:
+	.set	pop
+.endm
+
 #define GPIO_FUNC	((KSEG1 | AR71XX_GPIO_BASE) | AR71XX_GPIO_REG_FUNC)
 
 .macro	pbl_ar9331_uart_enable
@@ -179,9 +213,6 @@
 			| AR933X_GPIO_FUNC_RSRV15, GPIO_FUNC
 .endm
 
-#define RESET_REG_BOOTSTRAP	((KSEG1 | AR71XX_RESET_BASE) \
-					| AR933X_RESET_REG_BOOTSTRAP)
-
 .macro	pbl_ar9331_mdio_gpio_enable
 	/* Bit 18 enables MDC and MDIO function on GPIO26 and GPIO28 */
 	pbl_reg_set (1 << 18), RESET_REG_BOOTSTRAP
Signature · 7 lines
2.14.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

PATCH 3/4 MIPS: ath79: ar9331: add ar9331_pbl_generic_start macro

In reply to Oleksij Rempel

Most of ar9331 boards have identical PBL. So we can sync the code to single macro.

---
 arch/mips/mach-ath79/include/mach/pbl_macros.h | 35 ++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
arch/mips/mach-ath79/include/mach/pbl_macros.h +35 -0
index 9e4859b19..906d73e8c 100644
@@ -368,4 +368,39 @@ normal_path:
 	.set	pop
 .endm
 
+	.macro	ar9331_pbl_generic_start
+	.set	push
+	.set	noreorder
+
+	mips_barebox_10h
+
+	pbl_blt 0xbf000000 skip_pll_ram_config t8
+
+	hornet_mips24k_cp0_setup
+
+	pbl_ar9331_wmac_enable
+
+	hornet_1_1_war
+
+	pbl_ar9331_pll
+	pbl_ar9331_ram_generic_config
+
+skip_pll_ram_config:
+	/* Initialize caches... */
+	mips_cache_reset
+
+	/* ... and enable them */
+	dcache_enable
+
+	pbl_ar9331_uart_enable
+	debug_ll_ar9331_init
+	mips_nmon
+
+	pbl_ar9331_mdio_gpio_enable
+
+	copy_to_link_location	pbl_start
+
+	.set	pop
+	.endm
+
 #endif /* __ASM_MACH_ATH79_PBL_MACROS_H */
Signature · 7 lines
2.14.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

PATCH 4/4 MIPS: add support for DPTechnics DPT-Module v1

In reply to Oleksij Rempel

This product can be found here:
https://dptechnics.com/en/products/dpt-module-v1.html

---
 arch/mips/Makefile                                 |  1 +
 arch/mips/boards/dptechnics-dpt-module/Makefile    |  1 +
 arch/mips/boards/dptechnics-dpt-module/board.c     |  8 ++
 .../include/board/board_pbl_start.h                | 20 +++++
 arch/mips/configs/dptechnics-dpt-module_defconfig  | 89 ++++++++++++++++++++++
 arch/mips/dts/ar9331-dptechnics-dpt-module.dts     | 31 ++++++++
 arch/mips/mach-ath79/Kconfig                       |  7 ++
 7 files changed, 157 insertions(+)
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/Makefile
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/board.c
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h
 create mode 100644 arch/mips/configs/dptechnics-dpt-module_defconfig
 create mode 100644 arch/mips/dts/ar9331-dptechnics-dpt-module.dts
arch/mips/Makefile +1 -0
index dd5ceea20..b965a9c17 100644
@@ -79,6 +79,7 @@ machine-$(CONFIG_MACH_MIPS_AR231X)	:= ar231x
 board-$(CONFIG_BOARD_NETGEAR_WG102)	:= netgear-wg102
 
 machine-$(CONFIG_MACH_MIPS_ATH79)	:= ath79
+board-$(CONFIG_BOARC_DPTECHNICS_DPT_MODULE)	:= dptechnics-dpt-module
 board-$(CONFIG_BOARD_TPLINK_MR3020)	:= tplink-mr3020
 board-$(CONFIG_BOARD_TPLINK_WDR4300)	:= tplink-wdr4300
 board-$(CONFIG_BOARD_BLACK_SWIFT)	:= black-swift
arch/mips/boards/dptechnics-dpt-module/Makefile new file +1 -0
new file mode 100644
index 000000000..dcfc2937d
@@ -0,0 +1 @@
+obj-y += board.o
arch/mips/boards/dptechnics-dpt-module/board.c new file +8 -0
new file mode 100644
index 000000000..7ec7ef8a5
@@ -0,0 +1,8 @@
+#include <common.h>
+#include <init.h>
+
+static int dummy_init(void)
+{
+	return 0;
+}
+postcore_initcall(dummy_init);
arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h new file +20 -0
new file mode 100644
index 000000000..9d6b1b86b
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 2017 Oleksij Rempel <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ */
+
+#include <asm/pbl_macros.h>
+#include <mach/pbl_macros.h>
+#include <asm/pbl_nmon.h>
+
+	.macro	board_pbl_start
+	.set	push
+	.set	noreorder
+
+	ar9331_pbl_generic_start
+
+	.set	pop
+	.endm
arch/mips/configs/dptechnics-dpt-module_defconfig new file +89 -0

89 lines not on this page · raw message

arch/mips/dts/ar9331-dptechnics-dpt-module.dts new file +31 -0
new file mode 100644
index 000000000..39eb36600
@@ -0,0 +1,31 @@
+#include <mips/qca/ar9331_dpt_module.dts>
+#include "ar9331.dtsi"
+
+/ {
+	aliases {
+		spiflash = &spiflash;
+	};
+
+	chosen {
+		environment@0 {
+			compatible = "barebox,environment";
+			device-path = &spiflash, "partname:barebox-environment";
+		};
+	};
+};
+
+&spiflash {
+	partition@0 {
+		label = "barebox";
+		reg = <0 0x80000>;
+	};
+
+	partition@80000 {
+		label = "barebox-environment";
+		reg = <0x80000 0x10000>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+};
arch/mips/mach-ath79/Kconfig +7 -0
index 9fec00c98..4655ce890 100644
@@ -13,6 +13,13 @@ config SOC_QCA_AR9344
 choice
 	prompt "Board type"
 
+config BOARC_DPTECHNICS_DPT_MODULE
+	bool "DPTechnics DPT-Module"
+	select SOC_QCA_AR9331
+	select HAVE_PBL_IMAGE
+	select HAVE_IMAGE_COMPRESSION
+	select HAS_NMON
+
 config BOARD_TPLINK_MR3020
 	bool "TP-LINK MR3020"
 	select SOC_QCA_AR9331
Signature · 7 lines
2.14.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#4 lore raw

Re: [PATCH v1 4/4] MIPS: add support for DPTechnics DPT-Module v1

Quoted 44 lines · On Sat, 9 Dec 2017 10:59:38 +0100 Oleksij Rempel <[email protected]>…

This product can be found here:
https://dptechnics.com/en/products/dpt-module-v1.html

---
 arch/mips/Makefile                                 |  1 +
 arch/mips/boards/dptechnics-dpt-module/Makefile    |  1 +
 arch/mips/boards/dptechnics-dpt-module/board.c     |  8 ++
 .../include/board/board_pbl_start.h                | 20 +++++
 arch/mips/configs/dptechnics-dpt-module_defconfig  | 89 ++++++++++++++++++++++
 arch/mips/dts/ar9331-dptechnics-dpt-module.dts     | 31 ++++++++
 arch/mips/mach-ath79/Kconfig                       |  7 ++
 7 files changed, 157 insertions(+)
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/Makefile
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/board.c
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h
 create mode 100644 arch/mips/configs/dptechnics-dpt-module_defconfig
 create mode 100644 arch/mips/dts/ar9331-dptechnics-dpt-module.dts
arch/mips/Makefile +1 -0
index dd5ceea20..b965a9c17 100644
@@ -79,6 +79,7 @@ machine-$(CONFIG_MACH_MIPS_AR231X)	:= ar231x
 board-$(CONFIG_BOARD_NETGEAR_WG102)	:= netgear-wg102
 
 machine-$(CONFIG_MACH_MIPS_ATH79)	:= ath79
+board-$(CONFIG_BOARC_DPTECHNICS_DPT_MODULE)	:= dptechnics-dpt-module
 board-$(CONFIG_BOARD_TPLINK_MR3020)	:= tplink-mr3020
 board-$(CONFIG_BOARD_TPLINK_WDR4300)	:= tplink-wdr4300
 board-$(CONFIG_BOARD_BLACK_SWIFT)	:= black-swift
arch/mips/boards/dptechnics-dpt-module/Makefile new file +1 -0
new file mode 100644
index 000000000..dcfc2937d
@@ -0,0 +1 @@
+obj-y += board.o
arch/mips/boards/dptechnics-dpt-module/board.c new file +0 -0
new file mode 100644
index 000000000..7ec7ef8a5

arch/mips/boards/dptechnics-dpt-module/board.c line 8

Quoted 8 lines
arch/mips/boards/dptechnics-dpt-module/board.c new file +8 -0
@@ -0,0 +1,8 @@
+#include <common.h>
+#include <init.h>
+
+static int dummy_init(void)
+{
+	return 0;
+}
+postcore_initcall(dummy_init);

Do we really need this dummy_init()?

Quoted 184 lines
arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h new file +20 -0
new file mode 100644
index 000000000..9d6b1b86b
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 2017 Oleksij Rempel <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ */
+
+#include <asm/pbl_macros.h>
+#include <mach/pbl_macros.h>
+#include <asm/pbl_nmon.h>
+
+	.macro	board_pbl_start
+	.set	push
+	.set	noreorder
+
+	ar9331_pbl_generic_start
+
+	.set	pop
+	.endm
arch/mips/configs/dptechnics-dpt-module_defconfig new file +89 -0
new file mode 100644
index 000000000..dbad08fe6
@@ -0,0 +1,89 @@
+CONFIG_BUILTIN_DTB=y
+CONFIG_BUILTIN_DTB_NAME="ar9331-dptechnics-dpt-module"
+CONFIG_MACH_MIPS_ATH79=y
+CONFIG_BOARC_QCA_AR9331_GENERIC=y
+CONFIG_PBL_IMAGE=y
+CONFIG_IMAGE_COMPRESSION_XZKERN=y
+CONFIG_MMU=y
+CONFIG_TEXT_BASE=0x82000000
+CONFIG_MALLOC_TLSF=y
+CONFIG_HUSH_FANCY_PROMPT=y
+CONFIG_CMDLINE_EDITING=y
+CONFIG_AUTO_COMPLETE=y
+CONFIG_CONSOLE_RATP=y
+CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
+CONFIG_RESET_SOURCE=y
+CONFIG_CMD_DMESG=y
+CONFIG_LONGHELP=y
+CONFIG_CMD_IOMEM=y
+CONFIG_CMD_IMD=y
+CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_GO=y
+CONFIG_CMD_LOADB=y
+CONFIG_CMD_LOADY=y
+CONFIG_CMD_RESET=y
+CONFIG_CMD_EXPORT=y
+CONFIG_CMD_DEFAULTENV=y
+CONFIG_CMD_LOADENV=y
+CONFIG_CMD_MAGICVAR=y
+CONFIG_CMD_MAGICVAR_HELP=y
+CONFIG_CMD_SAVEENV=y
+CONFIG_CMD_SHA1SUM=y
+CONFIG_CMD_UNCOMPRESS=y
+CONFIG_CMD_LET=y
+CONFIG_CMD_MSLEEP=y
+CONFIG_CMD_READF=y
+CONFIG_CMD_SLEEP=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_HOST=y
+CONFIG_CMD_MIITOOL=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_ECHO_E=y
+CONFIG_CMD_EDIT=y
+CONFIG_CMD_READLINE=y
+CONFIG_CMD_TIMEOUT=y
+CONFIG_CMD_CRC=y
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_MM=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_DETECT=y
+CONFIG_CMD_FLASH=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_LED=y
+CONFIG_CMD_POWEROFF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_LED_TRIGGER=y
+CONFIG_CMD_WD=y
+CONFIG_CMD_BAREBOX_UPDATE=y
+CONFIG_CMD_OF_NODE=y
+CONFIG_CMD_OF_PROPERTY=y
+CONFIG_CMD_OFTREE=y
+CONFIG_CMD_TIME=y
+CONFIG_NET=y
+CONFIG_NET_NFS=y
+CONFIG_NET_NETCONSOLE=y
+CONFIG_NET_SNTP=y
+CONFIG_OFDEVICE=y
+CONFIG_OF_BAREBOX_DRIVERS=y
+CONFIG_OF_BAREBOX_ENV_IN_FS=y
+CONFIG_DRIVER_SERIAL_AR933X=y
+CONFIG_DRIVER_NET_AG71XX=y
+CONFIG_AR8327N_PHY=y
+CONFIG_AT803X_PHY=y
+CONFIG_MDIO_BITBANG=y
+CONFIG_MDIO_GPIO=y
+CONFIG_DRIVER_SPI_ATH79=y
+CONFIG_MTD=y
+# CONFIG_MTD_OOB_DEVICE is not set
+CONFIG_MTD_M25P80=y
+CONFIG_LED=y
+CONFIG_LED_GPIO=y
+CONFIG_LED_GPIO_OF=y
+CONFIG_LED_TRIGGERS=y
+CONFIG_WATCHDOG=y
+CONFIG_WATCHDOG_AR9344=y
+CONFIG_FS_TFTP=y
+CONFIG_FS_NFS=y
+CONFIG_FS_RATP=y
+CONFIG_DIGEST_SHA224_GENERIC=y
+CONFIG_DIGEST_SHA256_GENERIC=y
arch/mips/dts/ar9331-dptechnics-dpt-module.dts new file +31 -0
new file mode 100644
index 000000000..39eb36600
@@ -0,0 +1,31 @@
+#include <mips/qca/ar9331_dpt_module.dts>
+#include "ar9331.dtsi"
+
+/ {
+	aliases {
+		spiflash = &spiflash;
+	};
+
+	chosen {
+		environment@0 {
+			compatible = "barebox,environment";
+			device-path = &spiflash, "partname:barebox-environment";
+		};
+	};
+};
+
+&spiflash {
+	partition@0 {
+		label = "barebox";
+		reg = <0 0x80000>;
+	};
+
+	partition@80000 {
+		label = "barebox-environment";
+		reg = <0x80000 0x10000>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+};
arch/mips/mach-ath79/Kconfig +7 -0
index 9fec00c98..4655ce890 100644
@@ -13,6 +13,13 @@ config SOC_QCA_AR9344
 choice
 	prompt "Board type"
 
+config BOARC_DPTECHNICS_DPT_MODULE
+	bool "DPTechnics DPT-Module"
+	select SOC_QCA_AR9331
+	select HAVE_PBL_IMAGE
+	select HAVE_IMAGE_COMPRESSION
+	select HAS_NMON
+
 config BOARD_TPLINK_MR3020
 	bool "TP-LINK MR3020"
 	select SOC_QCA_AR9331
Signature · 7 lines
2.14.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 7 lines
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#5 lore raw

Re: [PATCH v1 4/4] MIPS: add support for DPTechnics DPT-Module v1

Am 09.12.2017 um 17:54 schrieb Antony Pavlov:

Quoted 50 lines
Quoted 47 lines · On Sat, 9 Dec 2017 10:59:38 +0100 Oleksij Rempel <[email protected]>…

This product can be found here:
https://dptechnics.com/en/products/dpt-module-v1.html

---
 arch/mips/Makefile                                 |  1 +
 arch/mips/boards/dptechnics-dpt-module/Makefile    |  1 +
 arch/mips/boards/dptechnics-dpt-module/board.c     |  8 ++
 .../include/board/board_pbl_start.h                | 20 +++++
 arch/mips/configs/dptechnics-dpt-module_defconfig  | 89 ++++++++++++++++++++++
 arch/mips/dts/ar9331-dptechnics-dpt-module.dts     | 31 ++++++++
 arch/mips/mach-ath79/Kconfig                       |  7 ++
 7 files changed, 157 insertions(+)
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/Makefile
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/board.c
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h
 create mode 100644 arch/mips/configs/dptechnics-dpt-module_defconfig
 create mode 100644 arch/mips/dts/ar9331-dptechnics-dpt-module.dts
arch/mips/Makefile +1 -0
index dd5ceea20..b965a9c17 100644
@@ -79,6 +79,7 @@ machine-$(CONFIG_MACH_MIPS_AR231X)	:= ar231x
 board-$(CONFIG_BOARD_NETGEAR_WG102)	:= netgear-wg102
 
 machine-$(CONFIG_MACH_MIPS_ATH79)	:= ath79
+board-$(CONFIG_BOARC_DPTECHNICS_DPT_MODULE)	:= dptechnics-dpt-module
 board-$(CONFIG_BOARD_TPLINK_MR3020)	:= tplink-mr3020
 board-$(CONFIG_BOARD_TPLINK_WDR4300)	:= tplink-wdr4300
 board-$(CONFIG_BOARD_BLACK_SWIFT)	:= black-swift
arch/mips/boards/dptechnics-dpt-module/Makefile new file +1 -0
new file mode 100644
index 000000000..dcfc2937d
@@ -0,0 +1 @@
+obj-y += board.o
arch/mips/boards/dptechnics-dpt-module/board.c new file +3 -0
new file mode 100644
index 000000000..7ec7ef8a5
@@ -0,0 +1,8 @@
+#include <common.h>
+#include <init.h>
+
Quoted 8 lines

arch/mips/boards/dptechnics-dpt-module/board.c line 8

Quoted 5 lines
arch/mips/boards/dptechnics-dpt-module/board.c new file +5 -0
+static int dummy_init(void)
+{
+	return 0;
+}
+postcore_initcall(dummy_init);

Do we really need this dummy_init()?

No, but other ways we need to fix the build system. And right now i have no time for that :(

Signature · 2 lines
Regards,
Oleksij

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#6 lore raw

Re: [PATCH v1 4/4] MIPS: add support for DPTechnics DPT-Module v1

Quoted 60 lines · Oleksij Rempel

Am 09.12.2017 um 17:54 schrieb Antony Pavlov:

Quoted 50 lines
Quoted 47 lines · On Sat, 9 Dec 2017 10:59:38 +0100 Oleksij Rempel <[email protected]>…

This product can be found here:
https://dptechnics.com/en/products/dpt-module-v1.html

---
 arch/mips/Makefile                                 |  1 +
 arch/mips/boards/dptechnics-dpt-module/Makefile    |  1 +
 arch/mips/boards/dptechnics-dpt-module/board.c     |  8 ++
 .../include/board/board_pbl_start.h                | 20 +++++
 arch/mips/configs/dptechnics-dpt-module_defconfig  | 89 ++++++++++++++++++++++
 arch/mips/dts/ar9331-dptechnics-dpt-module.dts     | 31 ++++++++
 arch/mips/mach-ath79/Kconfig                       |  7 ++
 7 files changed, 157 insertions(+)
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/Makefile
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/board.c
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h
 create mode 100644 arch/mips/configs/dptechnics-dpt-module_defconfig
 create mode 100644 arch/mips/dts/ar9331-dptechnics-dpt-module.dts
arch/mips/Makefile +1 -0
index dd5ceea20..b965a9c17 100644
@@ -79,6 +79,7 @@ machine-$(CONFIG_MACH_MIPS_AR231X)	:= ar231x
 board-$(CONFIG_BOARD_NETGEAR_WG102)	:= netgear-wg102
 
 machine-$(CONFIG_MACH_MIPS_ATH79)	:= ath79
+board-$(CONFIG_BOARC_DPTECHNICS_DPT_MODULE)	:= dptechnics-dpt-module
 board-$(CONFIG_BOARD_TPLINK_MR3020)	:= tplink-mr3020
 board-$(CONFIG_BOARD_TPLINK_WDR4300)	:= tplink-wdr4300
 board-$(CONFIG_BOARD_BLACK_SWIFT)	:= black-swift
arch/mips/boards/dptechnics-dpt-module/Makefile new file +1 -0
new file mode 100644
index 000000000..dcfc2937d
@@ -0,0 +1 @@
+obj-y += board.o
arch/mips/boards/dptechnics-dpt-module/board.c new file +3 -0
new file mode 100644
index 000000000..7ec7ef8a5
@@ -0,0 +1,8 @@
+#include <common.h>
+#include <init.h>
+
Quoted 8 lines

arch/mips/boards/dptechnics-dpt-module/board.c line 8

Quoted 5 lines
arch/mips/boards/dptechnics-dpt-module/board.c new file +5 -0
+static int dummy_init(void)
+{
+	return 0;
+}
+postcore_initcall(dummy_init);

Do we really need this dummy_init()?

Quoted 2 lines

No, but other ways we need to fix the build system. And right now i have no time for that :(

Are you sure you need the dummy_init()? I just gave it a test and I indeed needed a C file to get it through the linker, but that C file can equally well be empty.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#7 lore raw

Re: [PATCH v1 4/4] MIPS: add support for DPTechnics DPT-Module v1

Am 12.12.2017 um 07:50 schrieb Sascha Hauer:

Quoted 61 lines · Oleksij Rempel
Quoted 60 lines

Am 09.12.2017 um 17:54 schrieb Antony Pavlov:

Quoted 58 lines
Quoted 44 lines · On Sat, 9 Dec 2017 10:59:38 +0100 Oleksij Rempel <[email protected]>…

This product can be found here:
https://dptechnics.com/en/products/dpt-module-v1.html

---
 arch/mips/Makefile                                 |  1 +
 arch/mips/boards/dptechnics-dpt-module/Makefile    |  1 +
 arch/mips/boards/dptechnics-dpt-module/board.c     |  8 ++
 .../include/board/board_pbl_start.h                | 20 +++++
 arch/mips/configs/dptechnics-dpt-module_defconfig  | 89 ++++++++++++++++++++++
 arch/mips/dts/ar9331-dptechnics-dpt-module.dts     | 31 ++++++++
 arch/mips/mach-ath79/Kconfig                       |  7 ++
 7 files changed, 157 insertions(+)
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/Makefile
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/board.c
 create mode 100644 arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h
 create mode 100644 arch/mips/configs/dptechnics-dpt-module_defconfig
 create mode 100644 arch/mips/dts/ar9331-dptechnics-dpt-module.dts
arch/mips/Makefile +1 -0
index dd5ceea20..b965a9c17 100644
@@ -79,6 +79,7 @@ machine-$(CONFIG_MACH_MIPS_AR231X)	:= ar231x
 board-$(CONFIG_BOARD_NETGEAR_WG102)	:= netgear-wg102
 
 machine-$(CONFIG_MACH_MIPS_ATH79)	:= ath79
+board-$(CONFIG_BOARC_DPTECHNICS_DPT_MODULE)	:= dptechnics-dpt-module
 board-$(CONFIG_BOARD_TPLINK_MR3020)	:= tplink-mr3020
 board-$(CONFIG_BOARD_TPLINK_WDR4300)	:= tplink-wdr4300
 board-$(CONFIG_BOARD_BLACK_SWIFT)	:= black-swift
arch/mips/boards/dptechnics-dpt-module/Makefile new file +1 -0
new file mode 100644
index 000000000..dcfc2937d
@@ -0,0 +1 @@
+obj-y += board.o
arch/mips/boards/dptechnics-dpt-module/board.c new file +0 -0
new file mode 100644
index 000000000..7ec7ef8a5

arch/mips/boards/dptechnics-dpt-module/board.c line 8

Quoted 8 lines
arch/mips/boards/dptechnics-dpt-module/board.c new file +8 -0
@@ -0,0 +1,8 @@
+#include <common.h>
+#include <init.h>
+
+static int dummy_init(void)
+{
+	return 0;
+}
+postcore_initcall(dummy_init);

Do we really need this dummy_init()?

Quoted 6 lines
Quoted 2 lines

No, but other ways we need to fix the build system. And right now i have no time for that :(

Are you sure you need the dummy_init()? I just gave it a test and I indeed needed a C file to get it through the linker, but that C file can equally well be empty.

Ok, i'll try it.

Signature · 2 lines
Regards,
Oleksij

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox