Input: Add support for PDP Xbox One controllers

PATCH In review Mark Furneaux (by way of Mark Furneaux <[email protected]>) 3 participants 3 messages Dec 11, 2017 – Jan 22, 2018

Subsystems (2)

HID Input drivers

lore

Share & tools

lore

Mark Furneaux (by way of Mark Furneaux <[email protected]>)

author

2017-12-11 00:25 UTC #0 lore raw

PATCH v2 1/1 Input: Add support for PDP Xbox One controllers

Input: Add support for PDP Xbox One controllers

Adds support for the current lineup of Xbox One controllers from PDP (Performance Designed Products). These controllers are very picky with their initialization sequence and require an additional 2 packets before they send any input reports.

Signed-off-by Mark Furneaux <[email protected]>

---
Changes in v2:

- Zeroed the sequence numbers and removed the redundant quirk entry.
- Corrected mangled formatting from my email client.

 drivers/input/joystick/xpad.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

drivers/input/joystick/xpad.c +19 -0

index d86e595..d88d3e0 100644
@@ -229,6 +229,7 @@ static const struct xpad_device {
 	{ 0x0e6f, 0x0213, "Afterglow Gamepad for Xbox 360", 0, XTYPE_XBOX360 },
 	{ 0x0e6f, 0x021f, "Rock Candy Gamepad for Xbox 360", 0, XTYPE_XBOX360 },
 	{ 0x0e6f, 0x0246, "Rock Candy Gamepad for Xbox One 2015", 0, XTYPE_XBOXONE },
+	{ 0x0e6f, 0x02ab, "PDP Controller for Xbox One", 0, XTYPE_XBOXONE },
 	{ 0x0e6f, 0x0301, "Logic3 Controller", 0, XTYPE_XBOX360 },
 	{ 0x0e6f, 0x0346, "Rock Candy Gamepad for Xbox One 2016", 0, XTYPE_XBOXONE },
 	{ 0x0e6f, 0x0401, "Logic3 Controller", 0, XTYPE_XBOX360 },

@@ -476,6 +477,22 @@ static const u8 xboxone_hori_init[] = {
 };
 
 /*
+ * This packet is required for some of the PDP pads to start
+ * sending input reports. One of those pads is (0x0e6f:0x02ab).
+ */
+static const u8 xboxone_pdp_init1[] = {
+	0x0a, 0x20, 0x00, 0x03, 0x00, 0x01, 0x14
+};
+
+/*
+ * This packet is required for some of the PDP pads to start
+ * sending input reports. One of those pads is (0x0e6f:0x02ab).
+ */
+static const u8 xboxone_pdp_init2[] = {
+	0x06, 0x20, 0x00, 0x02, 0x01, 0x00
+};
+
+/*
  * A specific rumble packet is required for some PowerA pads to start
  * sending input reports. One of those pads is (0x24c6:0x543a).
  */

@@ -505,6 +522,8 @@ static const struct xboxone_init_packet xboxone_init_packets[] = {
 	XBOXONE_INIT_PKT(0x0e6f, 0x0165, xboxone_hori_init),
 	XBOXONE_INIT_PKT(0x0f0d, 0x0067, xboxone_hori_init),
 	XBOXONE_INIT_PKT(0x0000, 0x0000, xboxone_fw2015_init),
+	XBOXONE_INIT_PKT(0x0e6f, 0x02ab, xboxone_pdp_init1),
+	XBOXONE_INIT_PKT(0x0e6f, 0x02ab, xboxone_pdp_init2),
 	XBOXONE_INIT_PKT(0x24c6, 0x541a, xboxone_rumblebegin_init),
 	XBOXONE_INIT_PKT(0x24c6, 0x542a, xboxone_rumblebegin_init),
 	XBOXONE_INIT_PKT(0x24c6, 0x543a, xboxone_rumblebegin_init),

Cameron Gutman

Reviewed-by on v2 1/1

2017-12-12 05:42 UTC #1 lore raw

Quoted 7 lines · Mark Furneaux

Input: Add support for PDP Xbox One controllers
Adds support for the current lineup of Xbox One controllers from PDP (Performance Designed Products). These controllers are very picky with their initialization sequence and require an additional 2 packets before they send any input reports.

Quoted 8 lines

Signed-off-by Mark Furneaux <[email protected]>
---
Changes in v2:
- Zeroed the sequence numbers and removed the redundant quirk entry.
- Corrected mangled formatting from my email client.

Thanks, LGTM.

Reviewed-by Cameron Gutman <[email protected]>

Dmitry Torokhov

maintainer

2018-01-22 19:25 UTC #2 lore raw

Quoted 13 lines · Cameron Gutman

Quoted 12 lines · Mark Furneaux
Input: Add support for PDP Xbox One controllers
Adds support for the current lineup of Xbox One controllers from PDP (Performance Designed Products). These controllers are very picky with their initialization sequence and require an additional 2 packets before they send any input reports.
Signed-off-by Mark Furneaux <[email protected]>
---
Changes in v2:

Quoted 7 lines

Quoted 3 lines
- Zeroed the sequence numbers and removed the redundant quirk entry.
- Corrected mangled formatting from my email client.
Thanks, LGTM.
Reviewed-by Cameron Gutman <[email protected]>

Applied and earmarked for stable, thank you.

Signature · 1 line

Dmitry