git-gui: Make push remote combobox full width
PATCH 1/1 git-gui: Make push remote combobox full width
When pushing changes, the Remote combobox for the Destination Repository does not take all available space in the layout. With long remote names, this causes the combobox to have truncated entries even though there is room to display them.
Anchor the remote_m combobox to both left and right edges of the grid cell and use the same padding as url_t for a consistent, dynamic layout.
--- lib/transport.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/transport.tcl +1 -1
@@ -173,7 +173,7 @@ proc do_push_anywhere {} { } else { eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes } - grid $w.dest.remote_r $w.dest.remote_m -sticky w + grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5} if {[lsearch -sorted -exact $all_remotes origin] != -1} { set push_remote origin } else {
Signature · 1 line
2.15.1
Just wondering if I submitted this patch correctly and to the right place.
Quoted 28 lines · Peter Urbanec
When pushing changes, the Remote combobox for the Destination Repository does not take all available space in the layout. With long remote names, this causes the combobox to have truncated entries even though there is room to display them.
Anchor the
remote_mcombobox to both left and right edges of the grid cell and use the same padding asurl_tfor a consistent, dynamic layout.Signed-off-by Peter Urbanec <[email protected]>--- lib/transport.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/transport.tcl +1
-1@@ -173,7 +173,7 @@ proc do_push_anywhere {} { } else { eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes } - grid $w.dest.remote_r $w.dest.remote_m -sticky w + grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5} if {[lsearch -sorted -exact $all_remotes origin] != -1} { set push_remote origin } else {
Quoted 1 line · Peter Urbanec
Just wondering if I submitted this patch correctly and to the right place.
You sent it to the right place. Unfortunately, Pat hasn't been around much lately, so the git-gui project is apparently slumbering.
Junio has accepted a few patches for git-gui recently[1,2,3]; whether he's interested in doing the same for your patch is unknown.
[1]: https://github.com/patthoyts/git-gui/pull/17
[2]: https://github.com/patthoyts/git-gui/pull/16
[3]: https://github.com/patthoyts/git-gui/pull/15