Skip to contentSkip to conversation

Bluetooth: Utilize %*ph specifier

PATCH In review Andy Shevchenko 2 participants 2 messages Dec 11, 2017 1 message not in the archive

Subsystems (4)
Networking Network drivers Bluetooth drivers Bluetooth
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 Bluetooth: Utilize %*ph specifier

Instead of open coding byte-by-byte printing, re-use %*ph specifier.

Signed-off-by Andy Shevchenko <[email protected]>
---
 net/bluetooth/hci_debugfs.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)
net/bluetooth/hci_debugfs.c +3 -14
index 63df63ebfb24..e204bfdb5ba2 100644
@@ -106,21 +106,10 @@ static int features_show(struct seq_file *f, void *ptr)
 	u8 p;
 
 	hci_dev_lock(hdev);
-	for (p = 0; p < HCI_MAX_PAGES && p <= hdev->max_page; p++) {
-		seq_printf(f, "%2u: 0x%2.2x 0x%2.2x 0x%2.2x 0x%2.2x "
-			   "0x%2.2x 0x%2.2x 0x%2.2x 0x%2.2x\n", p,
-			   hdev->features[p][0], hdev->features[p][1],
-			   hdev->features[p][2], hdev->features[p][3],
-			   hdev->features[p][4], hdev->features[p][5],
-			   hdev->features[p][6], hdev->features[p][7]);
-	}
+	for (p = 0; p < HCI_MAX_PAGES && p <= hdev->max_page; p++)
+		seq_printf(f, "%2u: %8ph\n", p, hdev->features[p]);
 	if (lmp_le_capable(hdev))
-		seq_printf(f, "LE: 0x%2.2x 0x%2.2x 0x%2.2x 0x%2.2x "
-			   "0x%2.2x 0x%2.2x 0x%2.2x 0x%2.2x\n",
-			   hdev->le_features[0], hdev->le_features[1],
-			   hdev->le_features[2], hdev->le_features[3],
-			   hdev->le_features[4], hdev->le_features[5],
-			   hdev->le_features[6], hdev->le_features[7]);
+		seq_printf(f, "LE: %8ph\n", hdev->le_features);
 	hci_dev_unlock(hdev);
 
 	return 0;
Signature · 1 line
2.15.0

A message that is not in the archive (sent off-list or not yet received): 20171211101033.60971-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]

#2 lore raw

Hi Andy,

Quoted 6 lines

Instead of open coding byte-by-byte printing, re-use %*ph specifier.

Signed-off-by Andy Shevchenko <[email protected]>

---
net/bluetooth/hci_debugfs.c | 17 +++--------------

1 file changed, 3 insertions(+), 14 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel