USB: serial: Avoid goto in bulk callbacks
Hi Oliver, Johan,
Quoted 10 lines · Oliver Neukum
Am Montag, den 11.12.2017, 00:11 +0100 schrieb Ladislav Michl:
Quoted 3 lines
Refactor bulk callback functions to make use of goto pointless.
Hi,
you seem to assume that this is a good thing by itself which needs no further justification. I disagree. You duplicated code.
Where did I duplicated code? Success code path is straightforward now, so while I'm not pushing at all for this patch to be included as it is side effect of looking into another drivers while debugging something else, I really do not understand your comment.
Quoted 2 lines · Johan Hovold
So as for the ti driver, I prefer keeping the success path out of the switch statement.
Undestood, as noted above, I have no strong preference either way. Just did what seemed easier to read to me :)
Best regads,
ladis
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html