Fixes for omapdrm on OpenPandora and GTA04
Subsystems (2)
v4 cover Fixes for omapdrm on OpenPandora and GTA04
Changes V4:
* removed already accepted panel driver patches
* reworded commit subject to clarify
2017-11-28 16:49:00: Changes V3:
* stay compatible with old DTB files which still use "toppoly" (suggested by Tomi Valkeinen)
* replaced MODULE_ALIAS entries by MODULE_DEVICE_TABLE (suggested by Andrew F. Davis)
* removed DSI VDDS patch as it has already been accepted
2017-11-16 09:50:22: Changes V2:
* replaced patch to fix DSI VDDS for OMAP3 by equivalent patch from Laurent Pinchart
* keep previous compatibility option in panel driver to handle older device tree binaries
2017-11-08 22:09:36:
This patch set fixes vendor names of the panels and fixes a problem on omapdrm with enabling VDD_DSI for OMAP3 which is needed for displaying the Red and Green channel on OMAP3530 (Pandora).
H. Nikolaus Schaller (2):
DTS: GTA04: improve panel compatibility string
DTS: Pandora: fix panel compatibility string
arch/arm/boot/dts/omap3-gta04.dtsi | 2 +- arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.12.2
PATCH v4 1/2 DTS: GTA04: improve panel compatibility string
Official vendor string is now "tpo" and not "toppoly".
Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1" so that the driver understands both.
--- arch/arm/boot/dts/omap3-gta04.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-gta04.dtsi +1 -1
@@ -86,7 +86,7 @@ /* lcd panel */ lcd: td028ttec1@0 { - compatible = "toppoly,td028ttec1"; + compatible = "tpo,td028ttec1"; reg = <0>; spi-max-frequency = <100000>; spi-cpol;
Signature · 1 line
2.12.2
Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string
Quoted 4 lines · H. Nikolaus Schaller
Official vendor string is now "tpo" and not "toppoly".
Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1" so that the driver understands both.
Tomi, so what's the plan with the dependency patch, is that for v4.16 or for the v4.15-rc cycle?
Regards,
Tony
Quoted 21 lines
Signed-off-by H. Nikolaus Schaller <[email protected]>--- arch/arm/boot/dts/omap3-gta04.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/omap3-gta04.dtsi +1
-1@@ -86,7 +86,7 @@ /* lcd panel */ lcd: td028ttec1@0 { - compatible = "toppoly,td028ttec1"; + compatible = "tpo,td028ttec1"; reg = <0>; spi-max-frequency = <100000>; spi-cpol;Signature · 1 line
2.12.2
Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string
Quoted 8 lines · Tony Lindgren
Quoted 4 lines · H. Nikolaus Schaller
Official vendor string is now "tpo" and not "toppoly".
Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1" so that the driver understands both.
Tomi, so what's the plan with the dependency patch, is that for v4.16 or for the v4.15-rc cycle?
The dependency patch for this one is queued for v4.16 (I just sent a pull request today). I could pick this one up (if you give an ack) if I send another DRM pull request, but I probably don't have anything else to send so most likely I won't pick this up for v4.16.
The patch 2/2 in the series doesn't have dependencies and can be applied as a fix for 4.15, or for 4.16.
Neither of these are critical, as things work fine without these patches.
Tomi
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string
Quoted 7 lines · Tomi Valkeinen
Quoted 6 lines · Tony Lindgren
Quoted 4 lines · H. Nikolaus Schaller
Official vendor string is now "tpo" and not "toppoly".
Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1" so that the driver understands both.
Quoted 7 lines
Quoted 2 lines
Tomi, so what's the plan with the dependency patch, is that for v4.16 or for the v4.15-rc cycle?
The dependency patch for this one is queued for v4.16 (I just sent a pull request today). I could pick this one up (if you give an ack) if I send another DRM pull request, but I probably don't have anything else to send so most likely I won't pick this up for v4.16.
OK thanks I'll queue both of these for v4.16 then.
Quoted 4 lines
The patch 2/2 in the series doesn't have dependencies and can be applied as a fix for 4.15, or for 4.16.
Neither of these are critical, as things work fine without these patches.
OK thanks for confirming that.
Regards,
Tony
PATCH v4 2/2 DTS: Pandora: fix panel compatibility string
In reply to H. Nikolaus SchallerWe can remove the unnecessary "omapdss," prefix because the omapdrm driver takes care of it when matching with the driver table.
--- arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-pandora-common.dtsi +1 -1
@@ -626,7 +626,7 @@ lcd: lcd@1 { reg = <1>; /* CS1 */ - compatible = "omapdss,tpo,td043mtea1"; + compatible = "tpo,td043mtea1"; spi-max-frequency = <100000>; spi-cpol; spi-cpha;
Signature · 1 line
2.12.2