Skip to contentSkip to conversation

ARM: dts: exynos: Enable Mixer node for Exynos5800 Peach Pi machine

PATCH Applied Javier Martinez Canillas 4 participants 11 messages Dec 12, 2017

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Javier Martinez Canillas

author
#0 lore raw

PATCH v2 1/1 ARM: dts: exynos: Enable Mixer node for Exynos5800 Peach Pi machine

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.
- Add Marek's Acked-by tag.
- Add fixes tag.

 arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/exynos5800-peach-pi.dts +4 -0
index b2b95ff205e8..0029ec27819c 100644
@@ -664,6 +664,10 @@
 	status = "okay";
 };
 
+&mixer {
+	status = "okay";
+};
+
 /* eMMC flash */
 &mmc_0 {
 	status = "okay";
Signature · 1 line
2.14.3
maintainer
#1 lore raw
Quoted 5 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Quoted 8 lines
Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

Best regards,
Krzysztof

Quoted 24 lines

- Add Marek's Acked-by tag.
- Add fixes tag.

 arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/exynos5800-peach-pi.dts +4 -1
index b2b95ff205e8..0029ec27819c 100644
@@ -664,6 +664,10 @@
        status = "okay";
 };
 
+&mixer {
+       status = "okay";
+};
+
 /* eMMC flash */
 &mmc_0 {
        status = "okay";
--

2.14.3

maintainer
#2 lore raw
Quoted 11 lines · Krzysztof Kozlowski
Quoted 9 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>
Quoted 7 lines
Quoted 4 lines

---

Changes in v2:
- Remove RFT tag.

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Best regards,
Krzysztof

#3 lore raw

Hi Krzysztof,

Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · Krzysztof Kozlowski
Quoted 11 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Changes in v2:
- Remove RFT tag.

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Frankly, I don't expect that this will solve the boot hang issue on PeachPi. However it should at least hide the unbalanced regulator issue.

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Tested-by
#4 lore raw
Quoted 19 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Krzysztof Kozlowski
Quoted 13 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Frankly, I don't expect that this will solve the boot hang issue on PeachPi. However it should at least hide the unbalanced regulator issue.

We have a peach-pi in our LAVA lab so I've tested it and actually, it does fix the hang on v4.15-rc3:

https://lava.collabora.co.uk/scheduler/job/1019877
https://lava.collabora.co.uk/scheduler/job/1019878

I ran it twice and it booted both times. I also ran the same boot tests with the same kernel but the dtb from v4.15-rc3 without the fix to double check and these failed:

https://lava.collabora.co.uk/scheduler/job/1019879
https://lava.collabora.co.uk/scheduler/job/1019880

Tested-by Guillaume Tucker <[email protected]>

Thanks for the fix!

Guillaume

author
#5 lore raw

[adding Inki to cc list]

Hello Guillaume,

Quoted 39 lines · Guillaume Tucker
Quoted 19 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Krzysztof Kozlowski
Quoted 13 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Frankly, I don't expect that this will solve the boot hang issue on PeachPi. However it should at least hide the unbalanced regulator issue.

We have a peach-pi in our LAVA lab so I've tested it and actually, it does fix the hang on v4.15-rc3:

   https://lava.collabora.co.uk/scheduler/job/1019877
   https://lava.collabora.co.uk/scheduler/job/1019878

I ran it twice and it booted both times. I also ran the same boot tests with the same kernel but the dtb from v4.15-rc3 without the fix to double check and these failed:

Quoted 9 lines
   https://lava.collabora.co.uk/scheduler/job/1019879
   https://lava.collabora.co.uk/scheduler/job/1019880
Tested-by Guillaume Tucker <[email protected]>

Thanks for the fix!

Thanks for testing!

Now, I think the exynos-drm driver should cope with an incorrect DTB and don't crash the machine, the driver should only fail to probe and lead to a working machine with no display.

But as mentioned, that's a different issue and orthogonal to the DTS fix.

Quoted 2 lines

Guillaume

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
maintainer
#6 lore raw
In reply to Guillaume Tucker
Quoted 54 lines · Guillaume Tucker
Quoted 33 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 25 lines · Krzysztof Kozlowski
Quoted 11 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x
Mixer nodes") disabled the Mixer node by default in the DTSI and enabled
for each Exynos 542x DTS. But unfortunately it missed to enable it for the
Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos
Quoted 8 lines

542x Mixer nodes")

Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

Quoted 8 lines
Quoted 3 lines

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Frankly, I don't expect that this will solve the boot hang issue on PeachPi.
However it should at least hide the unbalanced regulator issue.

We have a peach-pi in our LAVA lab so I've tested it and actually, it does fix the hang on v4.15-rc3:

https://lava.collabora.co.uk/scheduler/job/1019877
https://lava.collabora.co.uk/scheduler/job/1019878

I ran it twice and it booted both times. I also ran the same boot tests with the same kernel but the dtb from v4.15-rc3 without the fix to double check and these failed:

Quoted 5 lines

https://lava.collabora.co.uk/scheduler/job/1019879
https://lava.collabora.co.uk/scheduler/job/1019880

Tested-by Guillaume Tucker <[email protected]>

Thank you!

Best regards,
Krzysztof

#7 lore raw
In reply to Guillaume Tucker

Hi Guillaume,

Quoted 46 lines · Guillaume Tucker
Quoted 27 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 24 lines · Krzysztof Kozlowski
Quoted 22 lines · Krzysztof Kozlowski
Quoted 10 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x
Mixer nodes") disabled the Mixer node by default in the DTSI and enabled
for each Exynos 542x DTS. But unfortunately it missed to enable it for the
Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to
Quoted 8 lines

Exynos 542x Mixer nodes")

Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

Quoted 7 lines
Quoted 3 lines

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Frankly, I don't expect that this will solve the boot hang issue on PeachPi.
However it should at least hide the unbalanced regulator issue.

We have a peach-pi in our LAVA lab so I've tested it and actually, it does fix the hang on v4.15-rc3:

? https://lava.collabora.co.uk/scheduler/job/1019877
? https://lava.collabora.co.uk/scheduler/job/1019878

I ran it twice and it booted both times.? I also ran the same boot tests with the same kernel but the dtb from v4.15-rc3 without the fix to double check and these failed:

Quoted 8 lines

? https://lava.collabora.co.uk/scheduler/job/1019879
? https://lava.collabora.co.uk/scheduler/job/1019880

Tested-by Guillaume Tucker <[email protected]>

Thanks for the fix!

Well, thanks for the test! It proves that there the boot failure is caused by an issue somewhere in the error path of Exynos DRM, Analogix DP, Simple Panel or other drivers.

This patch simply hides it by fixing the source issue of the Exynos DRM initialization failure. :-)

I hope Javier will be able to investigate the discussed hang issue later, as fixing it is also imho important.

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
#8 lore raw
Quoted 55 lines · Marek Szyprowski

Hi Guillaume,

Quoted 39 lines · Guillaume Tucker
Quoted 19 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Krzysztof Kozlowski
Quoted 13 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of testing but apparently no one has Peach Pi.

Frankly, I don't expect that this will solve the boot hang issue on PeachPi. However it should at least hide the unbalanced regulator issue.

We have a peach-pi in our LAVA lab so I've tested it and actually, it does fix the hang on v4.15-rc3:

? https://lava.collabora.co.uk/scheduler/job/1019877
? https://lava.collabora.co.uk/scheduler/job/1019878

I ran it twice and it booted both times.? I also ran the same boot tests with the same kernel but the dtb from v4.15-rc3 without the fix to double check and these failed:

Quoted 8 lines

? https://lava.collabora.co.uk/scheduler/job/1019879
? https://lava.collabora.co.uk/scheduler/job/1019880

Tested-by Guillaume Tucker <[email protected]>

Thanks for the fix!

Well, thanks for the test! It proves that there the boot failure is caused by an issue somewhere in the error path of Exynos DRM, Analogix DP, Simple Panel or other drivers.

Quoted 5 lines

This patch simply hides it by fixing the source issue of the Exynos DRM initialization failure. :-)

I hope Javier will be able to investigate the discussed hang issue later, as fixing it is also imho important.

Sure. This device tree change is needed to get HDMI to work so it's still a fix for that. Also it's good to know that nothing else breaks when the driver issue is "hidden". Might be worth testing on -next as well as it might help spot any new issues that haven't been merged in mainline yet, or in general give another data point.

Guillaume

author
#9 lore raw
In reply to Krzysztof Kozlowski

Hello Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Changes in v2:
- Remove RFT tag.

I removed the tag because Marek acked it and the patch has merits on its own regardless of the boot issue (it just introduces a change that was missed in the mentioned commit).

Quoted 6 lines
Quoted 3 lines

Thanks guys! However I still would like to see a tested-by for this on Peach Pi (AFAIU, Marek's only acked the code/solution).

On the other hand I could just apply it for my for-next branch and we'll see if it fixes kernel-ci boot tests... Not a nice way of

As Marek said this probably won't solve the issue, or at best it would just mask it. Seems the problem is on the probe deferral path in exynos-drm driver.

Quoted 2 lines

testing but apparently no one has Peach Pi.

I do have one, but I haven't used it for months and don't have time to setup a test environment now. I will probably do that this weekend to dig deeper.

Quoted 3 lines

Best regards,
Krzysztof

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
maintainer Applied
#10 lore raw
In reply to Javier Martinez Canillas
Quoted 11 lines · Javier Martinez Canillas

Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") disabled the Mixer node by default in the DTSI and enabled for each Exynos 542x DTS. But unfortunately it missed to enable it for the Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.

Fixes 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
Signed-off-by Javier Martinez Canillas <[email protected]>
Acked-by Marek Szyprowski <[email protected]>

---

Quoted 8 lines

Changes in v2:
- Remove RFT tag.
- Add Marek's Acked-by tag.
- Add fixes tag.

 arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++++
 1 file changed, 4 insertions(+)

Thanks, applied for current cycle (fixes).

Best regards,
Krzysztof