introduce Rockchip rockusb

PATCH Superseded Eddie Cai 3 participants 8 messages Dec 1, 2017 – Dec 15, 2017

Subsystems (4)

Arm (32-bit) USB Arm sub-architectures Arm Rockchip

lore

Share & tools

lore

Eddie Cai

author

2017-12-01 07:20 UTC #0 lore raw

v11 cover introduce Rockchip rockusb

Changes in v11:
-fix check patch error
-add maintainer

Changes in v10:
-rebase to latest mainline U-Boot
-fix build error

Changes in v9:
-rebase to the latest mainline
-fix compile error

Changes in v8:
-rebase to v2017.09-rc2
-fix compile error

Changes in v7:
-use imply in the Kconfig to enable rockusb

Changes in v6:
-enable rockusb in defconfig
-move some data to f_rockusb structure

Changes in v5:
-fix build error when build other board
-fix checkpatch error

Changes in v4:
-use enum instead of macro define
-move some structure define and macro to f_rockusb.h -add some function comment as Simon required -address other comment from Simon
-fix build error as Lukasz point out

Changes in v3:
-switch back to use g_dnl code
-address comment from Lukasz and Simon
-fix checkpatch error

Changes in v2:
-switch to use usb masstorage framework
-add readme for rockusb

Eddie Cai (4):
usb: rockchip: add the rockusb gadget
usb: rockchip: add rockusb command
rockchip:usb: add a simple readme for rockusb
rockchip: rk3288: enable rockusb support on rk3288 based device

 MAINTAINERS                                    |   7 +
 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 arch/arm/mach-rockchip/Kconfig                 |   2 +
 cmd/Kconfig                                    |   8 +
 cmd/Makefile                                   |   1 +
 cmd/rockusb.c                                  |  74 +++
 configs/chromebit_mickey_defconfig             |   7 +
 configs/chromebook_jerry_defconfig             |   7 +
 configs/chromebook_minnie_defconfig            |   7 +
 configs/evb-rk3288_defconfig                   |   9 +
 configs/fennec-rk3288_defconfig                |   5 +
 configs/firefly-rk3288_defconfig               |   7 +
 configs/miqi-rk3288_defconfig                  |   5 +
 configs/phycore-rk3288_defconfig               |   6 +
 configs/popmetal-rk3288_defconfig              |   5 +
 configs/rock2_defconfig                        |   8 +
 configs/tinker-rk3288_defconfig                |   5 +
 configs/vyasa-rk3288_defconfig                 |  25 +
 doc/README.rockusb                             |  51 ++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 697 +++++++++++++++++++++++++
 22 files changed, 1077 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 cmd/rockusb.c
 create mode 100644 doc/README.rockusb
 create mode 100644 drivers/usb/gadget/f_rockusb.c

Signature · 1 line

1.9.1

Eddie Cai

author

2017-12-01 07:20 UTC #1 lore raw

PATCH v11 1/4 usb: rockchip: add the rockusb gadget

this patch implement rockusb protocol on the device side. this is based on USB download gadget infrastructure. the rockusb function implements the rd, wl, rid commands. it can work with rkdeveloptool

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

---
Changes in v11:
-fix checkpatch error
-add maintainer

Changes in v10:
-fix build error

Changes in v9:
-fix compile error

Changes in v8:
-none

Changes in v7:
-none

Changes in v6:
-move some data to f_rockusb structure

Changes in v5:
-fix build error when build non-rockchip board
-fix checkpatch error

---
 MAINTAINERS                                    |   5 +
 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 697 +++++++++++++++++++++++++
 5 files changed, 843 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 drivers/usb/gadget/f_rockusb.c

MAINTAINERS +5 -0

index 2a20b94..e92a15d 100644
@@ -452,6 +452,11 @@ S:	Maintained
 T:	git git://git.denx.de/u-boot-usb.git
 F:	drivers/usb/
 
+ROCKUSB
+M:	Eddie Cai <[email protected]>
+S:      Maintained
+F:	drivers/usb/gadget/f_rockusb.c
+
 VIDEO
 M:	Anatolij Gustschin <[email protected]>
 S:	Maintained

arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +132 -0

132 lines not on this page · raw message

drivers/usb/gadget/Kconfig +8 -0

index 102a63b..c387f5e 100644
@@ -134,6 +134,14 @@ config USB_FUNCTION_SDP
 	  allows to download images into memory and execute (jump to) them
 	  using the same protocol as implemented by the i.MX family's boot ROM.
 
+config USB_FUNCTION_ROCKUSB
+        bool "Enable USB rockusb gadget"
+        help
+          Rockusb protocol is widely used by Rockchip SoC based devices. It can
+          read/write info, image to/from devices. This enables the USB part of
+          the rockusb gadget.for more detail about Rockusb protocol, please see
+          doc/README.rockusb
+
 endif # USB_GADGET_DOWNLOAD
 
 config USB_ETHER

drivers/usb/gadget/Makefile +1 -0

index 7258099..ee8bc99 100644
@@ -30,6 +30,7 @@ obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
 obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
 obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
 obj-$(CONFIG_USB_FUNCTION_SDP) += f_sdp.o
+obj-$(CONFIG_USB_FUNCTION_ROCKUSB) += f_rockusb.o
 endif
 endif
 ifdef CONFIG_USB_ETHER

drivers/usb/gadget/f_rockusb.c new file +697 -0

697 lines not on this page · raw message

Signature · 1 line

1.9.1

Marek Vasut

2017-12-01 09:09 UTC #2 lore raw

PATCH v11 1/4 usb: rockchip: add the rockusb gadget

Quoted 80 lines · Eddie Cai

this patch implement rockusb protocol on the device side. this is based on USB download gadget infrastructure. the rockusb function implements the rd, wl, rid commands. it can work with rkdeveloptool

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

---
Changes in v11:

(quoted diff) +0 -2

-fix checkpatch error
-add maintainer

Changes in v10:
-fix build error

Changes in v9:
-fix compile error

Changes in v8:
-none

Changes in v7:
-none

Changes in v6:
-move some data to f_rockusb structure

Changes in v5:

(quoted diff) +0 -2

-fix build error when build non-rockchip board
-fix checkpatch error

Changes in v4:

(quoted diff) +0 -6

-use enum instead of macro define
-move some structure define and macro to f_rockusb.h
-add some function comment as Simon required
-address other comment from Simon
-fix build error as Lukasz point out
 
---
 MAINTAINERS                                    |   5 +
 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 697 +++++++++++++++++++++++++
 5 files changed, 843 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 drivers/usb/gadget/f_rockusb.c

MAINTAINERS +5 -0

index 2a20b94..e92a15d 100644
@@ -452,6 +452,11 @@ S:	Maintained
 T:	git git://git.denx.de/u-boot-usb.git
 F:	drivers/usb/
 
+ROCKUSB
+M:	Eddie Cai <[email protected]>
+S:      Maintained
+F:	drivers/usb/gadget/f_rockusb.c
+
 VIDEO
 M:	Anatolij Gustschin <[email protected]>
 S:	Maintained

arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +11 -0

new file mode 100644
index 0000000..c207a78
@@ -0,0 +1,132 @@
+/*
+ * (C) Copyright 2017
+ *
+ * Eddie Cai <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _F_ROCKUSB_H_
+#define _F_ROCKUSB_H_
+#include <blk.h>

arch/arm/include/asm/arch-rockchip/f_rockusb.h line 21

Quoted 10 lines

arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +10 -0

+
+#define ROCKUSB_VERSION		"0.1"
+
+#define ROCKUSB_INTERFACE_CLASS	0xff
+#define ROCKUSB_INTERFACE_SUB_CLASS	0x06
+#define ROCKUSB_INTERFACE_PROTOCOL	0x05
+
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_2_0  (0x0200)
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_1_1  (0x0040)
+#define TX_ENDPOINT_MAXIMUM_PACKET_SIZE      (0x0040)

My V10 comments were not addressed, NAK.

Also, I'm not sure why you have 20 people on To: list , Cc would be preferred and trimming the list down to only relevant people would also be preferred.

Signature · 2 lines

Best regards,
Marek Vasut

Lukasz Majewski

2017-12-12 12:31 UTC #3 lore raw

PATCH v11 1/4 usb: rockchip: add the rockusb gadget

Hi Eddie,

Quoted 85 lines · Eddie Cai

Quoted 84 lines
this patch implement rockusb protocol on the device side. this is based on USB download gadget infrastructure. the rockusb function implements the rd, wl, rid commands. it can work with rkdeveloptool
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
---
Changes in v11:
(quoted diff) +0 -2
-fix checkpatch error
-add maintainer
Changes in v10:
-fix build error
Changes in v9:
-fix compile error
Changes in v8:
-none
Changes in v7:
-none
Changes in v6:
-move some data to f_rockusb structure
Changes in v5:
(quoted diff) +0 -2
-fix build error when build non-rockchip board
-fix checkpatch error
Changes in v4:
(quoted diff) +1 -6
-use enum instead of macro define
-move some structure define and macro to f_rockusb.h
-add some function comment as Simon required
-address other comment from Simon
-fix build error as Lukasz point out
 
---
 MAINTAINERS                                    |   5 +
 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 697
+++++++++++++++++++++++++ 5 files changed, 843 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 drivers/usb/gadget/f_rockusb.c
MAINTAINERS +5 -0
index 2a20b94..e92a15d 100644
@@ -452,6 +452,11 @@ S:	Maintained
 T:	git git://git.denx.de/u-boot-usb.git
 F:	drivers/usb/
 
+ROCKUSB
+M:	Eddie Cai <[email protected]>
+S:      Maintained
+F:	drivers/usb/gadget/f_rockusb.c
+
 VIDEO
 M:	Anatolij Gustschin <[email protected]>
 S:	Maintained
(quoted diff) +0 -0
b/arch/arm/include/asm/arch-rockchip/f_rockusb.h new file mode 100644 index 0000000..c207a78
arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +15 -0
@@ -0,0 +1,132 @@
+/*
+ * (C) Copyright 2017
+ *
+ * Eddie Cai <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _F_ROCKUSB_H_
+#define _F_ROCKUSB_H_
+#include <blk.h>
+
+#define ROCKUSB_VERSION		"0.1"
+
+#define ROCKUSB_INTERFACE_CLASS	0xff

Quoted 8 lines

arch/arm/include/asm/arch-rockchip/f_rockusb.h line 21
Quoted 6 lines
arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +6 -0
+#define ROCKUSB_INTERFACE_SUB_CLASS	0x06
+#define ROCKUSB_INTERFACE_PROTOCOL	0x05
+
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_2_0  (0x0200)
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_1_1  (0x0040)
+#define TX_ENDPOINT_MAXIMUM_PACKET_SIZE      (0x0040)  
My V10 comments were not addressed, NAK.

Do you plan to address Marek's comments and prepare next version ?

Quoted 4 lines

Also, I'm not sure why you have 20 people on To: list , Cc would be preferred and trimming the list down to only relevant people would also be preferred.

Best regards,

Lukasz Majewski

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171212/53b9ea2d/attachment.sig>

Eddie Cai

author

2017-12-15 00:19 UTC #4 lore raw

PATCH v11 1/4 usb: rockchip: add the rockusb gadget

Hi Lukasz

2017-12-12 20:31 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 96 lines

Hi Eddie,
Quoted 85 lines · Eddie Cai
Quoted 84 lines
this patch implement rockusb protocol on the device side. this is based on USB download gadget infrastructure. the rockusb function implements the rd, wl, rid commands. it can work with rkdeveloptool
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
---
Changes in v11:
(quoted diff) +0 -2
-fix checkpatch error
-add maintainer
Changes in v10:
-fix build error
Changes in v9:
-fix compile error
Changes in v8:
-none
Changes in v7:
-none
Changes in v6:
-move some data to f_rockusb structure
Changes in v5:
(quoted diff) +0 -2
-fix build error when build non-rockchip board
-fix checkpatch error
Changes in v4:
(quoted diff) +1 -6
-use enum instead of macro define
-move some structure define and macro to f_rockusb.h
-add some function comment as Simon required
-address other comment from Simon
-fix build error as Lukasz point out
 
---
 MAINTAINERS                                    |   5 +
 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 697
+++++++++++++++++++++++++ 5 files changed, 843 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 drivers/usb/gadget/f_rockusb.c
MAINTAINERS +5 -0
index 2a20b94..e92a15d 100644
@@ -452,6 +452,11 @@ S:     Maintained
 T: git git://git.denx.de/u-boot-usb.git
 F: drivers/usb/
 
+ROCKUSB
+M: Eddie Cai <[email protected]>
+S:      Maintained
+F: drivers/usb/gadget/f_rockusb.c
+
 VIDEO
 M: Anatolij Gustschin <[email protected]>
 S: Maintained
(quoted diff) +0 -0
b/arch/arm/include/asm/arch-rockchip/f_rockusb.h new file mode 100644 index 0000000..c207a78
arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +15 -0
@@ -0,0 +1,132 @@
+/*
+ * (C) Copyright 2017
+ *
+ * Eddie Cai <[email protected]>
+ *
+ * SPDX-License-Identifier:        GPL-2.0+
+ */
+
+#ifndef _F_ROCKUSB_H_
+#define _F_ROCKUSB_H_
+#include <blk.h>
+
+#define ROCKUSB_VERSION            "0.1"
+
+#define ROCKUSB_INTERFACE_CLASS    0xff
Quoted 8 lines
arch/arm/include/asm/arch-rockchip/f_rockusb.h line 21
Quoted 6 lines
arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +6 -0
+#define ROCKUSB_INTERFACE_SUB_CLASS        0x06
+#define ROCKUSB_INTERFACE_PROTOCOL 0x05
+
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_2_0  (0x0200)
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_1_1  (0x0040)
+#define TX_ENDPOINT_MAXIMUM_PACKET_SIZE      (0x0040)
My V10 comments were not addressed, NAK.

Quoted 1 line

Do you plan to address Marek's comments and prepare next version ?

I just addressed all the comment and sent out V12 patches.

Quoted 17 lines

Quoted 5 lines
Also, I'm not sure why you have 20 people on To: list , Cc would be preferred and trimming the list down to only relevant people would also be preferred.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Eddie Cai

author

2017-12-01 07:20 UTC #5 lore raw

PATCH v11 2/4 usb: rockchip: add rockusb command

In reply to Eddie Cai

this patch add rockusb command. the usage is rockusb <USB_controller> <devtype> <dev[:part]> e.g. rockusb 0 mmc 0

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

---
Changes in v11:
-fix check patch error
-add maintainer

Changes in v10:
-fix build error

Changes in v9:
-fix compile error

Changes in v8:
-none

Changes in v7:
-none

Changes in v6:
-move some data to f_rockusb structure

Changes in v5:
-fix build error when build non-rockchip board -fix checkpatch error

---
 MAINTAINERS   |  1 +
 cmd/Kconfig   |  8 +++++++
 cmd/Makefile  |  1 +
 cmd/rockusb.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 84 insertions(+)
 create mode 100644 cmd/rockusb.c

MAINTAINERS +1 -0

index e92a15d..c7db583 100644
@@ -456,6 +456,7 @@ ROCKUSB
 M:	Eddie Cai <[email protected]>
 S:      Maintained
 F:	drivers/usb/gadget/f_rockusb.c
+F:	cmd/rockusb.c
 
 VIDEO
 M:	Anatolij Gustschin <[email protected]>

cmd/Kconfig +8 -0

index 5a6afab..b46bf41 100644
@@ -914,6 +914,14 @@ config CMD_USB_SDP
 	help
 	  Enables the command "sdp" which is used to have U-Boot emulating the
 	  Serial Download Protocol (SDP) via USB.
+config CMD_ROCKUSB
+	bool "rockusb"
+	depends on USB_FUNCTION_ROCKUSB
+	help
+          Rockusb protocol is widely used by Rockchip SoC based devices. It can
+	  read/write info, image to/from devices. This enable rockusb command
+	  support to communication with rockusb device. for more detail about
+	  this command, please read doc/README.rockusb.
 
 config CMD_USB_MASS_STORAGE
 	bool "UMS usb mass storage"

cmd/Makefile +1 -0

index 2b0444d..6837e9b 100644
@@ -105,6 +105,7 @@ obj-$(CONFIG_CMD_READ) += read.o
 obj-$(CONFIG_CMD_REGINFO) += reginfo.o
 obj-$(CONFIG_CMD_REISER) += reiser.o
 obj-$(CONFIG_CMD_REMOTEPROC) += remoteproc.o
+obj-$(CONFIG_CMD_ROCKUSB) += rockusb.o
 obj-$(CONFIG_SANDBOX) += host.o
 obj-$(CONFIG_CMD_SATA) += sata.o
 obj-$(CONFIG_CMD_NVME) += nvme.o

cmd/rockusb.c new file +74 -0

74 lines not on this page · raw message

Signature · 1 line

1.9.1

Eddie Cai

author

2017-12-01 07:20 UTC #6 lore raw

PATCH v11 3/4 rockchip:usb: add a simple readme for rockusb

In reply to Eddie Cai

add a simple readme to introduce rockusb and tell people how to use it

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

---
Changes in v11:
-add to MAINTAINER

Changes in v10:
-none

Changes in v9:
-none

Changes in v8:
-none

Changes in v7:
-none

Changes in v6:
-none

Changes in v5:
-none

Changes in v4:
-add some blank line to make it look better

Changes in v3:
-fix checkpatch error

---
 MAINTAINERS        |  1 +
 doc/README.rockusb | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 doc/README.rockusb

MAINTAINERS +1 -0

index c7db583..4bef71f 100644
@@ -457,6 +457,7 @@ M:	Eddie Cai <[email protected]>
 S:      Maintained
 F:	drivers/usb/gadget/f_rockusb.c
 F:	cmd/rockusb.c
+F:	doc/README.rockusb
 
 VIDEO
 M:	Anatolij Gustschin <[email protected]>

doc/README.rockusb new file +51 -0

51 lines not on this page · raw message

Signature · 1 line

1.9.1

Eddie Cai

author

2017-12-01 07:20 UTC #7 lore raw

PATCH v11 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

In reply to Eddie Cai

this patch enable rockusb support on rk3288 based device.

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

---
Changes in v11:
-none

Changes in v10:
-rebase to latest mainline U-Boot, add vyasa board support

Changes in v9:
-fix compile error

Changes in v8:
-fix compile error

Changes in v7:
-use imply in the Kconfig to enable rockusb

Changes in v6:
-enable rockusb in defconfig

Changes in v5:
-none

Changes in v4:
-move to rk3288_common.h

Changes in v3:
-move to defconfig

---
 arch/arm/mach-rockchip/Kconfig      |  2 ++
 configs/chromebit_mickey_defconfig  |  7 +++++++
 configs/chromebook_jerry_defconfig  |  7 +++++++
 configs/chromebook_minnie_defconfig |  7 +++++++
 configs/evb-rk3288_defconfig        |  9 +++++++++
 configs/fennec-rk3288_defconfig     |  5 +++++
 configs/firefly-rk3288_defconfig    |  7 +++++++
 configs/miqi-rk3288_defconfig       |  5 +++++
 configs/phycore-rk3288_defconfig    |  6 ++++++
 configs/popmetal-rk3288_defconfig   |  5 +++++
 configs/rock2_defconfig             |  8 ++++++++
 configs/tinker-rk3288_defconfig     |  5 +++++
 configs/vyasa-rk3288_defconfig      | 25 +++++++++++++++++++++++++
 13 files changed, 98 insertions(+)

arch/arm/mach-rockchip/Kconfig +2 -0

index a26736a..186018c 100644
@@ -52,6 +52,8 @@ config ROCKCHIP_RK3288
 	select SPL_BOARD_INIT if SPL
 	select SUPPORT_SPL
 	select SPL
+	imply USB_FUNCTION_ROCKUSB
+	imply CMD_ROCKUSB
 	help
 	  The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17
 	  including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two

configs/chromebit_mickey_defconfig +7 -0

index c74a006..2a74784 100644
@@ -22,6 +22,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SF_TEST=y
 CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -78,6 +79,7 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
 CONFIG_USB_GADGET_VENDOR_NUM=0x2207
 CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_STORAGE=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y

@@ -86,3 +88,8 @@ CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
 # CONFIG_SPL_OF_LIBFDT is not set
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/chromebook_jerry_defconfig +7 -0

index 9576c30..81ed7d0 100644
@@ -24,6 +24,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SF_TEST=y
 CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -79,6 +80,7 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
 CONFIG_USB_GADGET_VENDOR_NUM=0x2207
 CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_STORAGE=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y

@@ -88,3 +90,8 @@ CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
 # CONFIG_SPL_OF_LIBFDT is not set
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/chromebook_minnie_defconfig +7 -0

index 197c242..0565c03 100644
@@ -23,6 +23,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SF_TEST=y
 CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -78,6 +79,7 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
 CONFIG_USB_GADGET_VENDOR_NUM=0x2207
 CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_STORAGE=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y

@@ -88,3 +90,8 @@ CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
 # CONFIG_SPL_OF_LIBFDT is not set
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/evb-rk3288_defconfig +9 -0

index e944f97..6024b86 100644
@@ -20,6 +20,7 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -74,6 +75,14 @@ CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y
 CONFIG_VIDEO_ROCKCHIP_MAX_YRES=1200
 CONFIG_DISPLAY_ROCKCHIP_MIPI=y
+CONFIG_USB=y
+CONFIG_USB_DWC2=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/fennec-rk3288_defconfig +5 -0

index 008776e..d76e8c4 100644
@@ -78,3 +78,8 @@ CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/firefly-rk3288_defconfig +7 -0

index bd7e1a0..e9eb20c 100644
@@ -21,6 +21,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
+CONFIG_CMD_ROCKUSB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -80,6 +81,7 @@ CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
 CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_USB_FUNCTION_ROCKUSB=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y

@@ -88,3 +90,8 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/miqi-rk3288_defconfig +5 -0

index 7478f9b..d0bcbd8 100644
@@ -83,3 +83,8 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/phycore-rk3288_defconfig +6 -0

index bebc877..aea47c5 100644
@@ -69,6 +69,7 @@ CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
+CONFIG_USB_DWC2=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Rockchip"

@@ -81,3 +82,8 @@ CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/popmetal-rk3288_defconfig +5 -0

index 7453aca..6b860bb 100644
@@ -78,3 +78,8 @@ CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/rock2_defconfig +8 -0

index c76a0b9..43dce46 100644
@@ -20,6 +20,7 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -70,6 +71,8 @@ CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
 CONFIG_USB_GADGET_VENDOR_NUM=0x2207
 CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_DWC2=y
+CONFIG_USB_STORAGE=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y

@@ -78,3 +81,8 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/tinker-rk3288_defconfig +5 -0

index 1315be3..c79dffd 100644
@@ -81,3 +81,8 @@ CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/vyasa-rk3288_defconfig +25 -0

index 7091586..30ad478 100644
@@ -17,6 +17,9 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y

@@ -59,6 +62,28 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_DWC2=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_KEYBOARD=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_MANUFACTURER="Rockchip"
+CONFIG_USB_GADGET_VENDOR_NUM=0x2207
+CONFIG_USB_GADGET_PRODUCT_NUM=0x320a
+CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_HOST_ETHER=y
+CONFIG_USB_ETHER_ASIX=y
+CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_DM_VIDEO=y
+CONFIG_DISPLAY=y
+CONFIG_VIDEO_ROCKCHIP=y
+CONFIG_DISPLAY_ROCKCHIP_HDMI=y
+CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

Signature · 1 line

1.9.1